July 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: protection from NPE in the initialization of RunVm
by ahadas＠redhat.com 27 Jul '16

27 Jul '16

Arik Hadas has submitted this change and it was merged. Change subject: core: protection from NPE in the initialization of RunVm ...................................................................... core: protection from NPE in the initialization of RunVm Need to verify that the VM to run exists before accessing it. Change-Id: I2e3e7ff30777077cb1e96581574c484d7f71d65b Bug-Url: https://bugzilla.redhat.com/1360265 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java 1 file changed, 5 insertions(+), 6 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/61395 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2e3e7ff30777077cb1e96581574c484d7f71d65b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.2]: aaa: ENGINE_HTTPS_PKI_TRUST_STORE_PASSWORD handled insecurel...
by oourfali＠redhat.com 27 Jul '16

27 Jul '16

Oved Ourfali has submitted this change and it was merged. Change subject: aaa: ENGINE_HTTPS_PKI_TRUST_STORE_PASSWORD handled insecurely in log file ...................................................................... aaa: ENGINE_HTTPS_PKI_TRUST_STORE_PASSWORD handled insecurely in log file ENGINE_HTTPS_PKI_TRUST_STORE_PASSWORD should not be displayed in the log file. Change-Id: I11f2239dd6cbc8f624a8b14655d071823fae8e37 Bug-Url: https://bugzilla.redhat.com/1360387 Signed-off-by: Ravi Nori <rnori(a)redhat.com> (cherry picked from commit ad7138d73787d1e93de6fcf1d0fe7f6bd8887eee) --- M packaging/services/ovirt-engine/ovirt-engine.conf.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/61443 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I11f2239dd6cbc8f624a8b14655d071823fae8e37 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.2 Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: aaa: ENGINE_HTTPS_PKI_TRUST_STORE_PASSWORD handled insecurel...
by oourfali＠redhat.com 27 Jul '16

27 Jul '16

Oved Ourfali has submitted this change and it was merged. Change subject: aaa: ENGINE_HTTPS_PKI_TRUST_STORE_PASSWORD handled insecurely in log file ...................................................................... aaa: ENGINE_HTTPS_PKI_TRUST_STORE_PASSWORD handled insecurely in log file ENGINE_HTTPS_PKI_TRUST_STORE_PASSWORD should not be displayed in the log file. Change-Id: I11f2239dd6cbc8f624a8b14655d071823fae8e37 Bug-Url: https://bugzilla.redhat.com/1360387 Signed-off-by: Ravi Nori <rnori(a)redhat.com> (cherry picked from commit ad7138d73787d1e93de6fcf1d0fe7f6bd8887eee) --- M packaging/services/ovirt-engine/ovirt-engine.conf.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/61442 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I11f2239dd6cbc8f624a8b14655d071823fae8e37 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-live[ovirt-live-4.0]: build: oVirt Live 4.0.2 RC2
by sbonazzo＠redhat.com 27 Jul '16

27 Jul '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: oVirt Live 4.0.2 RC2 ...................................................................... build: oVirt Live 4.0.2 RC2 Change-Id: I2485d7506b4e5784c6075d32ee611f2d0611c2e9 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M centos-7/Makefile 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/61441 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2485d7506b4e5784c6075d32ee611f2d0611c2e9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-4.0 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: aaa: ENGINE_HTTPS_PKI_TRUST_STORE_PASSWORD handled insecurel...
by sbonazzo＠redhat.com 27 Jul '16

27 Jul '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: aaa: ENGINE_HTTPS_PKI_TRUST_STORE_PASSWORD handled insecurely in log file ...................................................................... aaa: ENGINE_HTTPS_PKI_TRUST_STORE_PASSWORD handled insecurely in log file ENGINE_HTTPS_PKI_TRUST_STORE_PASSWORD should not be displayed in the log file. Change-Id: I11f2239dd6cbc8f624a8b14655d071823fae8e37 Bug-Url: https://bugzilla.redhat.com/1360387 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M packaging/services/ovirt-engine/ovirt-engine.conf.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Martin Peřina: Looks good to me, but someone else must approve Ravi Nori: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/61430 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I11f2239dd6cbc8f624a8b14655d071823fae8e37 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.2]: webadmin: removed redundant source column header
by piotr.kliczewski＠gmail.com 26 Jul '16

26 Jul '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: removed redundant source column header ...................................................................... webadmin: removed redundant source column header Removed redundant 'Source' column header from disks table in VM dialog (Resource Allocation tab) and template dialog. Change-Id: Ia6c9ea2891637430cc9f300eb2b28bf0986275c0 Bug-Url: https://bugzilla.redhat.com/1358432 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/DisksAllocationModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageRegisterDiskImageListModel.java 2 files changed, 1 insertion(+), 7 deletions(-) Approvals: Daniel Erez: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/61399 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia6c9ea2891637430cc9f300eb2b28bf0986275c0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.2 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.2]: webadmin: fix tool-tip for disk hot-plug buttons
by piotr.kliczewski＠gmail.com 26 Jul '16

26 Jul '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: fix tool-tip for disk hot-plug buttons ...................................................................... webadmin: fix tool-tip for disk hot-plug buttons When disk hot-plug is not supported Activate/Deactivate buttons should display an appropriate tool-tip on hover. Hence, fixing tool-tip by examining support according to selected disks' interfaces. Change-Id: I5ab8b0c721bff17bbd422ff9b042804cadf0eb30 Bug-Url: https://bugzilla.redhat.com/1359632 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmDiskListModelTable.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java 2 files changed, 4 insertions(+), 29 deletions(-) Approvals: Daniel Erez: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/61400 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5ab8b0c721bff17bbd422ff9b042804cadf0eb30 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.2 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: webadmin: fix tool-tip for disk hot-plug buttons
by piotr.kliczewski＠gmail.com 26 Jul '16

26 Jul '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: fix tool-tip for disk hot-plug buttons ...................................................................... webadmin: fix tool-tip for disk hot-plug buttons When disk hot-plug is not supported Activate/Deactivate buttons should display an appropriate tool-tip on hover. Hence, fixing tool-tip by examining support according to selected disks' interfaces. Change-Id: I5ab8b0c721bff17bbd422ff9b042804cadf0eb30 Bug-Url: https://bugzilla.redhat.com/1359632 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmDiskListModelTable.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java 2 files changed, 4 insertions(+), 29 deletions(-) Approvals: Daniel Erez: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/61398 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5ab8b0c721bff17bbd422ff9b042804cadf0eb30 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: webadmin: removed redundant source column header
by piotr.kliczewski＠gmail.com 26 Jul '16

26 Jul '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: removed redundant source column header ...................................................................... webadmin: removed redundant source column header Removed redundant 'Source' column header from disks table in VM dialog (Resource Allocation tab) and template dialog. Change-Id: Ia6c9ea2891637430cc9f300eb2b28bf0986275c0 Bug-Url: https://bugzilla.redhat.com/1358432 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/DisksAllocationModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageRegisterDiskImageListModel.java 2 files changed, 1 insertion(+), 7 deletions(-) Approvals: Daniel Erez: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/61397 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia6c9ea2891637430cc9f300eb2b28bf0986275c0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.2]: webadmin, userportal: Improve the way logging works
by piotr.kliczewski＠gmail.com 26 Jul '16

26 Jul '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin,userportal: Improve the way logging works ...................................................................... webadmin,userportal: Improve the way logging works 1. all logging related code extracted into ApplicationLogManager 2. added "error is effectively the same as last one" detection: * on 1st occurence, error is logged as "Uncaught exception" * on 2nd occurence, error is logged as "Uncaught exception (2x)" * same message for any further occurences of the same error 3. error is remotely logged ONLY if both of following are true: * application (browser) window has focus * current error is NOT effectively the same as last one An error E1 is effectively the same as error E2 if and only if E1's stack trace has the same length as E2's stack trace and the stack trace elements are equal at any given index. Due to how GWT emulates java.lang.StackTraceElement, we're using StackTraceElement.toString() to capture all important info: declaringClass methodName fileName lineNumber Change-Id: I66c3c5c4ca2451403d1cdd8d29cca4823a90f4f2 Bug-Url: https://bugzilla.redhat.com/1358136 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/gin/BaseSystemModule.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/logging/ApplicationLogManager.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/system/ApplicationFocusManager.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/system/BaseApplicationInit.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/system/ApplicationInit.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/system/ApplicationInit.java 6 files changed, 149 insertions(+), 54 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Vojtech Szocs: Verified -- To view, visit https://gerrit.ovirt.org/61414 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I66c3c5c4ca2451403d1cdd8d29cca4823a90f4f2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.2 Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0