July 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-4.0.2]: core: setting DiskVmElement on extend Cinder disk
by piotr.kliczewski＠gmail.com 25 Jul '16

25 Jul '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: setting DiskVmElement on extend Cinder disk ...................................................................... core: setting DiskVmElement on extend Cinder disk UpdateVmDiskCommand -> buildExtendCinderDiskParameters: diskInterface is missing from DiskVmElement, hence the command is failing on validation. To mitigate the issue, fetched and cloned oldDiskVmElement. Change-Id: I0063ee101bba67223040bed43fa775608345d11c Bug-Url: https://bugzilla.redhat.com/1359489 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/UpdateVmDiskCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Daniel Erez: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/61300 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0063ee101bba67223040bed43fa775608345d11c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.2 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.2]: webadmin: image upload - remove image source panel
by piotr.kliczewski＠gmail.com 25 Jul '16

25 Jul '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: image upload - remove image source panel ...................................................................... webadmin: image upload - remove image source panel Image Upload dialog: removed 'Image Source' panel as uploading using URI is currently not supported. Change-Id: Ia7ac2b774feedd93cc1b6b4ac76b14b02df554dd Bug-Url: https://bugzilla.redhat.com/1358729 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/UploadImagePopupView.ui.xml 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/61195 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia7ac2b774feedd93cc1b6b4ac76b14b02df554dd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.2 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.2]: webadmin: upload image - validate image selection
by piotr.kliczewski＠gmail.com 25 Jul '16

25 Jul '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: upload image - validate image selection ...................................................................... webadmin: upload image - validate image selection On 'Image Upload' dialog, when no file is selected, there's no validation and indication upon pressing the OK button. Hence, added a proper validation and an error message when no file is selected. Change-Id: I7e30411b6c2dfd052f93f479318d3090ca1981ee Bug-Url: https://bugzilla.redhat.com/1358727 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/UploadImageModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants.properties M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/UploadImagePopupView.java 4 files changed, 25 insertions(+), 3 deletions(-) Approvals: Daniel Erez: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/61196 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7e30411b6c2dfd052f93f479318d3090ca1981ee Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.2 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.2]: webadmin: improve host kernel configuration message
by piotr.kliczewski＠gmail.com 25 Jul '16

25 Jul '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: improve host kernel configuration message ...................................................................... webadmin: improve host kernel configuration message In order to modify kernel boot parameters from webadmin (hosts tab -> edit host -> kernel tab), the admin must reinstall (via webadmin) and then manually reboot the host after modifying the kernel cmdline. Improving the message appears in the kernel boot parameters dialog so that it will be clear that this procedure is needed in order to make the changes to take effect. Change-Id: I619eb9ac697db8300bbc0c3926354c6eeddbb953 Bug-Url: https://bugzilla.redhat.com/1351283 Signed-off-by: Sharon Gratch <sgratch(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/CommonApplicationConstants.properties M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.ui.xml 3 files changed, 12 insertions(+), 3 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Passed CI tests Sharon Gratch: Verified -- To view, visit https://gerrit.ovirt.org/61279 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I619eb9ac697db8300bbc0c3926354c6eeddbb953 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.2 Gerrit-Owner: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.2]: webadmin: v2v-"external provider" refreshed by DC
by piotr.kliczewski＠gmail.com 25 Jul '16

25 Jul '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: v2v-"external provider" refreshed by DC ...................................................................... webadmin: v2v-"external provider" refreshed by DC In v2v import dialog, the "External Provider" field values in pull down menu are refreshed if the selected "Data Center" field value is changed (The same as done if "Source" field value is changes). The values on the "Exteranl Provider" field pull down menu are according to the current selected data center and source. Change-Id: Ie28722599ec2e6e1c108bf1d5479e6700e05cae4 Bug-Url: https://bugzilla.redhat.com/1354495 Signed-off-by: Sharon Gratch <sgratch(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmsModel.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Passed CI tests Sharon Gratch: Verified -- To view, visit https://gerrit.ovirt.org/61278 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie28722599ec2e6e1c108bf1d5479e6700e05cae4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.2 Gerrit-Owner: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.2]: webadmin: remove msg of Native USB on clusters < 3.2
by piotr.kliczewski＠gmail.com 25 Jul '16

25 Jul '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: remove msg of Native USB on clusters < 3.2 ...................................................................... webadmin: remove msg of Native USB on clusters < 3.2 This patch removed the following warning message appeared in New/Edit VM dialog, Console tab, while selecting USB Support to be "Native": "Migration is NOT currently supported using SPICE Native USB redirection on cluster version lower than 3.2". This message is no longer relevant on version 4.0.1 as the lowest supported cluster version is 3.6. Change-Id: I959f5c4e44c686d5e4d30d11cfff834b44b55e78 Bug-Url: https://bugzilla.redhat.com/1351200 Signed-off-by: Sharon Gratch <sgratch(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/CommonApplicationConstants.properties 4 files changed, 0 insertions(+), 35 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Passed CI tests Sharon Gratch: Verified -- To view, visit https://gerrit.ovirt.org/61280 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I959f5c4e44c686d5e4d30d11cfff834b44b55e78 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.2 Gerrit-Owner: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.2]: core: Change default value of DwhHeartBeatInterval
by piotr.kliczewski＠gmail.com 25 Jul '16

25 Jul '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: Change default value of DwhHeartBeatInterval ...................................................................... core: Change default value of DwhHeartBeatInterval Lowers default value of DwhHeartBeatInterval in vdc_options from 30 seconds to 15 seconds (if users changed default value using engine-config we will preserve value defined by users). Change-Id: Iea4656e74d1bff1bdc68f1fa44d03d55febbc39b Bug-Url: https://bugzilla.redhat.com/1344935 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql M packaging/etc/engine-config/engine-config.properties 3 files changed, 5 insertions(+), 2 deletions(-) Approvals: Martin Peřina: Verified Eli Mesika: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/61296 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iea4656e74d1bff1bdc68f1fa44d03d55febbc39b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.2 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Fix log message for CPU and memory balancing
by rgolan＠redhat.com 25 Jul '16

25 Jul '16

Roy Golan has submitted this change and it was merged. Change subject: core: Fix log message for CPU and memory balancing ...................................................................... core: Fix log message for CPU and memory balancing When CPU and memory balancing policy cannot be applied on a cluster using the primary or secondary methods - the warning log messages states that all hosts are over utilized which is not the case in some implementations such as power saving balancing. Log messages where changed to be more clear. Change-Id: Ib776cdbd90d8ee9023955cf64616125ac008a52a Bug-Url: https://bugzilla.redhat.com/1353059 Signed-off-by: yquinn <yquinn(a)redhat.com> (cherry picked from commit dc0bb4b) Signed-off-by: yquinn <yquinn(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/CpuAndMemoryBalancingPolicyUnit.java 1 file changed, 6 insertions(+), 2 deletions(-) Approvals: Martin Sivák: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved Yanir Quinn: Verified -- To view, visit https://gerrit.ovirt.org/60596 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib776cdbd90d8ee9023955cf64616125ac008a52a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-ha[master]: automation: add standard ci automation
by msivak＠redhat.com 25 Jul '16

25 Jul '16

Martin Sivák has submitted this change and it was merged. Change subject: automation: add standard ci automation ...................................................................... automation: add standard ci automation Change-Id: Iccd091a3824e3f5f80c6e4f77790635b5e4a21c9 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- A automation/build-artifacts.packages A automation/build-artifacts.repos A automation/build-artifacts.sh A automation/check-merged.packages A automation/check-merged.repos A automation/check-merged.sh A automation/check-patch.packages A automation/check-patch.repos A automation/check-patch.sh 9 files changed, 56 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified Martin Sivák: Looks good to me, approved Eyal Edri: Looks good to me, but someone else must approve Barak Korren: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60672 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iccd091a3824e3f5f80c6e4f77790635b5e4a21c9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-guest-agent[ovirt-4.0]: windows: Apply timer usage parameters for best performance
by vfeenstr＠redhat.com 25 Jul '16

25 Jul '16

Vinzenz Feenstra has submitted this change and it was merged. Change subject: windows: Apply timer usage parameters for best performance ...................................................................... windows: Apply timer usage parameters for best performance The configuration should be now done like this: - For versions above Windows 2003/Vista we're going to delete the USEPLATFORMCLOCK value to let the windows kernel decide the best option by itself This functionality can be disabled by setting the value general.apply_timer_configuration in the configuration to false Change-Id: I8a344002ac4206a6125755a4b0195777cdfadcf9 Bug-Url: https://bugzilla.redhat.com/1335309 Bug-Url: https://bugzilla.redhat.com/1354532 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> (cherry picked from commit 218d9145fb7b7bf87a3a307c40e2d8a789352523) --- M configurations/default.ini M configurations/ovirt-guest-agent.ini M ovirt-guest-agent/GuestAgentWin32.py 3 files changed, 23 insertions(+), 10 deletions(-) Approvals: Vinzenz Feenstra: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/61301 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8a344002ac4206a6125755a4b0195777cdfadcf9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0