July 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Add Test annotation in VmDeviceDaoTest
by tnisan＠redhat.com 17 Jul '16

17 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Add Test annotation in VmDeviceDaoTest ...................................................................... core: Add Test annotation in VmDeviceDaoTest Add @Test to testUpdateVmDeviceUsingScsiReservationProperty so it will actually be tested Change-Id: Ida4e1870b0c63b24fc5f42512e66045f50bd0fcb Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDeviceDaoTest.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Freddy Rolland: Looks good to me, but someone else must approve Idan Shaby: Looks good to me, but someone else must approve Ala Hino: Looks good to me, but someone else must approve Liron Aravot: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/60693 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ida4e1870b0c63b24fc5f42512e66045f50bd0fcb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: qos: Update Disk QoS on disk profile change
by tnisan＠redhat.com 17 Jul '16

17 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: qos: Update Disk QoS on disk profile change ...................................................................... qos: Update Disk QoS on disk profile change When the disk profile on a disk is changed, the QoS updates are sent to all VMs with that disk assigned. Prior to that patch only QoS changes on the profile were live updated. Change-Id: If1dbe1f7bd3962500683fd20c26a97712dd179d0 Bug-Url: https://bugzilla.redhat.com/1328731 Signed-off-by: Roman Mohr <rmohr(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmSlaPolicyUtils.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/UpdateDiskProfileCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/qos/RemoveStorageQosCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/qos/UpdateStorageQosCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/UpdateVmDiskCommand.java 5 files changed, 29 insertions(+), 21 deletions(-) Approvals: Roman Mohr: Verified Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/59128 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If1dbe1f7bd3962500683fd20c26a97712dd179d0 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Eliminate DbFacade.setInstance method
by masayag＠redhat.com 17 Jul '16

17 Jul '16

Moti Asayag has submitted this change and it was merged. Change subject: core: Eliminate DbFacade.setInstance method ...................................................................... core: Eliminate DbFacade.setInstance method Hooray!!!! Change-Id: I15cb1471922302bbe00d82266d06a9652de1bec2 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/numa/vm/AddVmNumaNodesCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/numa/vm/RemoveVmNumaNodesCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/numa/vm/SetVmNumaNodesCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/numa/vm/UpdateVmNumaNodesCommandTest.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java 5 files changed, 0 insertions(+), 24 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/58953 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I15cb1471922302bbe00d82266d06a9652de1bec2 Gerrit-PatchSet: 26 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Return LowUtiliztion parameter to power saving policy
by rgolan＠redhat.com 17 Jul '16

17 Jul '16

Roy Golan has submitted this change and it was merged. Change subject: core: Return LowUtiliztion parameter to power saving policy ...................................................................... core: Return LowUtiliztion parameter to power saving policy The LowUtilization parameter was removed from power saving policy. This patch returns it. Change-Id: I3026a9d22e404836d2581afeb1e21f513981cdf2 Bug-Url: https://bugzilla.redhat.com/1351556 Signed-off-by: Jenny Tokar <jtokar(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/PowerSavingBalancePolicyUnit.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Martin Sivák: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved Jenny Tokar: Verified -- To view, visit https://gerrit.ovirt.org/60671 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3026a9d22e404836d2581afeb1e21f513981cdf2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Cluster version update locks all VMs
by ahadas＠redhat.com 17 Jul '16

17 Jul '16

Arik Hadas has submitted this change and it was merged. Change subject: core: Cluster version update locks all VMs ...................................................................... core: Cluster version update locks all VMs Updating cluster version needs to call UpdateVmCommand to update VM devices (https://gerrit.ovirt.org/#/c/55636/) This patch adds locking of all necessary VMs in the UpdateClusterCommand if version is being changed. Locks are passed to UpdateVmCommand by setting LockProperties scope to None. Change-Id: I072a7d2104f91e93ca0460c4b658fb4dfb8d3ced Bug-Url: https://bugzilla.redhat.com/1349526 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateClusterCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 8 files changed, 57 insertions(+), 21 deletions(-) Approvals: Jenkins CI: Passed CI tests Arik Hadas: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/60414 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I072a7d2104f91e93ca0460c4b658fb4dfb8d3ced Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: automation: enable gwt compilation if userporal or webadmin ...
by tnisan＠redhat.com 17 Jul '16

17 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: automation: enable gwt compilation if userporal or webadmin changed ...................................................................... automation: enable gwt compilation if userporal or webadmin changed also run gwt compilation if any common backend modules that touch gwt changes Change-Id: I8c1f54cd3292c734cc3f00889cccde6988d77cb0 Signed-off-by: Eyal Edri <eedri(a)redhat.com> --- M automation/check-patch.sh 1 file changed, 21 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Martin Peřina: Looks good to me, approved Eyal Edri: Verified Jenkins CI: Passed CI tests Vojtech Szocs: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/60118 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8c1f54cd3292c734cc3f00889cccde6988d77cb0 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: aaa: Users with '%' in their password, cannot log in.
by tnisan＠redhat.com 17 Jul '16

17 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: aaa: Users with '%' in their password, cannot log in. ...................................................................... aaa: Users with '%' in their password, cannot log in. Login form parameters don't need to be decoded Change-Id: Id1946fa9017b7a01e240a24e3fcca0ff0622300b Bug-Url: https://bugzilla.redhat.com/1352721 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/InteractiveAuthServlet.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/InteractiveChangePasswdServlet.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SsoUtils.java M backend/manager/modules/enginesso/src/main/webapp/WEB-INF/login.jsp 4 files changed, 14 insertions(+), 8 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Ravi Nori: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60760 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id1946fa9017b7a01e240a24e3fcca0ff0622300b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core :fix PowerSavingWeight score calculation
by tnisan＠redhat.com 17 Jul '16

17 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: core :fix PowerSavingWeight score calculation ...................................................................... core :fix PowerSavingWeight score calculation EvenDistributionWeightPolicy unit calculated a weight score that was comprised from CPU usage and memory consumption. This calculation was wrong (which Power saving weight module relied on) there was a need to separate the weight policy units to 2 units : EvenDistributionCPUWeightPolicy and EvenDistributionMemoryWeightPolicy which produced 2 new power saving units: PowerSavingMemoryWeightPolicyUnit and PowerSavingMemoryCPUPolicyUnit instead of PowerSavingWeightPolicyUnit. CPU usage is calculated as before (power saving unit takes the opposite score) Memory score is calculated by the range of 1 to the maximum available memory of a host in the cluster and normalized to the score range. NonWeightPolicy unit was removed and will replaced with memory and CPU even distribution policies under the default 'None' scheduling policy Change-Id: I4ed2fa107b4c1139a4a4f9c07894472280acbf6b Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1349345 Signed-off-by: Yanir Quinn <yquinn(a)redhat.com> Signed-off-by: yquinn <yquinn(a)redhat.com> (cherry picked from commit 6037d1886788e42d9a923fe670b84da907da5e16) Signed-off-by: yquinn <yquinn(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/PolicyUnitImpl.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/EvenDistributionCPUWeightPolicyUnit.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/EvenDistributionMemoryWeightPolicyUnit.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/EvenDistributionWeightPolicyUnit.java C backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/PowerSavingCPUWeightPolicyUnit.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/PowerSavingMemoryWeightPolicyUnit.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/PowerSavingWeightPolicyUnit.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/policyunits/EvenDistributionWeightPolicyUnitTest.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/policyunits/PowerSavingWeightPolicyUnitTest.java A packaging/dbscripts/upgrade/03_06_2160_add_memory_cpu_policy_units.sql 10 files changed, 330 insertions(+), 106 deletions(-) Approvals: Martin Sivák: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved Yanir Quinn: Verified -- To view, visit https://gerrit.ovirt.org/59787 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4ed2fa107b4c1139a4a4f9c07894472280acbf6b Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-dwh[ovirt-engine-dwh-3.6]: automation: fix el6 building
by Shirly Radco 17 Jul '16

17 Jul '16

Shirly Radco has submitted this change and it was merged. Change subject: automation: fix el6 building ...................................................................... automation: fix el6 building Solves build error on missing dom4j on el6 builds Change-Id: Ie87c8e991307dcf0909ea99d99b2a69fa21a403e Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M automation/build-artifacts.packages.el6 A automation/build-artifacts.repos.el6 M automation/check-merged.packages.el6 A automation/check-merged.repos.el6 M automation/check-patch.packages.el6 A automation/check-patch.repos.el6 6 files changed, 18 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Verified Shirly Radco: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60588 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie87c8e991307dcf0909ea99d99b2a69fa21a403e Gerrit-PatchSet: 6 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-engine-dwh-3.6 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: Revert "core: remove stats updates"
by ahadas＠redhat.com 17 Jul '16

17 Jul '16

Arik Hadas has submitted this change and it was merged. Change subject: Revert "core: remove stats updates" ...................................................................... Revert "core: remove stats updates" This reverts commit 794a63862aa1ef596630fd2799bebdb95fa7731d. Change-Id: I76446b265792a2abfd1c56d24c1ec6e545b06179 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/DestroyVmVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/SetVmStatusVDSCommand.java 2 files changed, 2 insertions(+), 3 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Arik Hadas: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/60844 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I76446b265792a2abfd1c56d24c1ec6e545b06179 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0