July 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-4.0]: restapi: Add support for generating random doubles
by tnisan＠redhat.com 05 Jul '16

05 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Add support for generating random doubles ...................................................................... restapi: Add support for generating random doubles Our testing framework generates random data for types, but it doesn't support the "double" type. This patch fixes that limitation. Change-Id: I34599c55871bfbf0063af52a7232486ca9d3f4f2 Related-To: https://bugzilla.redhat.com/1346918 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 7797fa8b587ee172cdff589c66e71de8f0db1ae0) --- M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/MappingTestHelper.java 1 file changed, 35 insertions(+), 16 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60196 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I34599c55871bfbf0063af52a7232486ca9d3f4f2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-dwh[ovirt-engine-dwh-4.0]: build: after build dwh for 4.0.1
by Shirly Radco 05 Jul '16

05 Jul '16

Shirly Radco has submitted this change and it was merged. Change subject: build: after build dwh for 4.0.1 ...................................................................... build: after build dwh for 4.0.1 Change-Id: Ide8d563a89030cec9b827509dc53d15e51c514be Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M version.mak 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60180 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ide8d563a89030cec9b827509dc53d15e51c514be Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-engine-dwh-4.0 Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-dwh[ovirt-engine-dwh-4.0]: build: dwh build for 4.0.1
by Shirly Radco 05 Jul '16

05 Jul '16

Shirly Radco has submitted this change and it was merged. Change subject: build: dwh build for 4.0.1 ...................................................................... build: dwh build for 4.0.1 Added release notes. Change-Id: I722f71318e20e8d21b4e26e513da4cf110604d0c Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M ovirt-engine-dwh.spec.in M version.mak 2 files changed, 8 insertions(+), 2 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60179 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I722f71318e20e8d21b4e26e513da4cf110604d0c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-engine-dwh-4.0 Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: restapi: Populate links of disk attachments
by tnisan＠redhat.com 05 Jul '16

05 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Populate links of disk attachments ...................................................................... restapi: Populate links of disk attachments Currently the disk attachments don't have links because the reference to the parent virtual machine isn't populated. This patch fixes that issue. Change-Id: I5dabae64ad5fbf48a8f085cad4d302974cd79df7 Bug-Url: https://bugzilla.redhat.com/1352657 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 9f32df697623b6763139efc895a8fd0ae94b5c0f) --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/util/LinkHelper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/DiskAttachmentMapper.java 2 files changed, 22 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60193 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5dabae64ad5fbf48a8f085cad4d302974cd79df7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Support removing of vms/{vm_id}/disks from the API
by tnisan＠redhat.com 05 Jul '16

05 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Support removing of vms/{vm_id}/disks from the API ...................................................................... restapi: Support removing of vms/{vm_id}/disks from the API Change-Id: Ied6664b2cbe31e3f5fea1d6264d671cb0d3b2a58 Bug-Url: https://bugzilla.redhat.com/1346918 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/helpers/V3VmHelper.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3VmServer.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3VmsServer.java 4 files changed, 72 insertions(+), 5 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved; Passed CI tests Juan Hernandez: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/60158 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ied6664b2cbe31e3f5fea1d6264d671cb0d3b2a58 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Update to model 4.1.4
by tnisan＠redhat.com 05 Jul '16

05 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Update to model 4.1.4 ...................................................................... restapi: Update to model 4.1.4 The relevant changes in this version of the model are the following: * Removed the `disks` locator from the virtual machine service, as it has been replaced by `diskAttachments`. * Added missing links to all types. Change-Id: I68fe6cbd31d6deeb9352255a837c996d6102e82f Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3VmServer.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/util/LinkHelperTest.java M pom.xml 4 files changed, 3 insertions(+), 19 deletions(-) Approvals: Tal Nisan: Passed CI tests Juan Hernandez: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/60188 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I68fe6cbd31d6deeb9352255a837c996d6102e82f Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: webadmin: fix UI exceptions in volumes tab
by tnisan＠redhat.com 05 Jul '16

05 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: fix UI exceptions in volumes tab ...................................................................... webadmin: fix UI exceptions in volumes tab This patch fixes the UI exceptions in following places 1. Exceptions are flooded in the UI, with user hower over the the empty Activities column in Gluster Volumes tab and Bricks Subtab. There is a NPE in VolumeActivityCompositeCell. getContainerElement() method. Fixed this issue by showing the composite cell always. When there is not activity in the volume then we will add a table with empty row. 2. There is an exception in UI, when there is no suitable cluster for gep rep slave. We should not try to set the selection when the list itself is empty. Change-Id: If1fcfb584dd250ec7550df98eeb4dfe7c442fc5a Bug-Url: https://bugzilla.redhat.com/1303878 Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> (cherry picked from commit dde3b1190ac518980e9ec12815899da5e845f65f) --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/GlusterVolumeGeoRepCreateModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVolumeView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/gluster/SubTabVolumeBrickView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/cell/VolumeActivityCompositeCell.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/cell/VolumeActivitySeperatorCell.java 5 files changed, 24 insertions(+), 29 deletions(-) Approvals: Jenkins CI: Passed CI tests Sahina Bose: Looks good to me, approved Ramesh N: Verified -- To view, visit https://gerrit.ovirt.org/60085 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If1fcfb584dd250ec7550df98eeb4dfe7c442fc5a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Add support for generating random doubles
by juan.hernandez＠redhat.com 05 Jul '16

05 Jul '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Add support for generating random doubles ...................................................................... restapi: Add support for generating random doubles Our testing framework generates random data for types, but it doesn't support the "double" type. This patch fixes that limitation. Change-Id: I34599c55871bfbf0063af52a7232486ca9d3f4f2 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/MappingTestHelper.java 1 file changed, 35 insertions(+), 16 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60191 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I34599c55871bfbf0063af52a7232486ca9d3f4f2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Populate links of disk attachments
by juan.hernandez＠redhat.com 05 Jul '16

05 Jul '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Populate links of disk attachments ...................................................................... restapi: Populate links of disk attachments Currently the disk attachments don't have links because the reference to the parent virtual machine isn't populated. This patch fixes that issue. Change-Id: I5dabae64ad5fbf48a8f085cad4d302974cd79df7 Bug-Url: https://bugzilla.redhat.com/1352657 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/util/LinkHelper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/DiskAttachmentMapper.java 2 files changed, 22 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60161 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5dabae64ad5fbf48a8f085cad4d302974cd79df7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: GlusterBrickValidatorTest type inference
by amureini＠redhat.com 05 Jul '16

05 Jul '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: GlusterBrickValidatorTest type inference ...................................................................... core: GlusterBrickValidatorTest type inference Change-Id: I8a70de80a68560f999b9f9b4bf6c2bec33c57982 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/GlusterBrickValidatorTest.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/60173 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8a70de80a68560f999b9f9b4bf6c2bec33c57982 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0