August 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine-sdk[master]: Encode/decode test data using UTF-8
by omachace＠redhat.com 29 Aug '16

29 Aug '16

Ondra Machacek has submitted this change and it was merged. Change subject: Encode/decode test data using UTF-8 ...................................................................... Encode/decode test data using UTF-8 Currently the data sent and received by the tests isn't converted from strings to arrays of bytes. As a result the tests don't work with Python 3 because the HTTP server used by the tests requires bytes, not strings. This patch changes the tests so that they explicitly encode/decode the data. Change-Id: If7aad9db77ad12ebcd1d995060f4fddf820bcdfb Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M sdk/tests/server.py M sdk/tests/test_reader.py 2 files changed, 7 insertions(+), 5 deletions(-) Approvals: Ondra Machacek: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62931 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If7aad9db77ad12ebcd1d995060f4fddf820bcdfb Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[master]: Use HTTPMessage.get instead of HTTPMessage.getheader
by omachace＠redhat.com 29 Aug '16

29 Aug '16

Ondra Machacek has submitted this change and it was merged. Change subject: Use HTTPMessage.get instead of HTTPMessage.getheader ...................................................................... Use HTTPMessage.get instead of HTTPMessage.getheader In Python 3 the 'getheader' method doesn't work, but 'get' works in both Python 2 and Python 3. Change-Id: I7a7d6599dcc31cfc56f62e605229854aaab17dcd Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M sdk/tests/server.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Ondra Machacek: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62930 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7a7d6599dcc31cfc56f62e605229854aaab17dcd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[master]: Use alternative test imports for Python 3
by omachace＠redhat.com 29 Aug '16

29 Aug '16

Ondra Machacek has submitted this change and it was merged. Change subject: Use alternative test imports for Python 3 ...................................................................... Use alternative test imports for Python 3 Some of the dependencies used in the tests don't work in Python 3. This patch changes the corresponding 'import' statements so that they work with Python 2 and Python 3. Change-Id: If5049cd7ac445a56ebc4ac459961d0bfd112787b Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M sdk/tests/server.py 1 file changed, 12 insertions(+), 3 deletions(-) Approvals: Ondra Machacek: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62929 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If5049cd7ac445a56ebc4ac459961d0bfd112787b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[master]: Catch Unicode encode and decode exceptions
by omachace＠redhat.com 29 Aug '16

29 Aug '16

Ondra Machacek has submitted this change and it was merged. Change subject: Catch Unicode encode and decode exceptions ...................................................................... Catch Unicode encode and decode exceptions When an incorrect ASCII string is passed to the 'encode' method it generates an 'UnicodeDecodeError' exception and we catch it. But in Python 3 it generates 'UnicodeEncodeError', and we don't catch it. As a result we don't handle this situation correctly in Python 3. This patch changes the SDK so that it catches both exceptions, so that it will work with Python 2 and 3. Change-Id: I9d5da5fcd9a6e8de51acd1aaa00a63797700617f Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M sdk/lib/ovirtsdk4/__init__.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ondra Machacek: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62928 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9d5da5fcd9a6e8de51acd1aaa00a63797700617f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[master]: Make sure that query parameters are always sorted
by omachace＠redhat.com 29 Aug '16

29 Aug '16

Ondra Machacek has submitted this change and it was merged. Change subject: Make sure that query parameters are always sorted ...................................................................... Make sure that query parameters are always sorted Currently when we format query parameters we depend on the internal sorting of the Python 'dict' type. This isn't convenient, specially for tets, as it isn't possible to predict what will be the query string generated. To avoid that this patch changes the SDK so that it sorts the query parameters by name before creating the query string. Change-Id: I19028dad41872633a82d8cfece9625e782b9d222 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M sdk/lib/ovirtsdk4/__init__.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ondra Machacek: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62926 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I19028dad41872633a82d8cfece9625e782b9d222 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[sdk_4.0]: [maven-release-plugin] prepare for next development iteration
by juan.hernandez＠redhat.com 29 Aug '16

29 Aug '16

Juan Hernandez has submitted this change and it was merged. Change subject: [maven-release-plugin] prepare for next development iteration ...................................................................... [maven-release-plugin] prepare for next development iteration Change-Id: I32dfe94ac5c3af6d4c046b099b5b3d238aa12020 --- M generator/pom.xml M pom.xml M sdk/pom.xml 3 files changed, 4 insertions(+), 4 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62951 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I32dfe94ac5c3af6d4c046b099b5b3d238aa12020 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[sdk_4.0]: [maven-release-plugin] prepare release 4.0.0
by juan.hernandez＠redhat.com 29 Aug '16

29 Aug '16

Juan Hernandez has submitted this change and it was merged. Change subject: [maven-release-plugin] prepare release 4.0.0 ...................................................................... [maven-release-plugin] prepare release 4.0.0 Change-Id: I97a2b73a1b78261ff5c1c5751e4c563c66523d8f --- M generator/pom.xml M packaging/spec.el7.in M packaging/spec.fc23.in M packaging/spec.fc24.in M pom.xml M sdk/pom.xml 6 files changed, 7 insertions(+), 7 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62950 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I97a2b73a1b78261ff5c1c5751e4c563c66523d8f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: removing check on f24 due to yum plugin dep issue
by sbonazzo＠redhat.com 29 Aug '16

29 Aug '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: removing check on f24 due to yum plugin dep issue ...................................................................... removing check on f24 due to yum plugin dep issue Related-To: https://gerrit.ovirt.org/#/c/62585/ Change-Id: I8406e28918ba30a88d73e2e7becf8276757edff3 Signed-off-by: Eyal Edri <eedri(a)redhat.com> --- M jobs/confs/projects/repos-check-closure/repos-check-closure.yaml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62942 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8406e28918ba30a88d73e2e7becf8276757edff3 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: upgrade: enforcing current aaa mechanism
by stirabos＠redhat.com 29 Aug '16

29 Aug '16

Simone Tiraboschi has submitted this change and it was merged. Change subject: upgrade: enforcing current aaa mechanism ...................................................................... upgrade: enforcing current aaa mechanism Enforce that all the available aaa domains are using the new ovirt-engine-extension mechanism since engine 4.0 supports only that one. Change-Id: I7c64d5a45a67d6a222e65d3fd8fb183d33f5e8ba Bug-Url: https://bugzilla.redhat.com/1368604 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/plugins/gr-he-upgradeappliance/vm/configurevm.py 1 file changed, 168 insertions(+), 1 deletion(-) Approvals: Simone Tiraboschi: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/62857 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7c64d5a45a67d6a222e65d3fd8fb183d33f5e8ba Gerrit-PatchSet: 5 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in otopi[master]: machine_dialog: Fix prefix for valid values
by didi＠redhat.com 29 Aug '16

29 Aug '16

Yedidyah Bar David has submitted this change and it was merged. Change subject: machine_dialog: Fix prefix for valid values ...................................................................... machine_dialog: Fix prefix for valid values Change-Id: I94a4e469394ba0944230b08679ff9642418d9b1c Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M src/plugins/otopi/dialog/machine.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Simone Tiraboschi: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Yedidyah Bar David: Verified; Looks good to me, approved Lukas Bednar: Looks good to me, but someone else must approve Artyom Lukianov: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/62943 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I94a4e469394ba0944230b08679ff9642418d9b1c Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Artyom Lukianov <alukiano(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lukas Bednar <lbednar(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0