August 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine-sdk-ruby[sdk_4.0]: Add generic reader
by juan.hernandez＠redhat.com 30 Aug '16

30 Aug '16

Juan Hernandez has submitted this change and it was merged. Change subject: Add generic reader ...................................................................... Add generic reader Currently the SDK doesn't provide any mechanism to read an XML object without explicitly specifying its type. For example, to read a virtual machine the only method available is "VmReader.read_one". But there are situations where the SDK can't know in advance what type of object is going to be received from the server, for example "action" or "fault". To support that, this patch adds a new "Reader.read" method that decides the type of object based on the name of the first tag, and invokes the corresponding specific reader to read it. Change-Id: I3b8c9a4c1118e7b261a589e8185861c9acf36921 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 66ad419477cb644727cecaf62815bf4fe46d84ac) --- M generator/src/main/java/org/ovirt/sdk/ruby/ReadersGenerator.java M sdk/lib/ovirtsdk4/reader.rb M sdk/spec/reader_spec.rb 3 files changed, 164 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/62998 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3b8c9a4c1118e7b261a589e8185861c9acf36921 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Add generic reader
by juan.hernandez＠redhat.com 30 Aug '16

30 Aug '16

Juan Hernandez has submitted this change and it was merged. Change subject: Add generic reader ...................................................................... Add generic reader Currently the SDK doesn't provide any mechanism to read an XML object without explicitly specifying its type. For example, to read a virtual machine the only method available is "VmReader.read_one". But there are situations where the SDK can't know in advance what type of object is going to be received from the server, for example "action" or "fault". To support that, this patch adds a new "Reader.read" method that decides the type of object based on the name of the first tag, and invokes the corresponding specific reader to read it. Change-Id: I3b8c9a4c1118e7b261a589e8185861c9acf36921 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M generator/src/main/java/org/ovirt/sdk/ruby/ReadersGenerator.java M sdk/lib/ovirtsdk4/reader.rb M sdk/spec/reader_spec.rb 3 files changed, 164 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/62572 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3b8c9a4c1118e7b261a589e8185861c9acf36921 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-2.0]: console: remove virt-viewer dependency
by stirabos＠redhat.com 30 Aug '16

30 Aug '16

Simone Tiraboschi has submitted this change and it was merged. Change subject: console: remove virt-viewer dependency ...................................................................... console: remove virt-viewer dependency Remove virt-viewer dependency in favor of virsh console over TLS. Change-Id: Ifee27639ab3c65611b6328cd6bc03dc7ce575f22 Bug-Url: https://bugzilla.redhat.com/1333449 Bug-Url: https://bugzilla.redhat.com/1343882 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M man/hosted-engine.8 M ovirt-hosted-engine-setup.spec.in M src/bin/hosted-engine.in 3 files changed, 27 insertions(+), 19 deletions(-) Approvals: Simone Tiraboschi: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/61930 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifee27639ab3c65611b6328cd6bc03dc7ce575f22 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-2.0 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-iso-uploader[ovirt-iso-uploader-4.0]: automation: drop suffix on manual tarball build
by sbonazzo＠redhat.com 30 Aug '16

30 Aug '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: automation: drop suffix on manual tarball build ...................................................................... automation: drop suffix on manual tarball build We don't want to change anything in the versioning of the RPM built from tarball since it can be used for a release. Change-Id: Ia89e2970ad801066d5011a5b488ca002c5a89550 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M automation/build-artifacts-manual.sh 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/62996 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia89e2970ad801066d5011a5b488ca002c5a89550 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-iso-uploader Gerrit-Branch: ovirt-iso-uploader-4.0 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Avoid using static for config value.
by mlipchuk＠redhat.com 30 Aug '16

30 Aug '16

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Avoid using static for config value. ...................................................................... core: Avoid using static for config value. There is not reason to use static value for config value since this value is already cached from the DB. Change-Id: Ideb5d770cf836dd4a4e6519c6aac7db0f13e23f9 Bug-Url: https://bugzilla.redhat.com/1348405 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/DiskImagesValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/snapshots/CreateAllSnapshotsFromVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/snapshots/RemoveDiskSnapshotsCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/storage/DiskImagesValidatorTest.java 4 files changed, 1 insertion(+), 28 deletions(-) Approvals: Jenkins CI: Passed CI tests Maor Lipchuk: Looks good to me, approved Yanir Quinn: Verified -- To view, visit https://gerrit.ovirt.org/62946 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ideb5d770cf836dd4a4e6519c6aac7db0f13e23f9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Next run config applyCpuLater -> applyLater
by mbetak＠redhat.com 30 Aug '16

30 Aug '16

Martin Betak has submitted this change and it was merged. Change subject: webadmin: Next run config applyCpuLater -> applyLater ...................................................................... webadmin: Next run config applyCpuLater -> applyLater "Cpu" removed from names of VmNextRunConfigurationModel.applyCpuLater and VmNextRunConfigurationWidget.applyCpuLaterEditor since it deals with both cpu and memory. Change-Id: Ia9a7f0a4ffe303bc623f7a098b17325f66dcf6ab Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmNextRunConfigurationWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmNextRunConfigurationWidget.ui.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmNextRunConfigurationModel.java 5 files changed, 13 insertions(+), 13 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62614 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia9a7f0a4ffe303bc623f7a098b17325f66dcf6ab Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Pending VM changes dialog fix
by mbetak＠redhat.com 30 Aug '16

30 Aug '16

Martin Betak has submitted this change and it was merged. Change subject: webadmin: Pending VM changes dialog fix ...................................................................... webadmin: Pending VM changes dialog fix Dialog is shown even if there are only changes that "can be applied immediately", i.e. CPU or memory. Previously there had to be at least one change "that require VM restart" for the dialog to me shown. Change-Id: Ib730030c766450011d216f379c87fd6f15136006 Bug-Url: https://bugzilla.redhat.com/1351208 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmNextRunConfigurationWidget.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java 2 files changed, 8 insertions(+), 7 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62613 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib730030c766450011d216f379c87fd6f15136006 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: log reason for stopping vm only if set
by ahadas＠redhat.com 30 Aug '16

30 Aug '16

Arik Hadas has submitted this change and it was merged. Change subject: core: log reason for stopping vm only if set ...................................................................... core: log reason for stopping vm only if set Previously we always tried to include the stop reason when auditing VM stop operation. When no reason was set, either because it is not enabled in the cluster or the user simply did not enter a reason, the audit log included the following redundant message: (Reason: No reason was returned for this operation failure. See logs for further details.) This patch changes that so audit logs will include the stop reason only when it is set. That way, we avoid messages as shown above. Change-Id: I25b3ffced6036796d20bfcce0d47c22a3365a80d Bug-Url: https://bugzilla.redhat.com/1340414 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVmCommandBase.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 3 files changed, 13 insertions(+), 5 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/62821 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I25b3ffced6036796d20bfcce0d47c22a3365a80d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.4]: build: post ovirt-engine-4.0.4
by tnisan＠redhat.com 30 Aug '16

30 Aug '16

Tal Nisan has submitted this change and it was merged. Change subject: build: post ovirt-engine-4.0.4 ...................................................................... build: post ovirt-engine-4.0.4 Change-Id: Ic889fc296148e5d84b9b3fc6c19669f7680d0a41 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M automation/build-artifacts.sh M backend/manager/dependencies/common/pom.xml M backend/manager/dependencies/pom.xml M backend/manager/dependencies/tools/pom.xml M backend/manager/extensions-tool/pom.xml M backend/manager/modules/aaa/pom.xml M backend/manager/modules/auth-plugin/pom.xml M backend/manager/modules/bll/pom.xml M backend/manager/modules/branding/pom.xml M backend/manager/modules/builtin-extensions/pom.xml M backend/manager/modules/common/pom.xml M backend/manager/modules/compat/pom.xml M backend/manager/modules/dal/pom.xml M backend/manager/modules/docs/pom.xml M backend/manager/modules/enginesso/pom.xml M backend/manager/modules/extensions-api-root/extensions-api/pom.xml M backend/manager/modules/extensions-api-root/pom.xml M backend/manager/modules/extensions-manager/pom.xml M backend/manager/modules/logger/pom.xml M backend/manager/modules/pom.xml M backend/manager/modules/restapi/interface/common/jaxrs/pom.xml M backend/manager/modules/restapi/interface/common/pom.xml M backend/manager/modules/restapi/interface/definition/pom.xml M backend/manager/modules/restapi/interface/pom.xml M backend/manager/modules/restapi/jaxrs/pom.xml M backend/manager/modules/restapi/pom.xml M backend/manager/modules/restapi/types/pom.xml M backend/manager/modules/restapi/webapp/pom.xml M backend/manager/modules/root/pom.xml M backend/manager/modules/scheduler/pom.xml M backend/manager/modules/searchbackend/pom.xml M backend/manager/modules/services/pom.xml M backend/manager/modules/utils/pom.xml M backend/manager/modules/uutils/pom.xml M backend/manager/modules/vdsbroker/pom.xml M backend/manager/modules/welcome/pom.xml M backend/manager/pom.xml M backend/manager/tools/pom.xml M backend/pom.xml M build-tools-root/checkstyles/pom.xml M build-tools-root/ovirt-checkstyle-extension/pom.xml M build-tools-root/ovirt-findbugs-filters/pom.xml M build-tools-root/pom.xml M build/validations/pom.xml M ear/pom.xml M frontend/pom.xml M frontend/webadmin/modules/frontend-symbols/pom.xml M frontend/webadmin/modules/frontend/pom.xml M frontend/webadmin/modules/gwt-common/pom.xml M frontend/webadmin/modules/gwt-extension/pom.xml M frontend/webadmin/modules/pom.xml M frontend/webadmin/modules/uicommonweb/pom.xml M frontend/webadmin/modules/uicompat/pom.xml M frontend/webadmin/modules/userportal-gwtp/pom.xml M frontend/webadmin/modules/webadmin/pom.xml M frontend/webadmin/pom.xml M mavenmake/pom.xml M pom.xml M version.mak 59 files changed, 66 insertions(+), 63 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62994 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic889fc296148e5d84b9b3fc6c19669f7680d0a41 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.4 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-4.0.4]: build: ovirt-engine-4.0.4
by tnisan＠redhat.com 30 Aug '16

30 Aug '16

Tal Nisan has submitted this change and it was merged. Change subject: build: ovirt-engine-4.0.4 ...................................................................... build: ovirt-engine-4.0.4 Change-Id: If04759837c643793341b305d485f606a7973f416 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M automation/build-artifacts.sh M backend/manager/dependencies/common/pom.xml M backend/manager/dependencies/pom.xml M backend/manager/dependencies/tools/pom.xml M backend/manager/extensions-tool/pom.xml M backend/manager/modules/aaa/pom.xml M backend/manager/modules/auth-plugin/pom.xml M backend/manager/modules/bll/pom.xml M backend/manager/modules/branding/pom.xml M backend/manager/modules/builtin-extensions/pom.xml M backend/manager/modules/common/pom.xml M backend/manager/modules/compat/pom.xml M backend/manager/modules/dal/pom.xml M backend/manager/modules/docs/pom.xml M backend/manager/modules/enginesso/pom.xml M backend/manager/modules/extensions-api-root/extensions-api/pom.xml M backend/manager/modules/extensions-api-root/pom.xml M backend/manager/modules/extensions-manager/pom.xml M backend/manager/modules/logger/pom.xml M backend/manager/modules/pom.xml M backend/manager/modules/restapi/interface/common/jaxrs/pom.xml M backend/manager/modules/restapi/interface/common/pom.xml M backend/manager/modules/restapi/interface/definition/pom.xml M backend/manager/modules/restapi/interface/pom.xml M backend/manager/modules/restapi/jaxrs/pom.xml M backend/manager/modules/restapi/pom.xml M backend/manager/modules/restapi/types/pom.xml M backend/manager/modules/restapi/webapp/pom.xml M backend/manager/modules/root/pom.xml M backend/manager/modules/scheduler/pom.xml M backend/manager/modules/searchbackend/pom.xml M backend/manager/modules/services/pom.xml M backend/manager/modules/utils/pom.xml M backend/manager/modules/uutils/pom.xml M backend/manager/modules/vdsbroker/pom.xml M backend/manager/modules/welcome/pom.xml M backend/manager/pom.xml M backend/manager/tools/pom.xml M backend/pom.xml M build-tools-root/checkstyles/pom.xml M build-tools-root/ovirt-checkstyle-extension/pom.xml M build-tools-root/ovirt-findbugs-filters/pom.xml M build-tools-root/pom.xml M build/validations/pom.xml M ear/pom.xml M frontend/pom.xml M frontend/webadmin/modules/frontend-symbols/pom.xml M frontend/webadmin/modules/frontend/pom.xml M frontend/webadmin/modules/gwt-common/pom.xml M frontend/webadmin/modules/gwt-extension/pom.xml M frontend/webadmin/modules/pom.xml M frontend/webadmin/modules/uicommonweb/pom.xml M frontend/webadmin/modules/uicompat/pom.xml M frontend/webadmin/modules/userportal-gwtp/pom.xml M frontend/webadmin/modules/webadmin/pom.xml M frontend/webadmin/pom.xml M mavenmake/pom.xml M ovirt-engine.spec.in M pom.xml M version.mak 60 files changed, 95 insertions(+), 65 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62993 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If04759837c643793341b305d485f606a7973f416 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.4 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0