August 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-4.0]: webadmin: Allow UI plugins to run certain actions while loading
by oourfali＠redhat.com 01 Aug '16

01 Aug '16

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: Allow UI plugins to run certain actions while loading ...................................................................... webadmin: Allow UI plugins to run certain actions while loading UI plugin API performs requested actions only if the given plugin is either initializing (within UiInit callback) or in use (within other callbacks). This means all API actions are no-op while the plugin is loading, e.g. before the plugin calls the ready() function that triggers the UiInit callback. This limits the usability of plugin API, for example: var api = window.top.pluginApi('my-plugin'); api.register(objectWithCallbacks); // problem: cannot use e.g. `api.currentLocale` yet! api.ready(); // triggers UiInit callback execution This patch fixes the above issue by letting following API functions to be executed also while the plugin is loading (before api.ready): - loginUserName - loginUserId - ssoToken - engineBaseUrl - currentLocale Change-Id: I8996f4e7bb69696fb13a99068cf1a0c267b1481a Bug-Url: https://bugzilla.redhat.com/1361255 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/PluginManager.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/PluginState.java 2 files changed, 26 insertions(+), 18 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Vojtech Szocs: Verified -- To view, visit https://gerrit.ovirt.org/61778 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8996f4e7bb69696fb13a99068cf1a0c267b1481a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: spec: Require ovirt-imageio-proxy
by sbonazzo＠redhat.com 01 Aug '16

01 Aug '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: spec: Require ovirt-imageio-proxy ...................................................................... spec: Require ovirt-imageio-proxy For easy setup of ovirt-imageio-proxy, it should be required in ovirt's spec. otherwise, for uploading images in ovirt, the user will need to manual install ovirt-imageio-proxy. Change-Id: I1227bd8789fca98334b13afbb5d6d390d114da01 Bug-Url: https://bugzilla.redhat.com/1361845 Signed-off-by: Amit Aviram <aaviram(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Amit Aviram: Verified Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/61726 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1227bd8789fca98334b13afbb5d6d390d114da01 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Allow UI plugins to run certain actions while loading
by vszocs＠redhat.com 01 Aug '16

01 Aug '16

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin: Allow UI plugins to run certain actions while loading ...................................................................... webadmin: Allow UI plugins to run certain actions while loading UI plugin API performs requested actions only if the given plugin is either initializing (within UiInit callback) or in use (within other callbacks). This means all API actions are no-op while the plugin is loading, e.g. before the plugin calls the ready() function that triggers the UiInit callback. This limits the usability of plugin API, for example: var api = window.top.pluginApi('my-plugin'); api.register(objectWithCallbacks); // problem: cannot use e.g. `api.currentLocale` yet! api.ready(); // triggers UiInit callback execution This patch fixes the above issue by letting following API functions to be executed also while the plugin is loading (before api.ready): - loginUserName - loginUserId - ssoToken - engineBaseUrl - currentLocale Change-Id: I8996f4e7bb69696fb13a99068cf1a0c267b1481a Bug-Url: https://bugzilla.redhat.com/1361255 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/PluginManager.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/PluginState.java 2 files changed, 26 insertions(+), 16 deletions(-) Approvals: Jenkins CI: Passed CI tests Martin Betak: Looks good to me, but someone else must approve Greg Sheremeta: Looks good to me, approved Vojtech Szocs: Verified -- To view, visit https://gerrit.ovirt.org/61664 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8996f4e7bb69696fb13a99068cf1a0c267b1481a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: vdsm: remove el7 from check-merged jobs
by sbonazzo＠redhat.com 01 Aug '16

01 Aug '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: vdsm: remove el7 from check-merged jobs ...................................................................... vdsm: remove el7 from check-merged jobs el7 check-merged jobs are failing because currently there's only lago setup for fc24. A setup for el7 will be added in the future. Change-Id: I8a33f636abc9dc90aed081b310a2e554b5935498 Signed-off-by: Irit Goihman <igoihman(a)redhat.com> --- M jobs/confs/projects/vdsm/vdsm_standard.yaml 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/61766 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8a33f636abc9dc90aed081b310a2e554b5935498 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: ImportVmFromConfigurationCommand type inference
by amureini＠redhat.com 01 Aug '16

01 Aug '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: ImportVmFromConfigurationCommand type inference ...................................................................... core: ImportVmFromConfigurationCommand type inference Change-Id: I3de5a404f97e563090e0edd0afd03cabf770fe9d Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmFromConfigurationCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/61724 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3de5a404f97e563090e0edd0afd03cabf770fe9d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: ImportVmTemplateCommand local variables
by amureini＠redhat.com 01 Aug '16

01 Aug '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: ImportVmTemplateCommand local variables ...................................................................... core: ImportVmTemplateCommand local variables Remove redundant useless variables to improve the code's readability. Change-Id: I80540de17374ef4aaa8ea09982a337656f9bb381 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmTemplateCommand.java 1 file changed, 14 insertions(+), 16 deletions(-) Approvals: Allon Mureinik: Verified; Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/61746 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I80540de17374ef4aaa8ea09982a337656f9bb381 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: ImportVmTemplateCommand collections
by amureini＠redhat.com 01 Aug '16

01 Aug '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: ImportVmTemplateCommand collections ...................................................................... core: ImportVmTemplateCommand collections Use Collections#singletonList instead of Arrays#asList with a single argument to improve performance. Change-Id: I17d3fc2d6f1c30afad23f390d77b9ec809de38eb Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmTemplateCommand.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests Arik Hadas: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/61745 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I17d3fc2d6f1c30afad23f390d77b9ec809de38eb Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: ImportVmTemplateCommand type inference
by amureini＠redhat.com 01 Aug '16

01 Aug '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: ImportVmTemplateCommand type inference ...................................................................... core: ImportVmTemplateCommand type inference Change-Id: I770a5e732dfde45c8bfbe47ac3d099729ed1c04e Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmTemplateCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/61744 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I770a5e732dfde45c8bfbe47ac3d099729ed1c04e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: fix @AlternateMessage annotation in UiMessages
by vszocs＠redhat.com 01 Aug '16

01 Aug '16

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin: fix @AlternateMessage annotation in UiMessages ...................................................................... webadmin: fix @AlternateMessage annotation in UiMessages There are multiple issues because of @AlternateMessage annotation in UiMessages. Replacing all the annotations with EnumTranslator. Change-Id: I73aeb29d634bf2d56e1d5bfd046652c38f452f2b Bug-Url: https://bugzilla.redhat.com/1358837 Bug-Url: https://bugzilla.redhat.com/1269132 Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/GlusterVolumeGeoRepCreateModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIMessages.properties M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIMessages_de_DE.properties M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIMessages_es_ES.properties M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIMessages_fr_FR.properties M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIMessages_it_IT.properties M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIMessages_ja_JP.properties M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIMessages_ko_KR.properties M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIMessages_pt_BR.properties M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIMessages_zh_CN.properties M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/CreateBrickPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/GlusterVolumeSnapshotCreatePopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/renderer/RebalanceFileSizeRenderer.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/renderer/VolumeCapacityRenderer.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/GlusterCapacityCell.java 18 files changed, 105 insertions(+), 33 deletions(-) Approvals: Jenkins CI: Passed CI tests Vojtech Szocs: Looks good to me, approved Ramesh N: Verified -- To view, visit https://gerrit.ovirt.org/61749 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I73aeb29d634bf2d56e1d5bfd046652c38f452f2b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-java[sdk_4.0]: Add option to not revoke token when closing connection
by omachace＠redhat.com 01 Aug '16

01 Aug '16

Ondra Machacek has submitted this change and it was merged. Change subject: Add option to not revoke token when closing connection ...................................................................... Add option to not revoke token when closing connection This patch adds support to not revoke token when connection is closed, it could be handy when we want to reuse token. Change-Id: Ic3cbae4fc8c66b52875b0dc0eb2d55159b360854 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> (cherry picked from commit f55a0a7ee088d1389b93b4336f035f2955d62fa6) --- M sdk/src/main/java/org/ovirt/engine/sdk4/Connection.java M sdk/src/main/java/org/ovirt/engine/sdk4/internal/HttpConnection.java 2 files changed, 25 insertions(+), 1 deletion(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/61765 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic3cbae4fc8c66b52875b0dc0eb2d55159b360854 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: sdk_4.0 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0