September 2016 - Engine-commits - oVirt List Archives

Change in ovirt-hosted-engine-setup[master]: upgrade: add an info message about ssh keys
by stirabos＠redhat.com 15 Sep '16

15 Sep '16

Simone Tiraboschi has submitted this change and it was merged. Change subject: upgrade: add an info message about ssh keys ...................................................................... upgrade: add an info message about ssh keys The new appliance comes with new ssh keys; add a notice to inform the user. https://bugzilla.redhat.com/1343451 Change-Id: Idaf9b42c9f7b546211648d5948f2bd3198fd1d78 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/plugins/gr-he-common/core/misc.py 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Simone Tiraboschi: Verified; Looks good to me, approved Ido Rosenzwig: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/63975 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idaf9b42c9f7b546211648d5948f2bd3198fd1d78 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Graphics devices sorted for VM creation
by ahadas＠redhat.com 15 Sep '16

15 Sep '16

Arik Hadas has submitted this change and it was merged. Change subject: core: Graphics devices sorted for VM creation ...................................................................... core: Graphics devices sorted for VM creation We currently support two concurrent graphics protocols: SPICE+VNC. However qemu can have only one sound driver and thus only one protocol can get the sound. Libvirt sets audio driver (QEMU_AUDIO_DRV variable) according to the last graphics device in domain xml. Until now the order of graphics device have depended on database result ordering (i.e. has been random). This patch puts SPICE at the end so if SPICE+VNC is selected, SPICE always gets the sound. Change-Id: I93a8c597355e27235e528d1a9cb28d893a1f219f Bug-Url: https://bugzilla.redhat.com/1371243 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/collections/ComparatorUtils.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/VmInfoBuilderImpl.java 2 files changed, 62 insertions(+), 4 deletions(-) Approvals: Jakub Niedermertl: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/63093 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I93a8c597355e27235e528d1a9cb28d893a1f219f Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Imports of spice-html5 fixed
by mbetak＠redhat.com 14 Sep '16

14 Sep '16

Martin Betak has submitted this change and it was merged. Change subject: core: Imports of spice-html5 fixed ...................................................................... core: Imports of spice-html5 fixed Previously not all files of spice-html5 library were included (using <script> tag) and it seemed to work ok up to v0.1.6. In v0.1.7 it started to throw "ReferenceError: GAP_DETECTION_THRESHOLD is not defined". This patch imports all yet not imported *.js files from spice-html5 distribution and thus eliminating the error. Change-Id: Idadaeffd4c8ce97d4a54de97b65709e9f60cc145 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/services/src/main/webapp/spicehtml5-main.jsp 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Jakub Niedermertl: Verified Jenkins CI: Passed CI tests Martin Betak: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/63729 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idadaeffd4c8ce97d4a54de97b65709e9f60cc145 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Move usages of disk images filter from ImagesHandler t...
by tnisan＠redhat.com 14 Sep '16

14 Sep '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Move usages of disk images filter from ImagesHandler to DisksFilter ...................................................................... core: Move usages of disk images filter from ImagesHandler to DisksFilter Change-Id: I65ae3fcf539f9bc3ec42b11d7d42f5ca46212a9e Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndCloneImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateFromSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CloneVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAllVmTemplateImageTemplatesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ExportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/RemoveVmFromImportExportCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveDiskSnapshotsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RestoreAllSnapshotsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/TryBackToAllSnapshotsOfVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/RemoveDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/ImagesHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/RemoveAllVmImagesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/lsm/LiveMigrateVmDisksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ovfstore/OvfHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ovfstore/OvfUpdateProcessHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/image/ImagesHandlerTest.java 32 files changed, 178 insertions(+), 112 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Idan Shaby: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/62921 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I65ae3fcf539f9bc3ec42b11d7d42f5ca46212a9e Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Introducing DisksFilter.filterImageDisks
by tnisan＠redhat.com 14 Sep '16

14 Sep '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Introducing DisksFilter.filterImageDisks ...................................................................... core: Introducing DisksFilter.filterImageDisks Introducing the DisksFilter class which currently holds filterImageDisks with Java 8 predicates implemenations and comes to replace ImagesHandler::filterImageDisks The motivations behind that change: - Using filterImageDisks(disk, true, false, true) is barely readable, replacing it with filterImageDisks(disk. SNAPABLE_DISKS_ONLY) makes it way more clear what exactly are we filtering - Higher usability as those predicates can be used in other filtering methods instead of repeating an endless unreadable series of ifs - It's optional to add specific predicates to the filtering method by writing a Predicate function on the fly - Slight performance improvement as most of the usages in the code are filtering 1-2 conditions so we save redundant checks of the parameters Change-Id: I452385410fcefcc8a786235117608674ec933c50 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/DisksFilter.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/image/DisksFilterTest.java 2 files changed, 155 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Idan Shaby: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/62851 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I452385410fcefcc8a786235117608674ec933c50 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in otopi[master]: testing: Pass full path of coverage.rc
by didi＠redhat.com 14 Sep '16

14 Sep '16

Yedidyah Bar David has submitted this change and it was merged. Change subject: testing: Pass full path of coverage.rc ...................................................................... testing: Pass full path of coverage.rc Fails with python3 for some reason, not sure. Otopi does chdir('/') early, perhaps sometimes we are already there on start. Change-Id: I3da270aafa7ef1e9ad78d9fb85a151a2d9a0b052 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M automation/check-merged.sh M automation/check-patch.sh 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Yedidyah Bar David: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/63236 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3da270aafa7ef1e9ad78d9fb85a151a2d9a0b052 Gerrit-PatchSet: 2 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: extract devices hash from vm-dynamic
by ahadas＠redhat.com 14 Sep '16

14 Sep '16

Arik Hadas has submitted this change and it was merged. Change subject: core: extract devices hash from vm-dynamic ...................................................................... core: extract devices hash from vm-dynamic VmDynamic#hash was set with @UnchangeableByVdsm and it is wrong since the hash is reported (only) by VDSM. This is an indication that this was not the right place for this field. This patch moves VmDynamic#hash to VdsmVm. Change-Id: Ic3dac249a17b86ebceb42f1cef2f0329883b2e4b Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDynamic.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/EventVmStatsRefresher.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VdsmVm.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmStatsRefresher.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ListVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmStatsVdsBrokerCommand.java 8 files changed, 27 insertions(+), 34 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Shmuel Leib Melamud: Looks good to me, but someone else must approve Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/63495 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic3dac249a17b86ebceb42f1cef2f0329883b2e4b Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-live[ovirt-live-4.0]: build: oVirt Live 4.0.4 RC3
by lveyde＠redhat.com 14 Sep '16

14 Sep '16

Lev Veyde has submitted this change and it was merged. Change subject: build: oVirt Live 4.0.4 RC3 ...................................................................... build: oVirt Live 4.0.4 RC3 Change-Id: Ic545a2177445e05c33f898b17bf92c6712f93ec2 Signed-off-by: Lev Veyde <lveyde(a)redhat.com> --- M centos-7/Makefile 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Lev Veyde: Verified; Looks good to me, approved; Passed CI tests Sandro Bonazzola: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/63874 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic545a2177445e05c33f898b17bf92c6712f93ec2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-4.0 Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-2.0]: build: post ovirt-hosted-engine-setup-2.0.2.2
by stirabos＠redhat.com 14 Sep '16

14 Sep '16

Simone Tiraboschi has submitted this change and it was merged. Change subject: build: post ovirt-hosted-engine-setup-2.0.2.2 ...................................................................... build: post ovirt-hosted-engine-setup-2.0.2.2 Change-Id: I483b99d4aef5888c91300688779c204062355c9c Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M automation/build-artifacts.sh M configure.ac M ovirt-hosted-engine-setup.spec.in 3 files changed, 11 insertions(+), 5 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Simone Tiraboschi: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63793 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I483b99d4aef5888c91300688779c204062355c9c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-2.0 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-2.0]: build: ovirt-hosted-engine-setup-2.0.2.2
by stirabos＠redhat.com 14 Sep '16

14 Sep '16

Simone Tiraboschi has submitted this change and it was merged. Change subject: build: ovirt-hosted-engine-setup-2.0.2.2 ...................................................................... build: ovirt-hosted-engine-setup-2.0.2.2 Change-Id: I374ec7f2b0797d54e68faa0d95eb278754346014 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M automation/build-artifacts.sh M configure.ac M ovirt-hosted-engine-setup.spec.in 3 files changed, 11 insertions(+), 11 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Simone Tiraboschi: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63791 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I374ec7f2b0797d54e68faa0d95eb278754346014 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-2.0 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>

1 0