September 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine-sdk-ruby[master]: Change the probe to receive options instead of a connection
by juan.hernandez＠redhat.com 29 Sep '16

29 Sep '16

Juan Hernandez has submitted this change and it was merged. Change subject: Change the probe to receive options instead of a connection ...................................................................... Change the probe to receive options instead of a connection This is done for decoupling with connection implementation so that curb can be removed more easily. Change-Id: Id8ce552106811773f1d35ece4370baf62e43dc83 Signed-off-by: borod108 <bodnopoz(a)redhat.com> --- M sdk/lib/ovirtsdk4/http.rb M sdk/lib/ovirtsdk4/probe.rb M sdk/spec/probe_spec.rb M sdk/spec/spec_helper.rb 4 files changed, 174 insertions(+), 63 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/64924 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id8ce552106811773f1d35ece4370baf62e43dc83 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Boris Odnopozov <bodnopoz(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Make OvfUpdateProcessHelper a CDI component
by tnisan＠redhat.com 29 Sep '16

29 Sep '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Make OvfUpdateProcessHelper a CDI component ...................................................................... core: Make OvfUpdateProcessHelper a CDI component This patch makes OvfUpdateProcessHelper a CDI component thus enabling it to be injected, another benefit is removing VmDeviceUtils that is passing through the constructor Change-Id: I6818246e294a293c34ff5b957f71c0fad9cb6245 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ExportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ExportVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ovfstore/OvfUpdateProcessHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ovfstore/ProcessOvfUpdateForStoragePoolCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/ovfstore/ProcessOvfUpdateForStoragePoolCommandTest.java 5 files changed, 60 insertions(+), 70 deletions(-) Approvals: Tal Nisan: Verified; Passed CI tests Martin Betak: Looks good to me, but someone else must approve Allon Mureinik: Looks good to me, approved Freddy Rolland: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/64523 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6818246e294a293c34ff5b957f71c0fad9cb6245 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove VmDeviceUtils from DiskValidator constructor
by tnisan＠redhat.com 29 Sep '16

29 Sep '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Remove VmDeviceUtils from DiskValidator constructor ...................................................................... core: Remove VmDeviceUtils from DiskValidator constructor Patch 6fa804a1 moved VmDeviceUtils (VDU) to CDI, since VDU is used in DiskValidator as a part of the change VDU was passed to the validator in the constructor, this approach is wrong since a validator should not get in the ctor anything but the validated entity let alone various utils. This patch removes VDU from the ctor of DiskValidator and uses Injector::get to get an instance of VDU in the single method which uses it. Also a redundant usage of injectorRule.bind of VDU was removed. Change-Id: I77e3e8c409a8e488fd4e349995c4b4bd0c2091d3 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/AbstractDiskVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/AttachDiskToVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/MoveDisksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/MoveOrCopyDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/RemoveDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/CopyImageGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/lsm/LiveMigrateDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/lsm/LiveMigrateVmDisksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/repoimage/ExportRepoImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/DiskValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportExportRepoImageCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/AddDiskCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/HotPlugDiskToVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/repoimage/ImportRepoImageCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/storage/DiskValidatorTest.java 15 files changed, 16 insertions(+), 61 deletions(-) Approvals: Tal Nisan: Verified; Passed CI tests Martin Betak: Looks good to me, but someone else must approve Allon Mureinik: Looks good to me, approved Freddy Rolland: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/64462 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I77e3e8c409a8e488fd4e349995c4b4bd0c2091d3 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Extract VM disks related validation from DiskValidator
by tnisan＠redhat.com 29 Sep '16

29 Sep '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Extract VM disks related validation from DiskValidator ...................................................................... core: Extract VM disks related validation from DiskValidator Change-Id: I68d462e795ce8c9c89560991e175fcc07d15243e Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/AbstractDiskVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/AddDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/AttachDiskToVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/HotPlugDiskToVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/UpdateVmDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/DiskValidator.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/DiskVmElementValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/AddDiskCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/AttachDiskToVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/HotPlugDiskToVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/UpdateVmDiskCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/storage/DiskValidatorTest.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/storage/DiskVmElementValidatorTest.java 13 files changed, 318 insertions(+), 229 deletions(-) Approvals: Tal Nisan: Verified; Passed CI tests Allon Mureinik: Looks good to me, approved Freddy Rolland: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/64500 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I68d462e795ce8c9c89560991e175fcc07d15243e Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: webadmin: Edit error message in DC operation failure dialog
by tnisan＠redhat.com 29 Sep '16

29 Sep '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Edit error message in DC operation failure dialog ...................................................................... webadmin: Edit error message in DC operation failure dialog This patch makes the following changes to the error dialogue generated when a user attempts to upgrade the compatibility level of a data center to a level greater than that of any of its clusters: 1. Changes "Clusters" to "clusters" 2. Adds a colon between the error message and the list of problematic clusters Change-Id: If4f074f6030bc68042137fb33e5de1e8be8e4c3d Bug-Url: https://bugzilla.redhat.com/1287540 Signed-off-by: Phillip Bailey <phbailey(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 4 files changed, 4 insertions(+), 4 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Phillip Bailey: Verified Andrej Krejcir: Looks good to me, but someone else must approve Yanir Quinn: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/64259 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If4f074f6030bc68042137fb33e5de1e8be8e4c3d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in gerrit-admin[master]: Recreate check_product hook
by eedri＠redhat.com 29 Sep '16

29 Sep '16

Eyal Edri has submitted this change and it was merged. Change subject: Recreate check_product hook ...................................................................... Recreate check_product hook - The new hook is replacing the old patchset-created.bz.2.correct_product hook and it based on the bz.py module. - It checks only u/s bugs (oVirt classification) - It checks that the current patch project is the same as the bug product. Example: classification: oVirt patch Project: ovirt-engine bug Product: ovirt-engine - All the previous links are pointing to the new hook. Fixes: OVIRT-533 Signed-off-by: Shlomi Ben-David <sbendavi(a)redhat.com> Change-Id: Ie65f55ec432d6c5b4f00627b64a7336ae9d9d337 --- A hooks/custom_hooks/check_product 1 file changed, 336 insertions(+), 0 deletions(-) Approvals: Shlomo Ben David: Verified Eyal Edri: Looks good to me, approved Gil Shinar: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/64254 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie65f55ec432d6c5b4f00627b64a7336ae9d9d337 Gerrit-PatchSet: 6 Gerrit-Project: gerrit-admin Gerrit-Branch: master Gerrit-Owner: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in gerrit-admin[master]: Fix update_tracker hook
by eedri＠redhat.com 29 Sep '16

29 Sep '16

Eyal Edri has submitted this change and it was merged. Change subject: Fix update_tracker hook ...................................................................... Fix update_tracker hook - Update the get_bug_ids function to run as part of the Bugzilla class - Update the update_external function in bz.py module to include branch (ext_priority) in the external bug tracker. Change-Id: I629d6dca2b22e71811aff92a2d5fe39928918d08 Signed-off-by: Shlomi Ben-David <sbendavi(a)redhat.com> --- M hooks/custom_hooks/update_tracker M hooks/lib/bz.py 2 files changed, 41 insertions(+), 20 deletions(-) Approvals: Shlomo Ben David: Verified; Passed CI tests Eyal Edri: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/64930 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I629d6dca2b22e71811aff92a2d5fe39928918d08 Gerrit-PatchSet: 3 Gerrit-Project: gerrit-admin Gerrit-Branch: master Gerrit-Owner: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: GetGlusterServerForImportQueryTest ExpectedException
by amureini＠redhat.com 29 Sep '16

29 Sep '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: GetGlusterServerForImportQueryTest ExpectedException ...................................................................... core: GetGlusterServerForImportQueryTest ExpectedException Use the ExpectedException @Rule instead of having to boiler-plate implement the same logic in the class in each method. Change-Id: Idf669a6e7a6ca28470301e7ffc52cede6bdde597 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GetGlusterServersForImportQueryTest.java 1 file changed, 11 insertions(+), 22 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/64605 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idf669a6e7a6ca28470301e7ffc52cede6bdde597 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: GeoRepSessionCommandTest default ctor
by amureini＠redhat.com 29 Sep '16

29 Sep '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: GeoRepSessionCommandTest default ctor ...................................................................... core: GeoRepSessionCommandTest default ctor Remove the useless default constructor. Java will implicitly generate it for you. Change-Id: Ib747e0dfe140cf064fd996cfd929944e27eedcf9 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GeoRepSessionCommandTest.java 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/64604 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib747e0dfe140cf064fd996cfd929944e27eedcf9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: CreateGlusterVolumeCommandTest constants
by amureini＠redhat.com 29 Sep '16

29 Sep '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: CreateGlusterVolumeCommandTest constants ...................................................................... core: CreateGlusterVolumeCommandTest constants Make constants private static final as per Java's best practices. Change-Id: Ib8a414e63a04cb18ae7a3de7f5ce952461b3b333 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeCommandTest.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/64603 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib8a414e63a04cb18ae7a3de7f5ce952461b3b333 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0