September 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-4.0.4]: core: do not pass Collections.singleton
by tnisan＠redhat.com 07 Sep '16

07 Sep '16

Tal Nisan has submitted this change and it was merged. Change subject: core: do not pass Collections.singleton ...................................................................... core: do not pass Collections.singleton probably command coordination serializes parameters to db. When deserializing them (exact behavior is to be tested) Collections.singleton cannot be deserialized due to missing default constructor. Change-Id: Icf2a08e713fac43a531297dc4eeb285a9205045d Bug-Url: https://bugzilla.redhat.com/1372950 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/AttachNetworkToClusterCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/DetachNetworkToClusterCommand.java 2 files changed, 4 insertions(+), 2 deletions(-) Approvals: Martin Mucha: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/63316 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icf2a08e713fac43a531297dc4eeb285a9205045d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.4 Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: do not pass Collections.singleton
by tnisan＠redhat.com 07 Sep '16

07 Sep '16

Tal Nisan has submitted this change and it was merged. Change subject: core: do not pass Collections.singleton ...................................................................... core: do not pass Collections.singleton probably command coordination serializes parameters to db. When deserializing them (exact behavior is to be tested) Collections.singleton cannot be deserialized due to missing default constructor. Change-Id: Icf2a08e713fac43a531297dc4eeb285a9205045d Bug-Url: https://bugzilla.redhat.com/1372950 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/AttachNetworkToClusterCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/DetachNetworkToClusterCommand.java 2 files changed, 4 insertions(+), 2 deletions(-) Approvals: Martin Mucha: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/63315 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icf2a08e713fac43a531297dc4eeb285a9205045d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: Set the Custom CV at old snapshot preview
by tnisan＠redhat.com 07 Sep '16

07 Sep '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Set the Custom CV at old snapshot preview ...................................................................... core: Set the Custom CV at old snapshot preview VM's custom compatibility version is set when previewing snapshot with memory taken in previous cluster version. The UpdateVmCommand from TryBackToAllSnapshotsOfVmCommand is called to set the CCV. The CCV keeps to be set after the preview commit but is rolled back when undo the preview. Change-Id: Ic181e144fa41cf77afe00feda58709f725eb2831 Bug-Url: https://bugzilla.redhat.com/1364456 Signed-off-by: Marek Libra <mlibra(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/TryBackToAllSnapshotsOfVmCommand.java 2 files changed, 39 insertions(+), 3 deletions(-) Approvals: Jenkins CI: Passed CI tests Marek Libra: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/63465 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic181e144fa41cf77afe00feda58709f725eb2831 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.4]: packaging: setup: Move hosted-engine check plugin to engine
by tnisan＠redhat.com 07 Sep '16

07 Sep '16

Tal Nisan has submitted this change and it was merged. Change subject: packaging: setup: Move hosted-engine check plugin to engine ...................................................................... packaging: setup: Move hosted-engine check plugin to engine Change-Id: Ic6219f3240b7097b8589659fb5748863c81ff981 Bug-Url: https://bugzilla.redhat.com/1372230 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> (cherry picked from commit 4557e0669b8ce3f17bd88c5946d01a585a28c764) --- M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-common/system/__init__.py A packaging/setup/plugins/ovirt-engine-common/ovirt-engine/system/__init__.py R packaging/setup/plugins/ovirt-engine-common/ovirt-engine/system/he.py 3 files changed, 33 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/63453 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic6219f3240b7097b8589659fb5748863c81ff981 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.4 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-4.0.4]: packaging: engine-backup: Exclude reports files on restore
by tnisan＠redhat.com 07 Sep '16

07 Sep '16

Tal Nisan has submitted this change and it was merged. Change subject: packaging: engine-backup: Exclude reports files on restore ...................................................................... packaging: engine-backup: Exclude reports files on restore Change-Id: Ibb275ff46d94945f255aa440ae182a8e16a7ce73 Bug-Url: https://bugzilla.redhat.com/1340810 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> (cherry picked from commit a5d60b2f8830252968ba5446f386923b54ee1d98) --- M packaging/bin/engine-backup.sh.in 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/63452 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibb275ff46d94945f255aa440ae182a8e16a7ce73 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.4 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: packaging: setup: Move hosted-engine check plugin to engine
by tnisan＠redhat.com 07 Sep '16

07 Sep '16

Tal Nisan has submitted this change and it was merged. Change subject: packaging: setup: Move hosted-engine check plugin to engine ...................................................................... packaging: setup: Move hosted-engine check plugin to engine Change-Id: Ic6219f3240b7097b8589659fb5748863c81ff981 Bug-Url: https://bugzilla.redhat.com/1372230 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> (cherry picked from commit 4557e0669b8ce3f17bd88c5946d01a585a28c764) --- M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-common/system/__init__.py A packaging/setup/plugins/ovirt-engine-common/ovirt-engine/system/__init__.py R packaging/setup/plugins/ovirt-engine-common/ovirt-engine/system/he.py 3 files changed, 33 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Passed CI tests Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/63451 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic6219f3240b7097b8589659fb5748863c81ff981 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: packaging: engine-backup: Exclude reports files on restore
by piotr.kliczewski＠gmail.com 07 Sep '16

07 Sep '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: packaging: engine-backup: Exclude reports files on restore ...................................................................... packaging: engine-backup: Exclude reports files on restore Change-Id: Ibb275ff46d94945f255aa440ae182a8e16a7ce73 Bug-Url: https://bugzilla.redhat.com/1340810 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> (cherry picked from commit a5d60b2f8830252968ba5446f386923b54ee1d98) --- M packaging/bin/engine-backup.sh.in 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/63450 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibb275ff46d94945f255aa440ae182a8e16a7ce73 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-2.0]: Add rng device to bootsrap vm.conf
by stirabos＠redhat.com 07 Sep '16

07 Sep '16

Simone Tiraboschi has submitted this change and it was merged. Change subject: Add rng device to bootsrap vm.conf ...................................................................... Add rng device to bootsrap vm.conf Bootstrap the engine VM with rng device. To complete the change, the converter from ovf to vm.conf should always stub it too. Related: https://gerrit.ovirt.org/#/c/62334 Change-Id: Id70fba0798432d7c0ca6a5d1eb6d05053465ffbe Signed-off-by: Roy Golan <rgolan(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1357246 (cherry picked from commit 623f0b587e5957210d83daa9a3d91b05670307d6) --- M templates/vm.conf.in 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Simone Tiraboschi: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, but someone else must approve Roy Golan: Verified -- To view, visit https://gerrit.ovirt.org/63467 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id70fba0798432d7c0ca6a5d1eb6d05053465ffbe Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-2.0 Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: do not pass Collections.singleton
by masayag＠redhat.com 07 Sep '16

07 Sep '16

Moti Asayag has submitted this change and it was merged. Change subject: core: do not pass Collections.singleton ...................................................................... core: do not pass Collections.singleton probably command coordination serializes parameters to db. When deserializing them (exact behavior is to be tested) Collections.singleton cannot be deserialized due to missing default constructor. Change-Id: Icf2a08e713fac43a531297dc4eeb285a9205045d Bug-Url: https://bugzilla.redhat.com/1372950 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/AttachNetworkToClusterCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/DetachNetworkToClusterCommand.java 2 files changed, 4 insertions(+), 2 deletions(-) Approvals: Martin Mucha: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/63317 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icf2a08e713fac43a531297dc4eeb285a9205045d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: align db scripts to support upgrade
by tnisan＠redhat.com 07 Sep '16

07 Sep '16

Tal Nisan has submitted this change and it was merged. Change subject: core: align db scripts to support upgrade ...................................................................... core: align db scripts to support upgrade DB upgrade scripts content were amended to match their name. Duplicate db script for change disk status to OK was added in order to be activated when upgrading from minor versions 4.0.3 and below. Change-Id: I369c81d4e72945bd7189e1e93523c6810a2f4e29 Bug-Url: https://bugzilla.redhat.com/1339660 Signed-off-by: Yanir Quinn <yquinn(a)redhat.com> --- M packaging/dbscripts/upgrade/04_00_0790_change_vm_device_null_plugged_values_to_false.sql M packaging/dbscripts/upgrade/04_00_0800_remove_hosted_engine_storage_domain_name_config_value.sql M packaging/dbscripts/upgrade/04_00_0810_change_disk_status_to_ok.sql A packaging/dbscripts/upgrade/04_00_0890_change_disk_status_to_ok_amended.sql 4 files changed, 29 insertions(+), 17 deletions(-) Approvals: Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved Yanir Quinn: Verified -- To view, visit https://gerrit.ovirt.org/63289 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I369c81d4e72945bd7189e1e93523c6810a2f4e29 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>

1 0