September 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine-sdk-java[master]: Fix tag names of action parameters
by omachace＠redhat.com 05 Sep '16

05 Sep '16

Ondra Machacek has submitted this change and it was merged. Change subject: Fix tag names of action parameters ...................................................................... Fix tag names of action parameters Currently when the SDK generates the XML document to invoke an action method it assumes that the names of the elements inside the 'action' match the names of the types of the parameters. This isn't correct, they should match the names of the parameters, not the names of the types. For example, the 'Host.iscsi_discover' action method has a parameter of type 'IscsiDetails' and name 'iscsi', so the tag should be 'iscsi', not 'iscsi_details'. To solve this issue this patch chages the SDK so that the implementation of action methods create an instance of the 'Action' type, and render it uusing the 'ActionWriter' class, which knows how to write it correctly. Change-Id: I25494bc638e3dc1098b1086bad94901ca03a72c9 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M generator/src/main/java/org/ovirt/sdk/java/ServicesImplGenerator.java 1 file changed, 9 insertions(+), 34 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63320 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I25494bc638e3dc1098b1086bad94901ca03a72c9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Added scheduling properties to cluster
by juan.hernandez＠redhat.com 05 Sep '16

05 Sep '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Added scheduling properties to cluster ...................................................................... restapi: Added scheduling properties to cluster Custom scheduling policy properties added to cluster in order to support update/add/get operations of these properties and store them correctly at the back end. See examples below: GET /clusters/{cluster:id} : <cluster> <custom_scheduling_policy_properties/> <property> <name>{name}</name> <value>{value}</value> </property> ... <custom_scheduling_policy_properties/> </cluster> PUT /clusters/{cluster:id} <cluster> <custom_scheduling_policy_properties/> <property> <name>{name}</name> <value>{value}</value> </property> ... </custom_scheduling_policy_properties> </cluster> Change-Id: Ib1f3fad300e9fc79690b15159ca780ba7f97449a Bug-Url: https://bugzilla.redhat.com/1351576 Signed-off-by: yquinn <yquinn(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/ClusterMapper.java 1 file changed, 21 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Jenkins CI: Passed CI tests Yanir Quinn: Verified -- To view, visit https://gerrit.ovirt.org/62845 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib1f3fad300e9fc79690b15159ca780ba7f97449a Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: scheduling: Make sure there is exactly one default cluster p...
by rgolan＠redhat.com 05 Sep '16

05 Sep '16

Roy Golan has submitted this change and it was merged. Change subject: scheduling: Make sure there is exactly one default cluster policy ...................................................................... scheduling: Make sure there is exactly one default cluster policy Signed-off-by: Martin Sivak <msivak(a)redhat.com> Change-Id: I04e3c1b96124df1f939f9ea35b37637ee00506b3 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ClusterOperationCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/InternalClusterPoliciesTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/SchedulingManagerTest.java 4 files changed, 22 insertions(+), 7 deletions(-) Approvals: Martin Sivák: Verified Roman Mohr: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/59481 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I04e3c1b96124df1f939f9ea35b37637ee00506b3 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: scheduling: Use @NotNull in the filtering code
by rgolan＠redhat.com 05 Sep '16

05 Sep '16

Roy Golan has submitted this change and it was merged. Change subject: scheduling: Use @NotNull in the filtering code ...................................................................... scheduling: Use @NotNull in the filtering code Change-Id: I51293b5a36cb25f0fbf30bfddd7b3661c70f0746 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerBroker.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerBrokerImpl.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerBrokerObjectBuilder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerDiscovery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/FilteringResult.java 6 files changed, 84 insertions(+), 93 deletions(-) Approvals: Martin Sivák: Verified Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved Andrej Krejcir: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/59480 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I51293b5a36cb25f0fbf30bfddd7b3661c70f0746 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: scheduling: Handle policy unit instantiation errors at a bet...
by rgolan＠redhat.com 05 Sep '16

05 Sep '16

Roy Golan has submitted this change and it was merged. Change subject: scheduling: Handle policy unit instantiation errors at a better place ...................................................................... scheduling: Handle policy unit instantiation errors at a better place Change-Id: Ie8299b37f048d8ba8c16e9f843a6660776b06455 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/InternalPolicyUnits.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/InternalPolicyUnitsTest.java 3 files changed, 27 insertions(+), 31 deletions(-) Approvals: Martin Sivák: Verified Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/59482 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie8299b37f048d8ba8c16e9f843a6660776b06455 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: scheduling: Java 8 cleanup in PolicyUnitImpl
by rgolan＠redhat.com 05 Sep '16

05 Sep '16

Roy Golan has submitted this change and it was merged. Change subject: scheduling: Java 8 cleanup in PolicyUnitImpl ...................................................................... scheduling: Java 8 cleanup in PolicyUnitImpl Change-Id: Ia025a7b5415625b9008a11f3691c81ec06fd5816 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/PolicyUnitImpl.java 1 file changed, 3 insertions(+), 5 deletions(-) Approvals: Martin Sivák: Verified Roman Mohr: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/59402 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia025a7b5415625b9008a11f3691c81ec06fd5816 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: scheduling: Use Optional instead of nulls for balancer results
by rgolan＠redhat.com 05 Sep '16

05 Sep '16

Roy Golan has submitted this change and it was merged. Change subject: scheduling: Use Optional instead of nulls for balancer results ...................................................................... scheduling: Use Optional instead of nulls for balancer results This patch converts most of the balancing return values from nullable Pair<...> to Optional<BalancingResult> with the goal of achieving better type safety. Change-Id: Id0f54389a72aad870b61d4b9f58ccac1efdda488 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/PolicyUnitImpl.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/BalanceResult.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerBroker.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerBrokerImpl.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerBrokerObjectBuilder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerDiscovery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/CpuAndMemoryBalancingPolicyUnit.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/HaReservationBalancePolicyUnit.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/NoneBalancePolicyUnit.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/PowerSavingBalancePolicyUnit.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/policyunits/EvenDistributionBalancePolicyUnitTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/policyunits/PowerSavingBalancePolicyUnitTest.java 13 files changed, 135 insertions(+), 101 deletions(-) Approvals: Martin Sivák: Verified Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved Jenny Tokar: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/59401 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id0f54389a72aad870b61d4b9f58ccac1efdda488 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: frontend: Fix NPE in ImportVmFromExternalSourceModel
by mbetak＠redhat.com 05 Sep '16

05 Sep '16

Martin Betak has submitted this change and it was merged. Change subject: frontend: Fix NPE in ImportVmFromExternalSourceModel ...................................................................... frontend: Fix NPE in ImportVmFromExternalSourceModel Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1373103 Change-Id: If400d25ac485d2ab94d670543773c41ff41c7f26 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmFromExternalSourceModel.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Passed CI tests Martin Betak: Verified -- To view, visit https://gerrit.ovirt.org/63307 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If400d25ac485d2ab94d670543773c41ff41c7f26 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-java[sdk_4.0]: Don't return null from send method in case of failure
by omachace＠redhat.com 05 Sep '16

05 Sep '16

Ondra Machacek has submitted this change and it was merged. Change subject: Don't return null from send method in case of failure ...................................................................... Don't return null from send method in case of failure In case API returns that request is incorrect, don't return null from send method, so user's code don't fail on NullPointerExceptions. Instead return Reponse implementation and set the apporiate object to null. Change-Id: I8d564ee8636cbba5ae4ce7b8b7b558c86dec2fbe Signed-off-by: Ondra Machacek <omachace(a)redhat.com> (cherry picked from commit 9a35453e842b1c21f33d6b916804103f920f241c) --- M generator/src/main/java/org/ovirt/sdk/java/ServicesImplGenerator.java 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63306 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8d564ee8636cbba5ae4ce7b8b7b558c86dec2fbe Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: sdk_4.0 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-java[master]: Don't return null from send method in case of failure
by omachace＠redhat.com 05 Sep '16

05 Sep '16

Ondra Machacek has submitted this change and it was merged. Change subject: Don't return null from send method in case of failure ...................................................................... Don't return null from send method in case of failure In case API returns that request is incorrect, don't return null from send method, so user's code don't fail on NullPointerExceptions. Instead return Reponse implementation and set the apporiate object to null. Change-Id: I8d564ee8636cbba5ae4ce7b8b7b558c86dec2fbe Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M generator/src/main/java/org/ovirt/sdk/java/ServicesImplGenerator.java 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63304 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8d564ee8636cbba5ae4ce7b8b7b558c86dec2fbe Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0