September 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: CommandBase - CommandStep/FINALIZING step
by laravot＠redhat.com 05 Sep '16

05 Sep '16

Liron Aravot has submitted this change and it was merged. Change subject: core: CommandBase - CommandStep/FINALIZING step ...................................................................... core: CommandBase - CommandStep/FINALIZING step This patch prevents adding a finalizing step to steps added by overriding getCommandStep(). The finalizing step is currently used for steps and not for jobs only in very specific cases in which also validation and execution steps are added to a step/sub step. When command is adding a step by overriding getCommandStep() its intended to add a "simple" step as replacement to the async tasks added steps when jobs are used instead of tasks therefore there's no need to add a finalizing step when the step was added by getCommandStep(). Change-Id: I9c6d7a5aebfbfa176fca5e8d90b6127ee7cc7a5f Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Moti Asayag: Looks good to me, approved Liron Aravot: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/63272 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9c6d7a5aebfbfa176fca5e8d90b6127ee7cc7a5f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: storage: Log exception instead of printStackTrace
by rgolan＠redhat.com 05 Sep '16

05 Sep '16

Roy Golan has submitted this change and it was merged. Change subject: core: storage: Log exception instead of printStackTrace ...................................................................... core: storage: Log exception instead of printStackTrace Change-Id: I51805c744da90dca6fcbc43e0a44dda3ccce0c76 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/RemoveAllVmCinderDisksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/RestoreAllCinderSnapshotsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/RestoreFromCinderSnapshotCommand.java 3 files changed, 5 insertions(+), 8 deletions(-) Approvals: Roman Mohr: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Roy Golan: Verified -- To view, visit https://gerrit.ovirt.org/60313 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I51805c744da90dca6fcbc43e0a44dda3ccce0c76 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: backend: cleanup: Fix static member accessed via instance wa...
by mbetak＠redhat.com 05 Sep '16

05 Sep '16

Martin Betak has submitted this change and it was merged. Change subject: backend: cleanup: Fix static member accessed via instance warning ...................................................................... backend: cleanup: Fix static member accessed via instance warning Fixed IDE warning caused by accessing static method via instance of ExecutionHandler. Change-Id: Ib7df9de96fdf10216300c7e544b3ba6cd49c0ac7 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Martin Betak: Verified Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/63153 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib7df9de96fdf10216300c7e544b3ba6cd49c0ac7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: mock_runner.sh: Fix yum.conf location
by eedri＠redhat.com 05 Sep '16

05 Sep '16

Eyal Edri has submitted this change and it was merged. Change subject: mock_runner.sh: Fix yum.conf location ...................................................................... mock_runner.sh: Fix yum.conf location Change-Id: I44b01cb32350d0bc2fbf9ececcdf700186f7921c Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M mock_configs/mock_runner.sh 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Eyal Edri: Looks good to me; Passed CI tests; Ready for merge Barak Korren: Looks good to me; Ready for review Yedidyah Bar David: Verified Evgheni Dereveanchin: Looks good to me -- To view, visit https://gerrit.ovirt.org/63249 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I44b01cb32350d0bc2fbf9ececcdf700186f7921c Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Fix virtual size after live merge
by laravot＠redhat.com 04 Sep '16

04 Sep '16

Liron Aravot has submitted this change and it was merged. Change subject: core: Fix virtual size after live merge ...................................................................... core: Fix virtual size after live merge In commit ed2a249c (core: Move logic from RemoveSnapshotSingleDiskLiveCommand), we refactored live merge logic. In that refactor, setting image size after live merge was mistakenly dropped hence, actual size wasn't calculated correctly, mainly if the disk was extended before live merge. This patch fixes that issue by sitting that image size again. Change-Id: Ib7d40270f1330408628d6a551ad24d5f1a4bce61 Signed-off-by: Ala Hino <ahino(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveSnapshotSingleDiskCommandBase.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve Ala Hino: Verified Liron Aravot: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/63271 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib7d40270f1330408628d6a551ad24d5f1a4bce61 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.4]: webadmin: Allow edit of storage domain description, comment ...
by tnisan＠redhat.com 04 Sep '16

04 Sep '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Allow edit of storage domain description, comment and WAD ...................................................................... webadmin: Allow edit of storage domain description, comment and WAD Since changing of a storage domain's description, comment and wipe after delete are database updates only and do not require any VDSM operation they should be allowed to run on all scenarios. As a result there's also no need to have the "Close" button in case no field is editable as there will always be editable fields Change-Id: I6b66054b733a9591fd6588006739a0f05b4525bd Bug-Url: https://bugzilla.redhat.com/1372650 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java 1 file changed, 6 insertions(+), 21 deletions(-) Approvals: Tal Nisan: Verified Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/63264 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6b66054b733a9591fd6588006739a0f05b4525bd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.4 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: webadmin: Allow edit of storage domain description, comment ...
by tnisan＠redhat.com 04 Sep '16

04 Sep '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Allow edit of storage domain description, comment and WAD ...................................................................... webadmin: Allow edit of storage domain description, comment and WAD Since changing of a storage domain's description, comment and wipe after delete are database updates only and do not require any VDSM operation they should be allowed to run on all scenarios. As a result there's also no need to have the "Close" button in case no field is editable as there will always be editable fields Change-Id: I6b66054b733a9591fd6588006739a0f05b4525bd Bug-Url: https://bugzilla.redhat.com/1372650 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java 1 file changed, 6 insertions(+), 21 deletions(-) Approvals: Tal Nisan: Verified Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/63263 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6b66054b733a9591fd6588006739a0f05b4525bd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Allow edit of storage domain description, comment ...
by tnisan＠redhat.com 04 Sep '16

04 Sep '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Allow edit of storage domain description, comment and WAD ...................................................................... webadmin: Allow edit of storage domain description, comment and WAD Since changing of a storage domain's description, comment and wipe after delete are database updates only and do not require any VDSM operation they should be allowed to run on all scenarios. As a result there's also no need to have the "Close" button in case no field is editable as there will always be editable fields Change-Id: I6b66054b733a9591fd6588006739a0f05b4525bd Bug-Url: https://bugzilla.redhat.com/1372650 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java 1 file changed, 6 insertions(+), 21 deletions(-) Approvals: Tal Nisan: Verified; Passed CI tests Daniel Erez: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/63250 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6b66054b733a9591fd6588006739a0f05b4525bd Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.9]: core: Always fix VMs status during fencing if host if off
by tnisan＠redhat.com 04 Sep '16

04 Sep '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Always fix VMs status during fencing if host if off ...................................................................... core: Always fix VMs status during fencing if host if off Always fix VMs status during fencing flow when host is off (detected by power management status command) and don't rely on successful execution of power management start of the host. Change-Id: I439d5a323092978a6cd58ceef93aa7f340e6dcf6 Bug-Url: https://bugzilla.redhat.com/1372812 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/RestartVdsCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Oved Ourfali: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/63247 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I439d5a323092978a6cd58ceef93aa7f340e6dcf6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.9 Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: missed increasing ovirt-engine build-artifacts history
by eedri＠redhat.com 04 Sep '16

04 Sep '16

Eyal Edri has submitted this change and it was merged. Change subject: missed increasing ovirt-engine build-artifacts history ...................................................................... missed increasing ovirt-engine build-artifacts history Aligning ovirt-engine build-artifacts build-history to 120, same as all other projects. Artifacts history will be raised to 20 from 10. Change-Id: I6874ebf171658406281aee78d42abbc404bc65cb Signed-off-by: Eyal Edri <eedri(a)redhat.com> --- M jobs/confs/yaml/templates/standard-stage.yaml 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Eyal Edri: Verified; Looks good to me; Passed CI tests; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63251 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6874ebf171658406281aee78d42abbc404bc65cb Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0