January 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Fix of NPE in storage domain validation
by Code Review 27 Jan '17

27 Jan '17

>From Tomas Jelinek <tjelinek(a)redhat.com>: Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: Fix of NPE in storage domain validation ...................................................................... webadmin: Fix of NPE in storage domain validation Method UnitVmModel#createEachDiskAHasStorageDomainValidation() could throw NPE if UnitVmModel#getDisksAllocationModel().getDisks() returns null. Change-Id: I7865419dcda5b94a28139ffff1e70cf0f2acd9cd Bug-Url: https://bugzilla.redhat.com/1406572 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/71284 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7865419dcda5b94a28139ffff1e70cf0f2acd9cd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: packaging: update hosts metrics:added auto_typecast
by Code Review 26 Jan '17

26 Jan '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: packaging: update hosts metrics:added auto_typecast ...................................................................... packaging: update hosts metrics:added auto_typecast Change-Id: I9c40c287a776c7ef60af0bdcc7b9201b72ba8543 Bug-Url: https://bugzilla.redhat.com/1415639 Signed-off-by: Shirly Radco <sradco(a)redhat.com> (cherry picked from commit 0e4f0ca91db34f794a54a2ed54f5047d2b01d4d6) --- M packaging/setup/ansible/roles/ovirt_fluentd/ovirt_host/templates/ovirt-processing.conf 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Shirly Radco: Verified Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/71228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9c40c287a776c7ef60af0bdcc7b9201b72ba8543 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi + engine : handle scenarios for graphicsconsoles APIs
by Code Review 26 Jan '17

26 Jan '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: restapi + engine : handle scenarios for graphicsconsoles APIs ...................................................................... restapi + engine : handle scenarios for graphicsconsoles APIs When using /graphicsconsoles REST apis for deleting or adding a graphic device to an existing VM, there are cases that the VM is left after the operation with no graphic devices (all was removed) but with a video device OR lest with one graphic devide (which was added to a headless VM) and no video device. This patch handle all those senrois for the /graphicsconsoles APIS (GET, POST, DELETE) such that in case the last graphic device was removed-the video device also removed and the entity becomes headless. and also in case the first graphic device is added to a headless entity, a "QXL" video device is also added. Those changes are relevant for VMs, Templates and Instance-types: e.g. for adding a graphic device: POST ..api/instancetypes/<instancetype-id>/graphicsconsoles <graphics_console> <protocol>spice</protocol> </graphics_console> POST ..api/templates/<template-id>/graphicsconsoles ... POST ..api/vms/<vm-id>/graphicsconsoles ... For removing a graphic device: DELETE ..api/instancetypes/<instancetype-id>/graphicsconsoles/<console-id> DELETE ..api/templates/<template-id>/graphicsconsoles/<console-id> DELETE ..api/vms/<vm-id>/graphicsconsoles/<console-id> Change-Id: I15d94b31d91d51b0319af9100fcb45f1e1984ad8 Bug-Url: https://bugzilla.redhat.com/1414086 Signed-off-by: Sharon Gratch <sgratch(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractGraphicsDeviceCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddGraphicsAndVideoDevicesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddGraphicsDeviceCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveGraphicsAndVideoDevicesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendGraphicsConsoleHelper.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendInstanceTypeGraphicsConsolesResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateGraphicsConsolesResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmGraphicsConsolesResource.java 10 files changed, 159 insertions(+), 8 deletions(-) Approvals: Jenkins CI: Passed CI tests Sharon Gratch: Verified Shmuel Leib Melamud: Looks good to me, but someone else must approve Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/70694 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I15d94b31d91d51b0319af9100fcb45f1e1984ad8 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: doc: Add python-dateutil to required pkgs in README
by Code Review 26 Jan '17

26 Jan '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: doc: Add python-dateutil to required pkgs in README ...................................................................... doc: Add python-dateutil to required pkgs in README Adds python-dateutils to required packages list in README. Dependency to this package was added in Icbac46cf8e8062179dc389df2cb9eb448beb8646, but I've forgotten to update README file. Change-Id: I02d5e1b7bd92f209e56c5a9c46c18ea2b2116d9f Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M README.adoc 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Martin Peřina: Verified Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/71267 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I02d5e1b7bd92f209e56c5a9c46c18ea2b2116d9f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: nightly 4.1 publisher: modified to use only 4.1 jobs
by Code Review 26 Jan '17

26 Jan '17

>From Eyal Edri <eedri(a)redhat.com>: Eyal Edri has submitted this change and it was merged. Change subject: nightly 4.1 publisher: modified to use only 4.1 jobs ...................................................................... nightly 4.1 publisher: modified to use only 4.1 jobs Change-Id: I93a50de6af48d0b03924bcd951c58d413698d199 Signed-off-by: Daniel Belenky <dbelenky(a)redhat.com> --- M jobs/confs/projects/ovirt/publish-rpms-nightly-4.1.yaml 1 file changed, 36 insertions(+), 38 deletions(-) Approvals: Eyal Edri: Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests Daniel Belenky: Verified -- To view, visit https://gerrit.ovirt.org/70568 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I93a50de6af48d0b03924bcd951c58d413698d199 Gerrit-PatchSet: 16 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gal Ben Haim <galbh2(a)gmail.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Add NGN builders for ovirt-4.1
by Code Review 26 Jan '17

26 Jan '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: Add NGN builders for ovirt-4.1 ...................................................................... Add NGN builders for ovirt-4.1 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1415968 Change-Id: I0f50461158164a2b87f50ff65bd2d282d0c4d2ee Signed-off-by: Ryan Barry <rbarry(a)redhat.com> --- M jobs/confs/projects/ovirt-node-ng/ovirt-node-ng.yaml 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests Ryan Barry: Ready for review -- To view, visit https://gerrit.ovirt.org/71102 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0f50461158164a2b87f50ff65bd2d282d0c4d2ee Gerrit-PatchSet: 4 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Ryan Barry <rbarry(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ryan Barry <rbarry(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: Max memory validation in import commands
by Code Review 26 Jan '17

26 Jan '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Max memory validation in import commands ...................................................................... core: Max memory validation in import commands VmBase#maxMemorySizeMb is validated in import commands since VMs/Templates may come from unreliable source and the value may be invalid/missing. Change-Id: I22fa4b0252e8bed8eb88e87a54903af25ce2e28c Bug-Url: https://bugzilla.redhat.com/1410606 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmFromExternalProviderCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmTemplateCommand.java 3 files changed, 12 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Passed CI tests Jakub Niedermertl: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/69771 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I22fa4b0252e8bed8eb88e87a54903af25ce2e28c Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: Handling of missing maxMemory unified
by Code Review 26 Jan '17

26 Jan '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Handling of missing maxMemory unified ...................................................................... core: Handling of missing maxMemory unified VmHandler#updateMaxMemorySize handles all settings of potentially missing value of VmBase#maxMemorySizeMb at following places: * ImportVmCommand (newly added) * ImportVmFromExternalProviderCommand * ImportVmTemplateCommand * SnapshotsManager Change-Id: Ic884a696f1b7e44b43286f2f6871d2803ae8c362 Bug-Url: https://bugzilla.redhat.com/1410606 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportUtils.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmFromExternalProviderCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsManager.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/exportimport/ImportVmTemplateCommandTest.java 8 files changed, 44 insertions(+), 25 deletions(-) Approvals: Jakub Niedermertl: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/69772 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic884a696f1b7e44b43286f2f6871d2803ae8c362 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: TransferImage - update actual size
by Code Review 26 Jan '17

26 Jan '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: TransferImage - update actual size ...................................................................... core: TransferImage - update actual size Setting DestinationImageId at TransferImageCommand in order to retrieve the updated DiskImage from getVolumeInfo (on BaseImagesCommand -> endSuccessfully). Change-Id: Ic838111a0fd3367b2aed109963c403b8e578952b Bug-Url: https://bugzilla.redhat.com/1414084 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/TransferImageCommand.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/71240 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic838111a0fd3367b2aed109963c403b8e578952b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-release[master]: spec: add missing ARCH variable in experimental %post
by Code Review 26 Jan '17

26 Jan '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: spec: add missing ARCH variable in experimental %post ...................................................................... spec: add missing ARCH variable in experimental %post experimental %post was missing ARCH variable. Change-Id: Ic0194f3fb32eb2a1e70b37d8f66612c9259a8bdf Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-release-master.spec.in 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/71255 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic0194f3fb32eb2a1e70b37d8f66612c9259a8bdf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0