January 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-4.1]: restAPI: Set the disk id on return value when import from gl...
by Code Review 17 Jan '17

17 Jan '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: restAPI: Set the disk id on return value when import from glance. ...................................................................... restAPI: Set the disk id on return value when import from glance. Set the disk id in the return value when importing a glance image. The REST should use this disk id in the response body. Change-Id: Ia33628c593cfc4d03020e8f7828d1200ab16efb5 Bug-Url: https://bugzilla.redhat.com/1411123 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/repoimage/ImportRepoImageCommand.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/70680 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia33628c593cfc4d03020e8f7828d1200ab16efb5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[sdk_4.0]: Improve example showing how to add a Glance storage domain
by Code Review 17 Jan '17

17 Jan '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Improve example showing how to add a Glance storage domain ...................................................................... Improve example showing how to add a Glance storage domain This improves the example that shows how to add a Glance storage domain, adding a check to verify if it already exists, and adding a comment explaining how to provide additional security details. Change-Id: I7a8e6bedda8fd5d3e4e1bddb04c83c9b0e875054 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 8426567f4f544568ab76515adc6b33a624924ab1) (cherry picked from commit e81c1c9de88c92f7849dbbbb18bad800f3f59de0) --- M sdk/examples/add_openstack_image_provider.py 1 file changed, 43 insertions(+), 12 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/70693 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7a8e6bedda8fd5d3e4e1bddb04c83c9b0e875054 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_4.0 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[sdk_4.1]: Improve example showing how to add a Glance storage domain
by Code Review 17 Jan '17

17 Jan '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Improve example showing how to add a Glance storage domain ...................................................................... Improve example showing how to add a Glance storage domain This improves the example that shows how to add a Glance storage domain, adding a check to verify if it already exists, and adding a comment explaining how to provide additional security details. Change-Id: I7a8e6bedda8fd5d3e4e1bddb04c83c9b0e875054 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 8426567f4f544568ab76515adc6b33a624924ab1) --- M sdk/examples/add_openstack_image_provider.py 1 file changed, 43 insertions(+), 12 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/70691 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7a8e6bedda8fd5d3e4e1bddb04c83c9b0e875054 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_4.1 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[sdk_4.0]: Fix permissions of examples
by Code Review 17 Jan '17

17 Jan '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Fix permissions of examples ...................................................................... Fix permissions of examples This patch adds the missing execution permissions to some of the examples. Change-Id: Ia7dc49335a171736adf14c2973587b8fe8683f7e Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 0d8de1a827b327a8c60d4fe42c40f76ee7dbc720) (cherry picked from commit b083f4d40bda2c814fc17f92c9bda19c02b25eaa) --- M sdk/examples/import_vm.py M sdk/examples/start_vm_with_boot_devices.py 2 files changed, 0 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/70690 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia7dc49335a171736adf14c2973587b8fe8683f7e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_4.0 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[master]: Improve example showing how to add a Glance storage domain
by Code Review 17 Jan '17

17 Jan '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Improve example showing how to add a Glance storage domain ...................................................................... Improve example showing how to add a Glance storage domain This improves the example that shows how to add a Glance storage domain, adding a check to verify if it already exists, and adding a comment explaining how to provide additional security details. Change-Id: I7a8e6bedda8fd5d3e4e1bddb04c83c9b0e875054 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M sdk/examples/add_openstack_image_provider.py 1 file changed, 43 insertions(+), 12 deletions(-) Approvals: Ondra Machacek: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/70620 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7a8e6bedda8fd5d3e4e1bddb04c83c9b0e875054 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[sdk_4.1]: Fix permissions of examples
by Code Review 17 Jan '17

17 Jan '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Fix permissions of examples ...................................................................... Fix permissions of examples This patch adds the missing execution permissions to some of the examples. Change-Id: Ia7dc49335a171736adf14c2973587b8fe8683f7e Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 0d8de1a827b327a8c60d4fe42c40f76ee7dbc720) --- M sdk/examples/import_vm.py M sdk/examples/start_vm_with_boot_devices.py 2 files changed, 0 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/70689 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia7dc49335a171736adf14c2973587b8fe8683f7e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_4.1 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[master]: Fix permissions of examples
by Code Review 17 Jan '17

17 Jan '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Fix permissions of examples ...................................................................... Fix permissions of examples This patch adds the missing execution permissions to some of the examples. Change-Id: Ia7dc49335a171736adf14c2973587b8fe8683f7e Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M sdk/examples/import_vm.py M sdk/examples/start_vm_with_boot_devices.py 2 files changed, 0 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/70612 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia7dc49335a171736adf14c2973587b8fe8683f7e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: Checking if VM uses a lease should be based on the VM ...
by Code Review 17 Jan '17

17 Jan '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Checking if VM uses a lease should be based on the VM from params ...................................................................... core: Checking if VM uses a lease should be based on the VM from params Change-Id: I25835a783bb3ec97b32e8e7641df8b2c5794799b Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommand.java 4 files changed, 5 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/70688 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I25835a783bb3ec97b32e8e7641df8b2c5794799b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in mom[master]: Fix DeprecationWarning for using BaseException.message
by Code Review 17 Jan '17

17 Jan '17

>From Martin Sivák <msivak(a)redhat.com>: Martin Sivák has submitted this change and it was merged. Change subject: Fix DeprecationWarning for using BaseException.message ...................................................................... Fix DeprecationWarning for using BaseException.message Change-Id: Ia3684a49b0626812ec5657338543d195fc75c376 Bug-Url: https://bugzilla.redhat.com/1370081 Signed-off-by: Andrej Krejcir <akrejcir(a)redhat.com> Reviewed-on: https://gerrit.ovirt.org/70639 Continuous-Integration: Jenkins CI Reviewed-by: Denis Chaplygin <dchaplyg(a)redhat.com> Reviewed-by: Martin Sivák <msivak(a)redhat.com> --- M mom/Collectors/GuestMemory.py M mom/Collectors/QemuGuestAgentClient.py M mom/Entity.py M mom/HypervisorInterfaces/libvirtInterface.py 4 files changed, 8 insertions(+), 9 deletions(-) Approvals: Denis Chaplygin: Looks good to me, but someone else must approve Martin Sivák: Looks good to me, approved Jenkins CI: Passed CI tests Andrej Krejcir: Verified -- To view, visit https://gerrit.ovirt.org/70639 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia3684a49b0626812ec5657338543d195fc75c376 Gerrit-PatchSet: 2 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Checking if VM uses a lease should be based on the VM ...
by Code Review 17 Jan '17

17 Jan '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Checking if VM uses a lease should be based on the VM from params ...................................................................... core: Checking if VM uses a lease should be based on the VM from params Change-Id: I25835a783bb3ec97b32e8e7641df8b2c5794799b Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommand.java 4 files changed, 5 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/70682 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I25835a783bb3ec97b32e8e7641df8b2c5794799b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0