January 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-4.1]: core: refactoring vm analyzer
by Code Review 15 Jan '17

15 Jan '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: refactoring vm analyzer ...................................................................... core: refactoring vm analyzer Refactor VmAnalyzer#proceedVmReportedOnOtherHost, extracting the default logic to be after the switch-cases block. Change-Id: I7364c7240aebd989e6b13bbec72fb8bca2364fba Bug-Url: https://bugzilla.redhat.com/1317429 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java 1 file changed, 18 insertions(+), 15 deletions(-) Approvals: Tal Nisan: Passed CI tests Shahar Havivi: Looks good to me, approved Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/69681 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7364c7240aebd989e6b13bbec72fb8bca2364fba Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: increase the interval between retries to auto start vm...
by Code Review 15 Jan '17

15 Jan '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: increase the interval between retries to auto start vm with a lease ...................................................................... core: increase the interval between retries to auto start vm with a lease Increase it from 30 iterations to 100 iterations. Theoretically that should be 5 minutes but in practice it will be lower. It is expected to be ~4.25 minutes. Change-Id: I911c29694b04f9438b9a4ba9ac8b4cbaf1b49284 Bug-Url: https://bugzilla.redhat.com/1317429 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Passed CI tests Shahar Havivi: Looks good to me, approved Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/69684 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I911c29694b04f9438b9a4ba9ac8b4cbaf1b49284 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: better support in the monitoring for auto start of vms...
by Code Review 15 Jan '17

15 Jan '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: better support in the monitoring for auto start of vms with lease ...................................................................... core: better support in the monitoring for auto start of vms with lease Prevent the VM from switching to Down state upon failure to start on a host while being in Unknown state on another host: 1. We do not change the status and run_on_vds fields of the VM on run VM. 2. Clear the async running VM operation before auto start attempt to avoid errors of type 'VM is during initiating'. 3. Clear the async running VM when a VM is restored from Unknown status (but not when it goes to WaitForLaunch or MigratingTo statuses that do not necessarily mean that the VM is actually running). Change-Id: Icca6920dce600959045d8885404a0de056b88c8f Bug-Url: https://bugzilla.redhat.com/1317429 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/CreateVmVDSCommandParameters.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/CreateVmVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java 5 files changed, 34 insertions(+), 6 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/69683 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icca6920dce600959045d8885404a0de056b88c8f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: automatically start vms with lease by their priority
by Code Review 15 Jan '17

15 Jan '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: automatically start vms with lease by their priority ...................................................................... core: automatically start vms with lease by their priority Before iterating the VMs that are both in Unknown status and configured with a lease and automatically try to start them, sort them according to their priority. Change-Id: I84c9e6af89ac4bf530f0124f928f707a8e310e32 Bug-Url: https://bugzilla.redhat.com/1317429 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmStaticDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmStaticDaoImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmStaticDaoTest.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsOnHostComparator.java M packaging/dbscripts/vms_sp.sql 6 files changed, 80 insertions(+), 0 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/69682 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I84c9e6af89ac4bf530f0124f928f707a8e310e32 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: use stream on isAllHostConnectionFailed method
by Code Review 15 Jan '17

15 Jan '17

>From Daniel Erez <derez(a)redhat.com>: Daniel Erez has submitted this change and it was merged. Change subject: core: use stream on isAllHostConnectionFailed method ...................................................................... core: use stream on isAllHostConnectionFailed method Using stream on isAllHostConnectionFailed method (in AttachStorageDomainToPool and ActivateStorageDomain) Change-Id: I40f377b8ed8a18d8cd4628b2edd3c3c330802d46 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/ActivateStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/AttachStorageDomainToPoolCommand.java 2 files changed, 2 insertions(+), 12 deletions(-) Approvals: Daniel Erez: Verified Jenkins CI: Passed CI tests Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/70163 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I40f377b8ed8a18d8cd4628b2edd3c3c330802d46 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Simplify filtering method in DeactivateStorageDomainCo...
by Code Review 15 Jan '17

15 Jan '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Simplify filtering method in DeactivateStorageDomainCommand ...................................................................... core: Simplify filtering method in DeactivateStorageDomainCommand The method filterDomainsByStatus was used to filter a domain list by status yet was only used since it was introduced to filter out non active domains hence can be simplified to filter out only non active domains Change-Id: I77e96de06d0c19b7855a98a5f7b980a748a84095 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/DeactivateStorageDomainCommand.java 1 file changed, 6 insertions(+), 9 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved Benny Zlotnik: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Freddy Rolland: Looks good to me, but someone else must approve Idan Shaby: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/69968 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I77e96de06d0c19b7855a98a5f7b980a748a84095 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Benny Zlotnik <bzlotnik(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in gerrit-admin[master]: Add verify grade in check_backport hook
by Code Review 15 Jan '17

15 Jan '17

>From Shlomo Ben David <sbendavi(a)redhat.com>: Shlomo Ben David has submitted this change and it was merged. Change subject: Add verify grade in check_backport hook ...................................................................... Add verify grade in check_backport hook Adding verify grade (-1) if the patch wasn't backported (merged) to the relevant (newer) stable branches. In addition retyped the messages that will be printed to the user. Change-Id: I73f0ba64d1d9adc7becbbeb35fb1375bc4636fa2 Fixes: OVIRT-1020 Signed-off-by: Shlomi Ben-David <sbendavi(a)redhat.com> --- M hooks/custom_hooks/check_backport 1 file changed, 31 insertions(+), 40 deletions(-) Approvals: Shlomo Ben David: Verified; Looks good to me, approved Gil Shinar: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/70109 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I73f0ba64d1d9adc7becbbeb35fb1375bc4636fa2 Gerrit-PatchSet: 5 Gerrit-Project: gerrit-admin Gerrit-Branch: master Gerrit-Owner: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>

1 0

Change in ovirt-engine[master]: core : Storage domains not showing in search on a DC named w...
by Code Review 15 Jan '17

15 Jan '17

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: core : Storage domains not showing in search on a DC named with an underscore ...................................................................... core : Storage domains not showing in search on a DC named with an underscore When data center name has an underscore in them the search sql for storage domains for the data center is executed with escaped data center name. This causes issue when the escaped name is used in the lefy hand side of the like clause. When the name is used on the left hand side of the like clause it does not have to be escaped. Change-Id: I3049eb2641d7a86b0b857aa9a46376d794d14812 Bug-Url: https://bugzilla.redhat.com/1409849 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/BaseConditionFieldAutoCompleter.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VdcUserConditionFieldAutoCompleter.java 3 files changed, 27 insertions(+), 19 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Ravi Nori: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/69926 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3049eb2641d7a86b0b857aa9a46376d794d14812 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: use default mac pool for clusters without DC
by Code Review 15 Jan '17

15 Jan '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: use default mac pool for clusters without DC ...................................................................... core: use default mac pool for clusters without DC There might exist clusters, which are not linked to any data center. For those first update statement does not work, leaving possible null values in cluster.mac_pool_id column, and because of that adding of constraint will fail. We have to select some mac pool to be used for such clusters, and having no information which should be used, we can use only default mac pool. Change-Id: If33a212d6c8f730bae8ebe46bc1d6359e95c0495 Bug-Url: https://bugzilla.redhat.com/1410189 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M packaging/dbscripts/upgrade/04_01_0010_add_mac_pool_id_to_vds_group.sql 1 file changed, 13 insertions(+), 0 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Martin Mucha: Verified Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/70108 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If33a212d6c8f730bae8ebe46bc1d6359e95c0495 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: restapi: Add remoteviewerconnectionfile action to graphicsco...
by Code Review 15 Jan '17

15 Jan '17

>From Piotr Kliczewski <piotr.kliczewski(a)gmail.com>: Piotr Kliczewski has submitted this change and it was merged. Change subject: restapi: Add remoteviewerconnectionfile action to graphicsconsole ...................................................................... restapi: Add remoteviewerconnectionfile action to graphicsconsole This patch add new action called remoteviewerconnectionfile to graphicsconsole service, which generate remote viewer connection file, which is compatible with remove-viewer client. Change-Id: Id5c42d51a3e83fe24465c2ade4fab709ccfdff11 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1378902 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> (cherry picked from commit ad84d9f37afc9f7119ac9bbf2b1fe97f9dfea192) --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmGraphicsConsoleResource.java 1 file changed, 52 insertions(+), 25 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/70347 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id5c42d51a3e83fe24465c2ade4fab709ccfdff11 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0