January 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Fix PredefinedVMProperties definition
by Code Review 11 Jan '17

11 Jan '17

>From Martin Peřina <mperina(a)redhat.com>: Martin Peřina has submitted this change and it was merged. Change subject: core: Fix PredefinedVMProperties definition ...................................................................... core: Fix PredefinedVMProperties definition PredefinedVMProperties contains the same value for all existing versions, so we can rely on default value in ConfigValues class instead of having the same value for each version in database. Change-Id: I466e1c21b1dd5eb7934bc306d4197ce6bfd1dc9f Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 2 files changed, 4 insertions(+), 2 deletions(-) Approvals: Martin Peřina: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/69830 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I466e1c21b1dd5eb7934bc306d4197ce6bfd1dc9f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: cleanup: provide a cleanup script for leftovers
by Code Review 11 Jan '17

11 Jan '17

>From Simone Tiraboschi <stirabos(a)redhat.com>: Simone Tiraboschi has submitted this change and it was merged. Change subject: cleanup: provide a cleanup script for leftovers ...................................................................... cleanup: provide a cleanup script for leftovers Provide a cleanup script for leftovers to let the user retry ovirt-hosted-engine-setup from scratch. Change-Id: I5c802459fb7dfa3a6dc08cf90ddf56ed3c4768d0 Bug-Url: https://bugzilla.redhat.com/1001181 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- D cleanup.sh M ovirt-hosted-engine-setup.spec.in M src/bin/Makefile.am A src/bin/ovirt-hosted-engine-cleanup 4 files changed, 89 insertions(+), 21 deletions(-) Approvals: Simone Tiraboschi: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/67592 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5c802459fb7dfa3a6dc08cf90ddf56ed3c4768d0 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: packaging: setup: add CLI disconnect-storage option
by Code Review 11 Jan '17

11 Jan '17

>From Simone Tiraboschi <stirabos(a)redhat.com>: Simone Tiraboschi has submitted this change and it was merged. Change subject: packaging: setup: add CLI disconnect-storage option ...................................................................... packaging: setup: add CLI disconnect-storage option Add disconnect-storage CLI option Change-Id: Iffa3fc9ad1cfdec356ae8762c3bbd1480c91905b Depends-On: https://gerrit.ovirt.org/69909 Bug-Url: https://bugzilla.redhat.com/1001181 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M man/hosted-engine.8 M src/bin/hosted-engine.in M src/ovirt_hosted_engine_setup/Makefile.am A src/ovirt_hosted_engine_setup/disconnect_storage_server.py 4 files changed, 51 insertions(+), 0 deletions(-) Approvals: Simone Tiraboschi: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Rafael Martins: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/48834 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iffa3fc9ad1cfdec356ae8762c3bbd1480c91905b Gerrit-PatchSet: 12 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin, userportal: Fix NPE in AbstractSizeColumn
by Code Review 11 Jan '17

11 Jan '17

>From Vojtech Szocs <vszocs(a)redhat.com>: Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin,userportal: Fix NPE in AbstractSizeColumn ...................................................................... webadmin,userportal: Fix NPE in AbstractSizeColumn The column's Comparator should not fail on NPE when getRawValue(T) returns null. Change-Id: Ibf61f5e244c1bfdb3ad3590e7cdd6c7ed2432203 Bug-Url: https://bugzilla.redhat.com/1391013 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/AbstractSizeColumn.java 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved Vojtech Szocs: Verified -- To view, visit https://gerrit.ovirt.org/68573 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibf61f5e244c1bfdb3ad3590e7cdd6c7ed2432203 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Refresh VM numa nodes when VM memory or CPU cores ...
by Code Review 11 Jan '17

11 Jan '17

>From Alexander Wels <awels(a)redhat.com>: Alexander Wels has submitted this change and it was merged. Change subject: webadmin: Refresh VM numa nodes when VM memory or CPU cores are changed ...................................................................... webadmin: Refresh VM numa nodes when VM memory or CPU cores are changed When the total memory of a VM or the number of its CPU cores is changed while editing, the numa nodes are changed to fit the new values. Change-Id: I9fee622ec205c6495885086b221482593b15eb7b Bug-Url: https://bugzilla.redhat.com/1291064 Signed-off-by: Andrej Krejcir <akrejcir(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Martin Sivák: Looks good to me, approved Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Andrej Krejcir: Verified -- To view, visit https://gerrit.ovirt.org/69932 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9fee622ec205c6495885086b221482593b15eb7b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-ha[v2.1.z]: Fix specParams parsing in OVF converter and update the RNG c...
by Code Review 11 Jan '17

11 Jan '17

>From Martin Sivák <msivak(a)redhat.com>: Martin Sivák has submitted this change and it was merged. Change subject: Fix specParams parsing in OVF converter and update the RNG code (this fixed the latest build failure) ...................................................................... Fix specParams parsing in OVF converter and update the RNG code (this fixed the latest build failure) Change-Id: I3e4f354b7eabd08df08d2ba964330f3dbc8d2475 Bug-Url: https://bugzilla.redhat.com/1368027 (cherry picked from commit 80472b0f3418f93b7c3c6bc52e20ed478fd96f9a) --- M ovirt_hosted_engine_ha/lib/ovf/ovf2VmParams.py M ovirt_hosted_engine_ha/lib/ovf/ovf2VmParams_test.py M ovirt_hosted_engine_ha/lib/ovf/ovf_test_max_vcpu.xml 3 files changed, 24 insertions(+), 4 deletions(-) Approvals: Martin Sivák: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/69923 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3e4f354b7eabd08df08d2ba964330f3dbc8d2475 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: v2.1.z Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: scheduling: Changed default factor for VM to host.
by Code Review 11 Jan '17

11 Jan '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: scheduling: Changed default factor for VM to host. ...................................................................... scheduling: Changed default factor for VM to host. Default factor of VmToHostsAffinityGroups weight policy unit to 10. This was done in order to give VM to host affinity a higher priority over other policy units (especially for balancing purpose). Change-Id: Iadf77e368c9bff04d33a0eb9f3de700cec6cbf9e Bug-Url: https://bugzilla.redhat.com/1410040 Signed-off-by: Yanir Quinn <yquinn(a)redhat.com> (cherry picked from commit 4959cdd) --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/InternalClusterPolicies.java 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Martin Sivák: Looks good to me, approved Jenkins CI: Passed CI tests Yanir Quinn: Verified -- To view, visit https://gerrit.ovirt.org/69924 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iadf77e368c9bff04d33a0eb9f3de700cec6cbf9e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: scheduling: Use the pending VM count in EvenGuestDistr. weig...
by Code Review 11 Jan '17

11 Jan '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: scheduling: Use the pending VM count in EvenGuestDistr. weight unit ...................................................................... scheduling: Use the pending VM count in EvenGuestDistr. weight unit Change-Id: I01c04fec089af07308ac645b41f8bc857134a015 Bug-Url: https://bugzilla.redhat.com/1411460 Signed-off-by: Martin Sivak <msivak(a)redhat.com> (cherry picked from commit 1a95fbc242cf9d2cfb80f46549876c190ecf5b32) --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/EvenGuestDistributionWeightPolicyUnit.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Martin Sivák: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/69922 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I01c04fec089af07308ac645b41f8bc857134a015 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: scheduling: Use the pending VM count in EvenGuestDistr. weig...
by Code Review 11 Jan '17

11 Jan '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: scheduling: Use the pending VM count in EvenGuestDistr. weight unit ...................................................................... scheduling: Use the pending VM count in EvenGuestDistr. weight unit Change-Id: I01c04fec089af07308ac645b41f8bc857134a015 Bug-Url: https://bugzilla.redhat.com/1411460 Signed-off-by: Martin Sivak <msivak(a)redhat.com> (cherry picked from commit 1a95fbc242cf9d2cfb80f46549876c190ecf5b32) --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/EvenGuestDistributionWeightPolicyUnit.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Martin Sivák: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/69921 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I01c04fec089af07308ac645b41f8bc857134a015 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in gerrit-admin[master]: Fix check_backport hook
by Code Review 11 Jan '17

11 Jan '17

>From Shlomo Ben David <sbendavi(a)redhat.com>: Shlomo Ben David has submitted this change and it was merged. Change subject: Fix check_backport hook ...................................................................... Fix check_backport hook Change-Id: I07eca2d99711a9da5d417aedf488a8ca359b2ebb Signed-off-by: Shlomi Ben-David <sbendavi(a)redhat.com> --- M hooks/custom_hooks/check_backport 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Shlomo Ben David: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/69935 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I07eca2d99711a9da5d417aedf488a8ca359b2ebb Gerrit-PatchSet: 1 Gerrit-Project: gerrit-admin Gerrit-Branch: master Gerrit-Owner: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>

1 0