January 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: restapi: Update to model 4.2.1 and metamodel 1.2.0
by Code Review 04 Jan '17

04 Jan '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Update to model 4.2.1 and metamodel 1.2.0 ...................................................................... restapi: Update to model 4.2.1 and metamodel 1.2.0 This change updates the engine to use version 4.2.1 of the model and version 1.2.0 of the metamodel. The more relevant changes in the new version of the model are the following: * Add `initial_size` attribute to the `Disk` type. The more relevant changes in the new version of the metamodel are the following: * Don't import `JsonParser.Event` directly, as it conflicts with the `Event` type of the model. * Fix reading of XML attributes of enum types https://bugzilla.redhat.com/1408839[#1408839]. * Use non-capturing groups in generated `@Path` annotations https://bugzilla.redhat.com/1405774[#1405774]. * Add `Disk.initialSize` to the list of exceptions of integer attributes that are represented using `xs:long` instead of `xs:int`. Change-Id: I7e649aa26a30f5a450353fa56e1282f9767ba4c3 Related-To: https://bugzilla.redhat.com/1405774 Related-To: https://bugzilla.redhat.com/1408839 Related-To: https://bugzilla.redhat.com/1400296 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M pom.xml 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Verified Jenkins CI: Passed CI tests Liron Aravot: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/69598 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7e649aa26a30f5a450353fa56e1282f9767ba4c3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: order VMs by Network doesn't work
by Code Review 04 Jan '17

04 Jan '17

>From Shahar Havivi <shavivi(a)redhat.com>: Shahar Havivi has submitted this change and it was merged. Change subject: core: order VMs by Network doesn't work ...................................................................... core: order VMs by Network doesn't work commit 166f43c3776a2332ce9cdf377795220fdb17f6e1 removed usage_network_percent which is needed by the search for sorting VMs by network usage. Change-Id: I6ec4807ad8f63a958f43582385fde89c72f9cb54 Bug-Url: https://bugzilla.redhat.com/1400642 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmStatisticsDaoImpl.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M packaging/dbscripts/create_views.sql A packaging/dbscripts/upgrade/04_01_0700_add_network_usage_to_vm_statistics.sql M packaging/dbscripts/vms_sp.sql 5 files changed, 20 insertions(+), 0 deletions(-) Approvals: Shahar Havivi: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/69488 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6ec4807ad8f63a958f43582385fde89c72f9cb54 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: scheduler: Log error if scheduled task cannot be submitted
by Code Review 04 Jan '17

04 Jan '17

>From Martin Peřina <mperina(a)redhat.com>: Martin Peřina has submitted this change and it was merged. Change subject: scheduler: Log error if scheduled task cannot be submitted ...................................................................... scheduler: Log error if scheduled task cannot be submitted Logs error if scheduled task cannot be submitted (which means that the task is dropped), so administrators can easily find out that Quartz thread pool has been depleted and no other scheduled task will be executed until some already running thread is returned to the pool. Change-Id: I769a913d0208d61399ee60441f1c09e8cc03ada7 Signed-off-by: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> --- M backend/manager/modules/scheduler/src/main/java/org/ovirt/engine/core/utils/timer/SchedulerThreadPool.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Piotr Kliczewski: Verified Martin Peřina: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/68900 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I769a913d0208d61399ee60441f1c09e8cc03ada7 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: missing title for storage->import dialogs
by Code Review 04 Jan '17

04 Jan '17

>From Tomas Jelinek <tjelinek(a)redhat.com>: Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: missing title for storage->import dialogs ...................................................................... webadmin: missing title for storage->import dialogs The Import VM(s) or Import Template(s) dialogs, accessed via the Storage main tab, were opened without a dialog title. Go to webadmin -> Storage tab -> Mark an export domain and go to "VM Import" or "Template Import" tabs -> click Import -> the dialogs are now opened with titles: "Import Virtual Machine(s)" or "Import Template(s)", respectively. Change-Id: I57b36e1b7d53d599777950d15e1ab1baa5043840 Bug-Url: https://bugzilla.redhat.com/1378034 Signed-off-by: Sharon Gratch <sgratch(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/TemplateBackupModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/VmBackupModel.java 2 files changed, 2 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Passed CI tests Sharon Gratch: Verified -- To view, visit https://gerrit.ovirt.org/69442 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I57b36e1b7d53d599777950d15e1ab1baa5043840 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: TransferImage - callback end methods NPE
by Code Review 04 Jan '17

04 Jan '17

>From Liron Aravot <laravot(a)redhat.com>: Liron Aravot has submitted this change and it was merged. Change subject: core: TransferImage - callback end methods NPE ...................................................................... core: TransferImage - callback end methods NPE When the TransferImageCommand is being executed for pre existing disk it'll attempt to load the disk from the db on the OnSucceeded/OnFailed methods using the image id provided in the command parameters while for a created disk by the command the data will be taken from the AddDisk parameters. When uploading to a pre existing disk, the id provided by the user is passed the in the parameters image id (field which should represent a volume) instead of in the image group id field (which should represnt the disk id). When attempting to load the image in the end method using getDiskImage() no data will be returned as the disk id is used as the volume id and NPE will be thrown. In other parts of the command the disk is loaded manually, therefore this exception is thrown only on the end methods. Looking forward, we should pass the id provided by the user in the parameters image group id and complete the image id from the db - this patch fixes the problem by altering the log in order to reduce the risk in backporting this change to the stable branches. Change-Id: Ice26f4d19723042097a81ea4b685a7aa31faf976 Bug-url: https://bugzilla.redhat.com/1400299 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/TransferImageCommand.java 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/69473 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ice26f4d19723042097a81ea4b685a7aa31faf976 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: maxMemory send only if it differs from memory
by Code Review 04 Jan '17

04 Jan '17

>From Tomas Jelinek <tjelinek(a)redhat.com>: Tomas Jelinek has submitted this change and it was merged. Change subject: core: maxMemory send only if it differs from memory ...................................................................... core: maxMemory send only if it differs from memory VM attribute maxMemSize is send to VDSM only if maximum memory is different from memory. If both attributes are set to the same value, QEMU crashes. Change-Id: Ia9a54d1f254c07aeb4ad16c69f76fa8f0b762715 Bug-Url: https://bugzilla.redhat.com/1406749 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/VmInfoBuilderImpl.java 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Jakub Niedermertl: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/69507 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia9a54d1f254c07aeb4ad16c69f76fa8f0b762715 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Unused OsRepositoryImpl#osUsbBusType removed
by Code Review 04 Jan '17

04 Jan '17

>From Tomas Jelinek <tjelinek(a)redhat.com>: Tomas Jelinek has submitted this change and it was merged. Change subject: core: Unused OsRepositoryImpl#osUsbBusType removed ...................................................................... core: Unused OsRepositoryImpl#osUsbBusType removed Change-Id: Ia77112aa625d987b99533dad5cc2b22475924048 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/OsRepositoryImpl.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Jakub Niedermertl: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/69508 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia77112aa625d987b99533dad5cc2b22475924048 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-2.1]: jsonrpc: python jsonrpcvdscli instead of vdsClient
by Code Review 04 Jan '17

04 Jan '17

>From Simone Tiraboschi <stirabos(a)redhat.com>: Simone Tiraboschi has submitted this change and it was merged. Change subject: jsonrpc: python jsonrpcvdscli instead of vdsClient ...................................................................... jsonrpc: python jsonrpcvdscli instead of vdsClient Use python jsonrpcvdscli instead of vdsClient for ancillary commands on bash scripts. Adding unit test for the vm.conf parsing code based on pytest. Adding the initial pytest configuration. Change-Id: I4880eb94dfabe9628d34687a97febe3b1c6fd969 Bug-Url: https://bugzilla.redhat.com/1393918 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> Signed-off-by: Nir Soffer <nsoffer(a)redhat.com> --- M .gitignore M Makefile.am M ovirt-hosted-engine-setup.spec.in M po/POTFILES.in A pytest.ini M src/bin/hosted-engine.in M src/ovirt_hosted_engine_setup/Makefile.am A src/ovirt_hosted_engine_setup/vdsm_helper.py A src/ovirt_hosted_engine_setup/vm_test.conf A src/ovirt_hosted_engine_setup/vmconf.py A src/ovirt_hosted_engine_setup/vmconf_test.py M src/plugins/gr-he-upgradeappliance/vm/runvm.py 12 files changed, 534 insertions(+), 55 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Simone Tiraboschi: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Rafael Martins: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/69563 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4880eb94dfabe9628d34687a97febe3b1c6fd969 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-2.1 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-ha[master]: Fix getting MD5 hash for configuration tar
by Code Review 04 Jan '17

04 Jan '17

>From Martin Sivák <msivak(a)redhat.com>: Martin Sivák has submitted this change and it was merged. Change subject: Fix getting MD5 hash for configuration tar ...................................................................... Fix getting MD5 hash for configuration tar Use the _enforce_vdsm_user method to execute the md5hash command. Change-Id: If23a79478f8c7f782b6fe8135118bee72fb8f776 Bug-Url: https://bugzilla.redhat.com/1301681 Signed-off-by: Jenny Tokar <jtokar(a)redhat.com> --- M ovirt_hosted_engine_ha/lib/heconflib.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Martin Sivák: Looks good to me, approved Jenkins CI: Passed CI tests Jenny Tokar: Verified -- To view, visit https://gerrit.ovirt.org/69236 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If23a79478f8c7f782b6fe8135118bee72fb8f776 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: accept ipv6 address for migration role
by Code Review 04 Jan '17

04 Jan '17

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: core: accept ipv6 address for migration role ...................................................................... core: accept ipv6 address for migration role migration should be possible with just an operational ipv6 bootproto, while currently only ipv4 is being considered. Change-Id: Ia53b5d0eb3520e6a5c78100fca7f84df084e6542 Bug-Id: https://bugzilla.redhat.com/1402407 Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/NetworkAttachmentValidator.java 1 file changed, 33 insertions(+), 8 deletions(-) Approvals: Jenkins CI: Passed CI tests Leon Goldberg: Verified Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/68481 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia53b5d0eb3520e6a5c78100fca7f84df084e6542 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0