February 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: scheduler should filter hosts based on their cluster l...
by Code Review 12 Feb '17

12 Feb '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: scheduler should filter hosts based on their cluster level ...................................................................... core: scheduler should filter hosts based on their cluster level Previously, the scheduling filter that filters hosts by their compatibility version examined their 'supported engine versions' rather than 'supported cluster levels' that should have been checked. Change-Id: I54901716a39a0dd0f7618cea51e6de158a020657 Bug-Url: https://bugzilla.redhat.com/1421174 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/CompatibilityVersionFilterPolicyUnit.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Shmuel Leib Melamud: Looks good to me, but someone else must approve Arik Hadas: Verified Yanir Quinn: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/72110 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I54901716a39a0dd0f7618cea51e6de158a020657 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Add PostcopyMigrationFailed VM exit reason
by Code Review 12 Feb '17

12 Feb '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: Add PostcopyMigrationFailed VM exit reason ...................................................................... core: Add PostcopyMigrationFailed VM exit reason Change-Id: I13c25ad704990aa5b5380fa27b5602089e1ffa25 Signed-off-by: Milan Zamazal <mzamazal(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmExitReason.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved Milan Zamazal: Verified -- To view, visit https://gerrit.ovirt.org/72066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I13c25ad704990aa5b5380fa27b5602089e1ffa25 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Avoid remove temp files of pipeline plugin
by Code Review 12 Feb '17

12 Feb '17

>From Eyal Edri <eedri(a)redhat.com>: Eyal Edri has submitted this change and it was merged. Change subject: Avoid remove temp files of pipeline plugin ...................................................................... Avoid remove temp files of pipeline plugin Looks like the pipelien plugin keeps temp files in the "$WORKSPACE@tmp" directory, we need to make sure not to remove it. Change-Id: I8cd4c192cb3ca9260dd7462df8fe5e064aa9a02f Signed-off-by: Barak Korren <bkorren(a)redhat.com> --- M jobs/confs/shell-scripts/cleanup_slave.sh 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Eyal Edri: Looks good to me, approved; Ready for merge Barak Korren: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/72107 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8cd4c192cb3ca9260dd7462df8fe5e064aa9a02f Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <david(a)dcaro.es> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Pavel Zhukov <pavel(a)zhukoff.net> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: webadmin: scsi dialog - adjust tabs text location
by Code Review 12 Feb '17

12 Feb '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: webadmin: scsi dialog - adjust tabs text location ...................................................................... webadmin: scsi dialog - adjust tabs text location Storage dialog -> SCSI -> Tabs: adjusted text location in the tab. Before: http://imgur.com/a/YbJ9Q After: http://imgur.com/a/N1ZrJ Change-Id: Ie2afc2e997b00108f8e7b8e6cf7baf3dee46e660 Bug-Url: https://bugzilla.redhat.com/1420821 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/IscsiStorageView.ui.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Daniel Erez: Verified -- To view, visit https://gerrit.ovirt.org/72033 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie2afc2e997b00108f8e7b8e6cf7baf3dee46e660 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: webadmin: interface in DisksTree and StoragesTree
by Code Review 12 Feb '17

12 Feb '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: webadmin: interface in DisksTree and StoragesTree ...................................................................... webadmin: interface in DisksTree and StoragesTree Added interface column in disk table (in Templates -> Storage / Disks sub-tabs). Currently, only the Interface column title is displayed: http://imgur.com/a/CeYlV Change-Id: Id9643b2eeae59a7c773c80e9657db96d4aec6d48 Bug-Url: https://bugzilla.redhat.com/1420816 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/template/DisksTree.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/template/StoragesTree.java 2 files changed, 4 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Daniel Erez: Verified -- To view, visit https://gerrit.ovirt.org/72031 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id9643b2eeae59a7c773c80e9657db96d4aec6d48 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: webadmin: Fix iSCSI domain layout
by Code Review 12 Feb '17

12 Feb '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Fix iSCSI domain layout ...................................................................... webadmin: Fix iSCSI domain layout - Switching the iSCSI layout to bootstrap I removed a litte too much css which caused the tabs to be wrong. This patch fixes that change. Change-Id: I401bee2e28bda0e4e84165465135247e196cae06 Bug-Url: https://bugzilla.redhat.com/1420821 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/tab/DialogTabPanel.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/IscsiStorageView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/StoragePopupView.ui.xml 3 files changed, 43 insertions(+), 12 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Daniel Erez: Verified -- To view, visit https://gerrit.ovirt.org/72032 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I401bee2e28bda0e4e84165465135247e196cae06 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: update DiskVmElements on getTemplateDisks
by Code Review 12 Feb '17

12 Feb '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: update DiskVmElements on getTemplateDisks ...................................................................... core: update DiskVmElements on getTemplateDisks GetVmTemplatesDisksQuery: Update DiskVmElements on getTemplateDisks method, so GetStorageDomainsByVmTemplateIdQuery would return updated disk. Needed for interface column in 'Storage -> Templates' sub-tab and for extended tab in the UserPortal (TemplateDiskListModelTable). Current view with missing interface value: http://imgur.com/a/CeYlV Change-Id: I6185232775771dccea732f22fd318747b436993f Bug-Url: https://bugzilla.redhat.com/1420816 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/GetVmTemplatesDisksQuery.java 1 file changed, 3 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Daniel Erez: Verified -- To view, visit https://gerrit.ovirt.org/72030 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6185232775771dccea732f22fd318747b436993f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: webadmin: directlun disk dialog - missing host label
by Code Review 12 Feb '17

12 Feb '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: webadmin: directlun disk dialog - missing host label ...................................................................... webadmin: directlun disk dialog - missing host label Added missing 'Use host' label on new disk dialog (DirectLUN tab). Change-Id: I55fba202912d8a604e18a6e0cfa4bc1959277aa4 Bug-Url: https://bugzilla.redhat.com/1420812 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.ui.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Daniel Erez: Verified -- To view, visit https://gerrit.ovirt.org/72029 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I55fba202912d8a604e18a6e0cfa4bc1959277aa4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: webadmin: clean ReadOnlyDiskModel for upload image
by Code Review 12 Feb '17

12 Feb '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: webadmin: clean ReadOnlyDiskModel for upload image ...................................................................... webadmin: clean ReadOnlyDiskModel for upload image ReadOnlyDiskModel is used only for UploadImageModel, hence, removing any irrelevant logic. Change-Id: Idfae91f31427f7e9476336cec5be7d2359738901 Bug-Url: https://bugzilla.redhat.com/1419853 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ReadOnlyDiskModel.java 2 files changed, 5 insertions(+), 70 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Daniel Erez: Verified -- To view, visit https://gerrit.ovirt.org/72027 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idfae91f31427f7e9476336cec5be7d2359738901 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: webadmin: upload image dialog - use host select-box
by Code Review 12 Feb '17

12 Feb '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: webadmin: upload image dialog - use host select-box ...................................................................... webadmin: upload image dialog - use host select-box Added 'Use Host' select-box on upload image dialog. Change-Id: I42f992afa6f5d9bf94c9caed8a7d33eb3cfc012b Bug-Url: https://bugzilla.redhat.com/1419853 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/UploadImageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/UploadImagePopupView.ui.xml 3 files changed, 23 insertions(+), 5 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Daniel Erez: Verified -- To view, visit https://gerrit.ovirt.org/72028 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I42f992afa6f5d9bf94c9caed8a7d33eb3cfc012b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0