February 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: optimize validation in create vm
by Code Review 07 Feb '17

07 Feb '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: optimize validation in create vm ...................................................................... core: optimize validation in create vm The validation of whether or not the VM is already being initialized is done by using Set#contains of ResourceManager#asyncRunningVms. This patch replaces this with a check of the returned value of Set#add. Change-Id: I60adf9e50c5b74ad43d6cefdbf534e39e6e3da4f Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/CreateVDSCommand.java 1 file changed, 31 insertions(+), 38 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Shmuel Leib Melamud: Looks good to me, but someone else must approve Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/71703 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I60adf9e50c5b74ad43d6cefdbf534e39e6e3da4f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[sdk_4.1]: Automatically generate 'version.py'
by Code Review 07 Feb '17

07 Feb '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Automatically generate 'version.py' ...................................................................... Automatically generate 'version.py' Currently the 'version.py' file is updated manually with each release of the project, and it needs to be in sync with the version specified in the POM files. To avoid that this patch changes the SDK so that the 'version.py' file is atumatically generated, taking the version number from the root POM file. Change-Id: Ib9d5dce6b48c2e6c1a3dcc43fa17204c88096632 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M .gitignore M generator/src/main/java/org/ovirt/sdk/python/PythonBuffer.java M generator/src/main/java/org/ovirt/sdk/python/PythonNames.java M generator/src/main/java/org/ovirt/sdk/python/Tool.java A generator/src/main/java/org/ovirt/sdk/python/VersionGenerator.java D sdk/lib/ovirtsdk4/version.py M sdk/pom.xml M sdk/setup.py 8 files changed, 150 insertions(+), 37 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/71790 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib9d5dce6b48c2e6c1a3dcc43fa17204c88096632 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_4.1 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[master]: Automatically generate 'version.py'
by Code Review 07 Feb '17

07 Feb '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Automatically generate 'version.py' ...................................................................... Automatically generate 'version.py' Currently the 'version.py' file is updated manually with each release of the project, and it needs to be in sync with the version specified in the POM files. To avoid that this patch changes the SDK so that the 'version.py' file is atumatically generated, taking the version number from the root POM file. Change-Id: Ib9d5dce6b48c2e6c1a3dcc43fa17204c88096632 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M .gitignore M generator/src/main/java/org/ovirt/sdk/python/PythonBuffer.java M generator/src/main/java/org/ovirt/sdk/python/PythonNames.java M generator/src/main/java/org/ovirt/sdk/python/Tool.java A generator/src/main/java/org/ovirt/sdk/python/VersionGenerator.java D sdk/lib/ovirtsdk4/version.py M sdk/pom.xml M sdk/setup.py 8 files changed, 150 insertions(+), 37 deletions(-) Approvals: Ondra Machacek: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/71779 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib9d5dce6b48c2e6c1a3dcc43fa17204c88096632 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in otopi[master]: packaging: Install vdsm-client instead of vdsm-cli
by Code Review 07 Feb '17

07 Feb '17

>From Yedidyah Bar David <didi(a)redhat.com>: Yedidyah Bar David has submitted this change and it was merged. Change subject: packaging: Install vdsm-client instead of vdsm-cli ...................................................................... packaging: Install vdsm-client instead of vdsm-cli Patch I23b6b5efc45f05cb299043bd04fad99cfbe35bdd removed vdsm-cli, but new client is included in vdsm-client package, so we should add it instead of only removal of the old client. Change-Id: Idcb632ae3f16284195603cd15051b5391140df08 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M src/otopi/miniyum.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Martin Peřina: Verified Jenkins CI: Passed CI tests Irit Goihman: Looks good to me, but someone else must approve Yedidyah Bar David: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/71234 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idcb632ae3f16284195603cd15051b5391140df08 Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: make the generated domxml host agnostic
by Code Review 07 Feb '17

07 Feb '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: make the generated domxml host agnostic ...................................................................... core: make the generated domxml host agnostic In principle, we do not want the domxml to contain host-specific information. This kind of data should be replaced by VDSM. Change-Id: I9c5eb61a0894c2fa01e27e101db8400878e74016 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/LibvirtVmXmlBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CreateBrokerVDSCommand.java 2 files changed, 18 insertions(+), 28 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/71771 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9c5eb61a0894c2fa01e27e101db8400878e74016 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: LiveMigrateDiskCommand labmda
by Code Review 07 Feb '17

07 Feb '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: LiveMigrateDiskCommand labmda ...................................................................... core: LiveMigrateDiskCommand labmda Replace an anonymous implementation of a TansactionMethod with a simpler lambda in order to make the code shorter and more concise. Change-Id: I7ddf05c0e9a539cdd899de8b99869ad9a7d22f9b Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/lsm/LiveMigrateDiskCommand.java 1 file changed, 17 insertions(+), 23 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/71742 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7ddf05c0e9a539cdd899de8b99869ad9a7d22f9b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: droping ovirt-guest-agent jobs for 3.6 & 4.0
by Code Review 07 Feb '17

07 Feb '17

>From Eyal Edri <eedri(a)redhat.com>: Eyal Edri has submitted this change and it was merged. Change subject: droping ovirt-guest-agent jobs for 3.6 & 4.0 ...................................................................... droping ovirt-guest-agent jobs for 3.6 & 4.0 3.6 & 4.0 is EOL also dropped them from the nightly publishers Change-Id: If3420c3742d5840d942a5578e2e5b8b4e042e803 Signed-off-by: Eyal Edri <eedri(a)redhat.com> --- M jobs/confs/projects/ovirt-guest-agent/ovirt-guest-agent_standard.yaml M jobs/confs/projects/ovirt/publish-rpms-nightly-3.6.yaml M jobs/confs/projects/ovirt/publish-rpms-nightly-4.0.yaml 3 files changed, 0 insertions(+), 16 deletions(-) Approvals: Sandro Bonazzola: Looks good to me Eyal Edri: Verified; Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me -- To view, visit https://gerrit.ovirt.org/71782 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If3420c3742d5840d942a5578e2e5b8b4e042e803 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Gluster alert in installing state
by Code Review 07 Feb '17

07 Feb '17

>From Sahina Bose <sabose(a)redhat.com>: Sahina Bose has submitted this change and it was merged. Change subject: webadmin: Gluster alert in installing state ...................................................................... webadmin: Gluster alert in installing state Do not show peer disconnected status alert in installing states Change-Id: I4f24e955d682b359b26524bd5e1f6296ab099aaf Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Sahina Bose: Verified; Looks good to me, approved Ramesh N: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/65953 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4f24e955d682b359b26524bd5e1f6296ab099aaf Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: remove another redundant legacy check in create vm
by Code Review 07 Feb '17

07 Feb '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: remove another redundant legacy check in create vm ...................................................................... core: remove another redundant legacy check in create vm In RunVm we validate that the VM is not during snapshot (that is, that no snapshot is locked) while the VM is locked and then we check it again in the create VDS command. The latter check is redundant since every time that we lock a snapshot (and specifically the active snapshot) we do it while the VM is locked. In addition, removing unused method in SnapshotsManager. Change-Id: I05d8a28e462ff942370fa21477f4524c246daff2 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/CreateVDSCommand.java 2 files changed, 0 insertions(+), 44 deletions(-) Approvals: Jenkins CI: Passed CI tests Maor Lipchuk: Looks good to me, approved Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/71702 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I05d8a28e462ff942370fa21477f4524c246daff2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: vdsm: remove fc25 jobs from 4.1
by Code Review 07 Feb '17

07 Feb '17

>From Eyal Edri <eedri(a)redhat.com>: Eyal Edri has submitted this change and it was merged. Change subject: vdsm: remove fc25 jobs from 4.1 ...................................................................... vdsm: remove fc25 jobs from 4.1 fc25 isn't supported on 4.1 and supporting it requires too many changes to the already-released 4.1.0. Change-Id: I439ab9a93041cbb8a068282d8dd1d02ab42035d6 Signed-off-by: Irit Goihman <igoihman(a)redhat.com> --- M jobs/confs/projects/vdsm/vdsm_standard.yaml 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Eyal Edri: Verified; Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/71755 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I439ab9a93041cbb8a068282d8dd1d02ab42035d6 Gerrit-PatchSet: 4 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0