February 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-4.1]: core: Sorting by multiple db columns
by Code Review 06 Feb '17

06 Feb '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Sorting by multiple db columns ...................................................................... core: Sorting by multiple db columns Backend sorting infrastructure altered in order to be able to sort by multiple expressions (usually db columns). Each UI column may be mapped to one or more such expressions (represented by class SyntaxChecker.SortByElement) that are later transformed to on SQL 'ORDER BY' clause. Change-Id: I9dc9d50dc9892dfa628b547b15aa7abc1cb81a3e Bug-Url: https://bugzilla.redhat.com/1273825 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/BaseConditionFieldAutoCompleter.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/IConditionFieldAutoCompleter.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VmConditionFieldAutoCompleter.java M backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/SyntaxCheckerTest.java 5 files changed, 73 insertions(+), 12 deletions(-) Approvals: Jakub Niedermertl: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/71512 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9dc9d50dc9892dfa628b547b15aa7abc1cb81a3e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: Template sorting improved
by Code Review 06 Feb '17

06 Feb '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Template sorting improved ...................................................................... core: Template sorting improved * Sorting by Name column means: sort by name, version name, version number. Version name value 'base version' is interpreted as NULL. * Sorting by Version column is completely disabled. Change-Id: If6a6fc1ad0aa3a75eae925d2cc480593b881c7d0 Bug-Url: https://bugzilla.redhat.com/1273825 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VmTemplateConditionFieldAutoCompleter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabTemplateView.java 2 files changed, 8 insertions(+), 2 deletions(-) Approvals: Jakub Niedermertl: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/71513 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If6a6fc1ad0aa3a75eae925d2cc480593b881c7d0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: add ui logic to WAD-EnableDiscard relationship
by Code Review 06 Feb '17

06 Feb '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: webadmin: add ui logic to WAD-EnableDiscard relationship ...................................................................... webadmin: add ui logic to WAD-EnableDiscard relationship Previously, the user could tick the wipe after delete and enable discard checkboxes as he wished, and only after the ok button was clicked and the request was sent to the backend, an error would have raised in case of an illegal configuration and the user didn't have a chance to fix it since the popup was closed. This patch adds the same backend logic of enable discard and its relationship with wipe after delete to the ui in order to save the user from disappointing after finding out about the wrong configuration too late. For more information about enable discard and its relationship with wipe after delete, please refer to the feature page: http://www.ovirt.org/develop/release-management/features/storage/pass-disca… Change-Id: I912ae85e5d6dfa7bd5aad17d41d0e051e78f457e Bug-Url: https://bugzilla.redhat.com/1414126 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/EditDiskModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewDiskModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants.properties 6 files changed, 88 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/71278 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I912ae85e5d6dfa7bd5aad17d41d0e051e78f457e Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: more efficient identification of run-once vms
by Code Review 06 Feb '17

06 Feb '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: more efficient identification of run-once vms ...................................................................... core: more efficient identification of run-once vms When a VM goes down we check if it ran in run-once mode in order to see if we need to remove its unmanaged devices. We used to do that by checking the number of cd-rom/floppy devices although since 3.3 we have a dedicated flag for that. So from now on we use this flag instead. Change-Id: Ib5f2b69680f5cef02c23f8b5d38df4fae581aa49 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ProcessDownVmCommand.java 1 file changed, 1 insertion(+), 18 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/71680 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib5f2b69680f5cef02c23f8b5d38df4fae581aa49 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: remove unmanaged vm devices in batch
by Code Review 06 Feb '17

06 Feb '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: remove unmanaged vm devices in batch ...................................................................... core: remove unmanaged vm devices in batch When stateless VM or VM that was running in run-once mode goes down, we now remove its unmanaged devices in a batch. Change-Id: I4e26c3182ed0eb5de1f0e9f0a377c63029b3a650 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ProcessDownVmCommand.java 1 file changed, 6 insertions(+), 8 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/71679 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4e26c3182ed0eb5de1f0e9f0a377c63029b3a650 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Add console device
by Code Review 06 Feb '17

06 Feb '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: Add console device ...................................................................... core: Add console device Add console device when importing hosted engine VM. Previously the device was ignored, not registered in the engine and not written to the ovf which caused the console commands to fail. Change-Id: Ia1cddaa7396f1abb160a49e79afe3e17b608dddc Bug-Url: https://bugzilla.redhat.com/1364132 Signed-off-by: Jenny Tokar <jtokar(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddUnmanagedVmsCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddUnmanagedVmsCommandTest.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmDevicesMonitoring.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 4 files changed, 55 insertions(+), 7 deletions(-) Approvals: Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved Jenny Tokar: Verified -- To view, visit https://gerrit.ovirt.org/70594 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia1cddaa7396f1abb160a49e79afe3e17b608dddc Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Added try and catch on all main
by Code Review 06 Feb '17

06 Feb '17

>From Gil Shinar <gshinar(a)redhat.com>: Gil Shinar has submitted this change and it was merged. Change subject: Added try and catch on all main ...................................................................... Added try and catch on all main Added try and catch + finally on all main function's code to be able to send email in all scenarios. Email send will be inside the finally section Change-Id: Iffc952072964cb543a9d95bf1123ca3163c97ec5 Signed-off-by: Gil Shinar <gshinar(a)redhat.com> --- M jobs/confs/groovy-scripts/test-ovirt-repo.groovy 1 file changed, 30 insertions(+), 24 deletions(-) Approvals: Gil Shinar: Verified; Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/67928 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iffc952072964cb543a9d95bf1123ca3163c97ec5 Gerrit-PatchSet: 6 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gal Ben Haim <galbh2(a)gmail.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: Avoid NPE when importing unregistered Template.
by Code Review 06 Feb '17

06 Feb '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Avoid NPE when importing unregistered Template. ...................................................................... core: Avoid NPE when importing unregistered Template. When importing an unregistered Template the initialization of this Template is being done only in the validate method since it includes several DB calls and OVF parsing. Since the init function of ImportVmTemplateFromConfigurationCommand executes updateMaxMemorySize which uses getVmTemplate() we get an NPE and fail to register an unregistered Template. The following fix uses the same technique which is used for updateGraphicsDevices by checking if the vmBase is null, and if so simply return. Change-Id: If13d8aa654e72569d02cc18e91f19d4af7445ac7 Bug-Url: https://bugzilla.redhat.com/1419364 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Maor Lipchuk: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/71691 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If13d8aa654e72569d02cc18e91f19d4af7445ac7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Avoid NPE when importing unregistered Template.
by Code Review 06 Feb '17

06 Feb '17

>From Maor Lipchuk <mlipchuk(a)redhat.com>: Maor Lipchuk has submitted this change and it was merged. Change subject: core: Avoid NPE when importing unregistered Template. ...................................................................... core: Avoid NPE when importing unregistered Template. When importing an unregistered Template the initialization of this Template is being done only in the validate method since it includes several DB calls and OVF parsing. Since the init function of ImportVmTemplateFromConfigurationCommand executes updateMaxMemorySize which uses getVmTemplate() we get an NPE and fail to register an unregistered Template. The following fix uses the same technique which is used for updateGraphicsDevices by checking if the vmBase is null, and if so simply return. Change-Id: If13d8aa654e72569d02cc18e91f19d4af7445ac7 Bug-Url: https://bugzilla.redhat.com/1419364 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Maor Lipchuk: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/71688 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If13d8aa654e72569d02cc18e91f19d4af7445ac7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: cockpit-ovirt: drop unsupported versions
by Code Review 06 Feb '17

06 Feb '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: cockpit-ovirt: drop unsupported versions ...................................................................... cockpit-ovirt: drop unsupported versions - drop 3.6 builds being 3.6 unsupported - keep EL7 only on 4.0, being fc23 EOL Change-Id: I064ef408addc37a46e53d6e6fb51741be24ed2fd Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/projects/cockpit-ovirt/cockpit-ovirt.yaml M jobs/confs/projects/ovirt/publish-rpms-nightly-3.6.yaml 2 files changed, 0 insertions(+), 25 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests Ryan Barry: Looks good to me -- To view, visit https://gerrit.ovirt.org/71287 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I064ef408addc37a46e53d6e6fb51741be24ed2fd Gerrit-PatchSet: 5 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Ryan Barry <rbarry(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0