March 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: InforServiceImpl#Logic anonymous lambdas
by Code Review 28 Mar '17

28 Mar '17

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: core: InforServiceImpl#Logic anonymous lambdas ...................................................................... core: InforServiceImpl#Logic anonymous lambdas Replace implementations of InforServiceImpl#Logic with anonymous lambdas, as per the project's standards, to reduce code bloating and improve readability. Change-Id: I95919313cac026a6b7c428c0b5e21a9a182c0d3d Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/extensions-tool/src/main/java/org/ovirt/engine/exttool/core/InfoServiceImpl.java 1 file changed, 78 insertions(+), 86 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/74723 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I95919313cac026a6b7c428c0b5e21a9a182c0d3d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: InformationServiceImpl type inference
by Code Review 28 Mar '17

28 Mar '17

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: core: InformationServiceImpl type inference ...................................................................... core: InformationServiceImpl type inference Change-Id: I39bf7dbfdba0f1f45ea672730eb40a3d04794e7e Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/extensions-tool/src/main/java/org/ovirt/engine/exttool/core/InfoServiceImpl.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/74721 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I39bf7dbfdba0f1f45ea672730eb40a3d04794e7e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: InformationServiceImpl imports
by Code Review 28 Mar '17

28 Mar '17

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: core: InformationServiceImpl imports ...................................................................... core: InformationServiceImpl imports Replace fully qualified class name with an import, as per the project's standards. Change-Id: I4b58be374ac6d1c757ad56b2db2077d10515c87c Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/extensions-tool/src/main/java/org/ovirt/engine/exttool/core/InfoServiceImpl.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/74722 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4b58be374ac6d1c757ad56b2db2077d10515c87c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: CLUSTER_ADMIN role misses ActionGroup CONFIGURE_MAC_POOL
by Code Review 28 Mar '17

28 Mar '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: CLUSTER_ADMIN role misses ActionGroup CONFIGURE_MAC_POOL ...................................................................... core: CLUSTER_ADMIN role misses ActionGroup CONFIGURE_MAC_POOL Change-Id: If690d8d6dac125297b5e0597441c289be138b06c Bug-Url: https://bugzilla.redhat.com/1428754 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- A packaging/dbscripts/upgrade/04_01_0780_add_configure_mac_pool_role_to_data_center_admin.sql 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Martin Mucha: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/74332 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If690d8d6dac125297b5e0597441c289be138b06c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: packaging: Extract the value correctly from postgresql.conf
by Code Review 28 Mar '17

28 Mar '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: packaging: Extract the value correctly from postgresql.conf ...................................................................... packaging: Extract the value correctly from postgresql.conf Motivation: Updating postgres.conf using setup plugin fails to catch floating point changes The root cause it the regular expression that extracts a key=value and for comparison Change: The regexp is change to take every char till end of line as value. Result: Instead of extracting 0 for 0.5 it now extracts correctly. Floating points and all other values are extracted correctly. Change-Id: I6db33a9d7bd3e87d537fd03d5032bf73fa844dd7 Bug-Url: https://bugzilla.redhat.com/1388433 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/engine_common/database.py 1 file changed, 13 insertions(+), 14 deletions(-) Approvals: Tal Nisan: Passed CI tests Sandro Bonazzola: Looks good to me, approved Roy Golan: Verified -- To view, visit https://gerrit.ovirt.org/74573 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6db33a9d7bd3e87d537fd03d5032bf73fa844dd7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: minor refactoring in run-vm
by Code Review 28 Mar '17

28 Mar '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: minor refactoring in run-vm ...................................................................... core: minor refactoring in run-vm Extract the logic for matching the cluster's emulated machine with those set for a VM's custom compatibility version into a separate method. Change-Id: I8d9f90baef72fee807d91c5e418e9824f627a8aa Bug-Url: https://bugzilla.redhat.com/1436325 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java 1 file changed, 20 insertions(+), 8 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Marek Libra: Looks good to me, but someone else must approve Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/74708 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8d9f90baef72fee807d91c5e418e9824f627a8aa Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: ovirt-provider-ovn setup
by Code Review 28 Mar '17

28 Mar '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: ovirt-provider-ovn setup ...................................................................... packaging: ovirt-provider-ovn setup Plugin for configuring ovirt-provider-ovn - installs ovs/ovn packages - installs the provider package - adds a default provider to the DB, asking the user for the provider credentials - saves the relevant values in the answer file Firewalld setup will be added in another patch. Change-Id: I9b9faa27d387cd1d896d159024bd2e0aefa5f703 Signed-off-by: Marcin Mirecki<mmirecki(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1436154 --- M packaging/setup/ovirt_engine_setup/engine/constants.py A packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/network/__init__.py A packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/network/ovirtproviderovn.py 3 files changed, 306 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Marcin Mirecki: Verified Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/73871 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9b9faa27d387cd1d896d159024bd2e0aefa5f703 Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Yuval Turgeman <yturgema(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: frontend: Remove unused FormatterDotnet
by Code Review 27 Mar '17

27 Mar '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: frontend: Remove unused FormatterDotnet ...................................................................... frontend: Remove unused FormatterDotnet Change-Id: I1e8d0544b39ab9544fb86d280ece5dfbb0608345 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- D frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/org/ovirt/engine/core/compat/FormatterDotnet.java 1 file changed, 0 insertions(+), 76 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve Greg Sheremeta: Looks good to me, approved Vojtech Szocs: Verified -- To view, visit https://gerrit.ovirt.org/74713 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1e8d0544b39ab9544fb86d280ece5dfbb0608345 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: frontend: Fix Checkstyle (NlsCheck) related issues
by Code Review 27 Mar '17

27 Mar '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: frontend: Fix Checkstyle (NlsCheck) related issues ...................................................................... frontend: Fix Checkstyle (NlsCheck) related issues - NlsCheck no longer crashes on NumberFormatException when the non-localized string contains "{}" (making the Checkstyle think it's a log message placeholder) - when debugging GWT applications, disable NlsCheck as we tell build-helper-maven-plugin to add extra Java sources and some of them aren't meant to be checked, like the gwt-extension module Change-Id: I39d9343e9e06673a1ec30c7e10241d689298770c Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M build-tools-root/ovirt-checkstyle-extension/src/main/java/org/ovirt/checkstyle/checks/NlsCheck.java M frontend/webadmin/modules/userportal-gwtp/pom.xml M frontend/webadmin/modules/webadmin/pom.xml 3 files changed, 21 insertions(+), 3 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/74611 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I39d9343e9e06673a1ec30c7e10241d689298770c Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: aaa: RestAPI connection fail after time change
by Code Review 27 Mar '17

27 Mar '17

>From Martin Peřina <mperina(a)redhat.com>: Martin Peřina has submitted this change and it was merged. Change subject: aaa: RestAPI connection fail after time change ...................................................................... aaa: RestAPI connection fail after time change Any failure to cleanup SsoSession due to callback notification service unavailability or authentication domain unavailability should log the error and continue with the flow. Change-Id: Ia8b685fbd2a62854befd4fce1882f28a85c53252 Bug-Url: https://bugzilla.redhat.com/1434326 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/TokenCleanupUtility.java 1 file changed, 17 insertions(+), 12 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Ravi Nori: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/74706 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia8b685fbd2a62854befd4fce1882f28a85c53252 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0