April 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Remove unused AsyncQuery methods
by Code Review 23 Apr '17

23 Apr '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: Remove unused AsyncQuery methods ...................................................................... webadmin: Remove unused AsyncQuery methods Change-Id: I572dd1169d98a1b125530f929a22404baf12214b Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AsyncQuery.java 1 file changed, 0 insertions(+), 10 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/75757 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I572dd1169d98a1b125530f929a22404baf12214b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Inline CastingConverter
by Code Review 23 Apr '17

23 Apr '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: Inline CastingConverter ...................................................................... webadmin: Inline CastingConverter The last remaining usage of CastingConverter was in the DefaultValueConverter that extends it. Since there's no use of the CastingConverter, this patch inlines its implementation to the DefaultValueConverter. Change-Id: I039f760e5c935a7600286893b00a3004c2444217 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java 1 file changed, 2 insertions(+), 10 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/75760 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I039f760e5c935a7600286893b00a3004c2444217 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Further generalize Converter
by Code Review 23 Apr '17

23 Apr '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: Further generalize Converter ...................................................................... webadmin: Further generalize Converter This patch makes Converter's source type generic too in order to save boiler-plate casts and to better take advantage of Java 8's type inference. Change-Id: Ia5ffc193cb8cadeb209d8d46fb520bc1a62511fb Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AsyncQuery.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Converter.java M frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/FrontendTest.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java 4 files changed, 39 insertions(+), 41 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/75758 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia5ffc193cb8cadeb209d8d46fb520bc1a62511fb Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Remove CastingConverter usages
by Code Review 23 Apr '17

23 Apr '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: Remove CastingConverter usages ...................................................................... webadmin: Remove CastingConverter usages CastingConverter does change the source's value, it just [down]casts it, making it a compilation-only entity. Since the frontend supports Java 8's type inference, this is pretty much a mute point, and these usages can be removed. Change-Id: I418aa0903a5f74d43655f2ed76ce3410d604ec95 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java 1 file changed, 0 insertions(+), 38 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/75759 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I418aa0903a5f74d43655f2ed76ce3410d604ec95 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: ReduceSANStorageDomainDevicesCommand parenthesis
by Code Review 23 Apr '17

23 Apr '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: ReduceSANStorageDomainDevicesCommand parenthesis ...................................................................... core: ReduceSANStorageDomainDevicesCommand parenthesis Removed redundant parenthesis that don't contribute anything to the class' readability. Change-Id: I05f60a80644dacd9a7efec399561651cbcc50497 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/ReduceSANStorageDomainDevicesCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/75682 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I05f60a80644dacd9a7efec399561651cbcc50497 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: ReduceSANStorageDomainDevicesCommand validation order
by Code Review 23 Apr '17

23 Apr '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: ReduceSANStorageDomainDevicesCommand validation order ...................................................................... core: ReduceSANStorageDomainDevicesCommand validation order Change the order of ReduceSANStorageDomainDevicesCommand#validate() so that the domain's storage type is validated before its version. This makes sense since a user could potentially handle the domain's version (by upgrading the DC), but can't change the underlying storage type. Change-Id: I3d395a8994705ed401f52827a39c648a15ca7744 Bug-Url: https://bugzilla.redhat.com/1443920 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/ReduceSANStorageDomainDevicesCommand.java 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/75683 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3d395a8994705ed401f52827a39c648a15ca7744 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin, userportal: Make Bootstrap dialogs draggable
by Code Review 23 Apr '17

23 Apr '17

>From Greg Sheremeta <gshereme(a)redhat.com>: Greg Sheremeta has submitted this change and it was merged. Change subject: webadmin,userportal: Make Bootstrap dialogs draggable ...................................................................... webadmin,userportal: Make Bootstrap dialogs draggable - add jQuery UI dependency (needed for $.draggable) - in SimpleDialogPanel, add DOM attach/detach handler that makes the whole dialog draggable by its header Change-Id: Ib1d09b8f77cf7db9d358c272aca39b9d972f6663 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M backend/manager/modules/branding/src/main/resources/META-INF/tags/obrand/javascripts.tag M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/SimpleDialogPanel.java 2 files changed, 16 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Greg Sheremeta: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/74616 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib1d09b8f77cf7db9d358c272aca39b9d972f6663 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Removed 3.6 system tests jobs as we dont have the correspond...
by Code Review 23 Apr '17

23 Apr '17

>From Eyal Edri <eedri(a)redhat.com>: Eyal Edri has submitted this change and it was merged. Change subject: Removed 3.6 system tests jobs as we dont have the corresponding repos ...................................................................... Removed 3.6 system tests jobs as we dont have the corresponding repos Change-Id: Iac13a95d0d4f4cf13a3dfb817aac15b1f173878a Signed-off-by: Daniel Belenky <dbelenky(a)redhat.com> --- M jobs/confs/projects/ovirt/deploy_to_experimental.yaml M jobs/confs/projects/ovirt/system-tests.yaml M jobs/confs/projects/ovirt/test-experimental-latest-repo.yaml 3 files changed, 0 insertions(+), 7 deletions(-) Approvals: Eyal Edri: Looks good to me, approved; Ready for merge Daniel Belenky: Verified; Passed CI tests; Ready for review Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/75812 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iac13a95d0d4f4cf13a3dfb817aac15b1f173878a Gerrit-PatchSet: 3 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fix snapshot preview creating duplicate disks
by Code Review 23 Apr '17

23 Apr '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: Fix snapshot preview creating duplicate disks ...................................................................... core: Fix snapshot preview creating duplicate disks Change-Id: I1acff80e407733f440e81dcbff5151881a15b9ef Bug-Url: https://bugzilla.redhat.com/1441858 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/75830 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1acff80e407733f440e81dcbff5151881a15b9ef Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: engine: ignore NetworkCluster.status in the input
by Code Review 23 Apr '17

23 Apr '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: engine: ignore NetworkCluster.status in the input ...................................................................... engine: ignore NetworkCluster.status in the input Ignore status in the input of UpdateNetworkOnClusterCommand. Change-Id: I63c0c3468844fe07bc9947fe6c38f6632e478798 Bug-Url: https://bugzilla.redhat.com/1438418 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> (cherry picked from commit f8e6065d01233b34bfc334fab9c08c544d8c2bfb) --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/UpdateNetworkOnClusterCommand.java 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/75826 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I63c0c3468844fe07bc9947fe6c38f6632e478798 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0