April 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-4.1]: core: Use specified port when fetching SSH fingerprint
by Code Review 18 Apr '17

18 Apr '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Use specified port when fetching SSH fingerprint ...................................................................... core: Use specified port when fetching SSH fingerprint Uses port specified by user when trying to fetch fingerprint from SSH server. Change-Id: I793dc037cf90b161ecc56370dbf19469c95e8171 Bug-Url: https://bugzilla.redhat.com/1433977 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetServerSSHKeyFingerprintQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatic.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ServerParameters.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java 6 files changed, 31 insertions(+), 11 deletions(-) Approvals: Martin Peřina: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/75440 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I793dc037cf90b161ecc56370dbf19469c95e8171 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Added timeouts on access to mirrors server
by Code Review 18 Apr '17

18 Apr '17

>From Eyal Edri <eedri(a)redhat.com>: Eyal Edri has submitted this change and it was merged. Change subject: Added timeouts on access to mirrors server ...................................................................... Added timeouts on access to mirrors server Added falling back to not using mirrors when the access to the mirrors server times out. Formerly it was waiting forever. Also added some basic logging to functions in mirror_client.py and the code that is needed to enable it. Change-Id: I43e7f46861b80c80b1102f51b7a3574a38988a61 Signed-off-by: Barak Korren <bkorren(a)redhat.com> Jira-Ticket: https://ovirt-jira.atlassian.net/browse/OVIRT-1301 --- M jobs/confs/groovy-scripts/test-ovirt-repo.groovy M jobs/confs/yaml/builders/system_tests_builders.yaml M scripts/mirror_client.py 3 files changed, 32 insertions(+), 5 deletions(-) Approvals: Sandro Bonazzola: Looks good to me Eyal Edri: Looks good to me, approved; Ready for merge Barak Korren: Verified; Ready for review Daniel Belenky: Looks good to me Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/75246 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I43e7f46861b80c80b1102f51b7a3574a38988a61 Gerrit-PatchSet: 3 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: scheduling: Improve logging for preferred hosts
by Code Review 18 Apr '17

18 Apr '17

>From Martin Sivák <msivak(a)redhat.com>: Martin Sivák has submitted this change and it was merged. Change subject: scheduling: Improve logging for preferred hosts ...................................................................... scheduling: Improve logging for preferred hosts We should make it more visible when a host is penalized during scheduling. There was a thread on mailing list where an user was confused, because he did not remember that the preferred hosts list was configured. Change-Id: I6afc5de5f16aeb36e4dc4b2638f30a86be87ddf5 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/PreferredHostsWeightPolicyUnit.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Martin Sivák: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Yanir Quinn: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/75496 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6afc5de5f16aeb36e4dc4b2638f30a86be87ddf5 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: github: use webhooks instead of polling
by Code Review 18 Apr '17

18 Apr '17

>From Eyal Edri <eedri(a)redhat.com>: Eyal Edri has submitted this change and it was merged. Change subject: github: use webhooks instead of polling ...................................................................... github: use webhooks instead of polling Verified for lago/ovirt-web-ui. Change-Id: If0c451b100756c2002c5b52acf2265508daa0cbb Signed-off-by: Nadav Goldin <ngoldin(a)redhat.com> --- M jobs/confs/yaml/triggers/github.yaml 1 file changed, 4 insertions(+), 6 deletions(-) Approvals: Nadav Goldin: Verified; Ready for review Eyal Edri: Looks good to me, approved; Ready for merge Gil Shinar: Looks good to me Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/75365 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If0c451b100756c2002c5b52acf2265508daa0cbb Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>

1 0

Change in ovirt-hosted-engine-ha[v2.1.z]: Add graphics device to the vm.conf
by Code Review 18 Apr '17

18 Apr '17

>From Martin Sivák <msivak(a)redhat.com>: Martin Sivák has submitted this change and it was merged. Change subject: Add graphics device to the vm.conf ...................................................................... Add graphics device to the vm.conf When an ovf file was converted to the vm.conf file the graphics device was not converted. If the vm was started with a vm.conf file that didn't contain the graphics device there was no option to connect to the graphical console from the engine. This patch fixes this behavior. Change-Id: I3f3c3f59a02a9e78baa894c2e4a668face0f64f4 Bug-Url: https://bugzilla.redhat.com/1441570 Signed-off-by: Jenny Tokar <jtokar(a)redhat.com> --- M ovirt_hosted_engine_ha/lib/ovf/ovf2VmParams.py M ovirt_hosted_engine_ha/lib/ovf/ovf2VmParams_test.py M ovirt_hosted_engine_ha/lib/ovf/ovf_test.xml M ovirt_hosted_engine_ha/lib/ovf/ovf_test_max_vcpu.xml 4 files changed, 37 insertions(+), 0 deletions(-) Approvals: Denis Chaplygin: Looks good to me, but someone else must approve Martin Sivák: Looks good to me, approved Jenkins CI: Passed CI tests Jenny Tokar: Verified -- To view, visit https://gerrit.ovirt.org/75523 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3f3c3f59a02a9e78baa894c2e4a668face0f64f4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: v2.1.z Gerrit-Owner: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-release[ovirt-4.1]: node: require cockpit-dashboard
by Code Review 18 Apr '17

18 Apr '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: node: require cockpit-dashboard ...................................................................... node: require cockpit-dashboard cockpit-135 no longer pulls cockpit-dashboard for dependencies. Pull it explicitly ourselves. Change-Id: I8a14b78810bd78bc051e4eb622dc333e25f0f13b Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1442335 Signed-off-by: Ryan Barry <rbarry(a)redhat.com> --- M ovirt-release41.spec.in 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/75537 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8a14b78810bd78bc051e4eb622dc333e25f0f13b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: ovirt-4.1 Gerrit-Owner: Ryan Barry <rbarry(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-release[master]: node: require cockpit-dashboard
by Code Review 18 Apr '17

18 Apr '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: node: require cockpit-dashboard ...................................................................... node: require cockpit-dashboard cockpit-135 no longer pulls cockpit-dashboard for deps. Add it back explicitly ourselves. Change-Id: Iee1482de837ad88bebd6c8641673158e91486c75 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1442335 Signed-off-by: Ryan Barry <rbarry(a)redhat.com> --- M ovirt-release-master.spec.in 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/75536 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iee1482de837ad88bebd6c8641673158e91486c75 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: master Gerrit-Owner: Ryan Barry <rbarry(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Fix adding customized template with VM name
by Code Review 17 Apr '17

17 Apr '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Fix adding customized template with VM name ...................................................................... restapi: Fix adding customized template with VM name Currently when a template is added from a virtual machine specifying its name and customizing the disks, there is a NPE when trying to load the disks, because that part of the code assumes that the id of the VM has been provided by the user. This patch changes the code so that it uses the id of the VM retrieved from the database, instead of the id of the VM provided by the user. Change-Id: I9e549ca33333c5fab75980f09cec2ad6c835945e Bug-Url: https://bugzilla.redhat.com/1439970 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplatesResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTemplatesResourceTest.java 2 files changed, 48 insertions(+), 35 deletions(-) Approvals: Tomas Jelinek: Looks good to me, but someone else must approve Tal Nisan: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/75336 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9e549ca33333c5fab75980f09cec2ad6c835945e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: api: use the right timeout on python SDK
by Code Review 14 Apr '17

14 Apr '17

>From Simone Tiraboschi <stirabos(a)redhat.com>: Simone Tiraboschi has submitted this change and it was merged. Change subject: api: use the right timeout on python SDK ...................................................................... api: use the right timeout on python SDK Use a reasonable default timeout on python SDK. Retrying, with a limit, on errors since it could fail trying to connect while host-deploy is restarting the firewall. Change-Id: Icf600086ab6032327c14c1ccfaa05fabc009e91c Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1433718 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/ovirt_hosted_engine_setup/constants.py M src/ovirt_hosted_engine_setup/engineapi.py 2 files changed, 23 insertions(+), 10 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Simone Tiraboschi: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/74325 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icf600086ab6032327c14c1ccfaa05fabc009e91c Gerrit-PatchSet: 8 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: aaa: Running the command logon on the VM via the REST failed
by Code Review 14 Apr '17

14 Apr '17

>From Piotr Kliczewski <piotr.kliczewski(a)gmail.com>: Piotr Kliczewski has submitted this change and it was merged. Change subject: aaa: Running the command logon on the VM via the REST failed ...................................................................... aaa: Running the command logon on the VM via the REST failed Logon on VM using restapi needs password access scope dependency assigned to restapi scope. Change-Id: I80879311bc8d7c4d6ef5c656c6fb6a97c911b345 Bug-Url: https://bugzilla.redhat.com/1438484 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- A packaging/dbscripts/upgrade/04_01_0790_add_password_access_to_restapi_scope_dependency.sql 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Ravi Nori: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/75489 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I80879311bc8d7c4d6ef5c656c6fb6a97c911b345 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0