April 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-4.1]: restapi: Add 4.1 capabilities for api v3
by Code Review 11 Apr '17

11 Apr '17

>From Piotr Kliczewski <piotr.kliczewski(a)gmail.com>: Piotr Kliczewski has submitted this change and it was merged. Change subject: restapi: Add 4.1 capabilities for api v3 ...................................................................... restapi: Add 4.1 capabilities for api v3 Added 4.1 capabilities for restapi v3 because it didn't exist. Change-Id: I7c393a9e7c0c1b4d4932f15a43a985f6f940c897 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1439749 Signed-off-by: Aleksei Slaikovskii <aslaikov(a)redhat.com> (cherry picked from commit a2b9f2827108b7e6a07230b8b5a0aa05dbdeeae4) --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3CapabilitiesServer.java 1 file changed, 27 insertions(+), 13 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Jenkins CI: Passed CI tests Aleksei Slaikovskii: Verified -- To view, visit https://gerrit.ovirt.org/75432 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7c393a9e7c0c1b4d4932f15a43a985f6f940c897 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Aleksei Slaikovskii <aslaikov(a)redhat.com> Gerrit-Reviewer: Aleksei Slaikovskii <aslaikov(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: SsoUtils type inference
by Code Review 11 Apr '17

11 Apr '17

>From Martin Peřina <mperina(a)redhat.com>: Martin Peřina has submitted this change and it was merged. Change subject: core: SsoUtils type inference ...................................................................... core: SsoUtils type inference Change-Id: I61ccbf0442bd2c8f56893708e1fa8c8bdbf9454d Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SsoUtils.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/75423 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I61ccbf0442bd2c8f56893708e1fa8c8bdbf9454d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: SsoUtils collections
by Code Review 11 Apr '17

11 Apr '17

>From Martin Peřina <mperina(a)redhat.com>: Martin Peřina has submitted this change and it was merged. Change subject: core: SsoUtils collections ...................................................................... core: SsoUtils collections Use the built-in JWTClaimsSet.audience(String) method instead of redundantly wrapping the String in a List just to call JWTClaimsSet.audience(List<String>). Change-Id: Iff26d37f7390b2cfaa43c703d013fbab2263b0da Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SsoUtils.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/75424 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iff26d37f7390b2cfaa43c703d013fbab2263b0da Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: SsoUtils redundant parenthesis
by Code Review 11 Apr '17

11 Apr '17

>From Martin Peřina <mperina(a)redhat.com>: Martin Peřina has submitted this change and it was merged. Change subject: core: SsoUtils redundant parenthesis ...................................................................... core: SsoUtils redundant parenthesis Change-Id: Id1b857942f21356610d9721b1be4c136e1fd0c34 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SsoUtils.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/75425 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id1b857942f21356610d9721b1be4c136e1fd0c34 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Add 4.1 capabilities for api v3
by Code Review 11 Apr '17

11 Apr '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Add 4.1 capabilities for api v3 ...................................................................... restapi: Add 4.1 capabilities for api v3 Added 4.1 capabilities for restapi v3 because it didn't exist. Change-Id: I7c393a9e7c0c1b4d4932f15a43a985f6f940c897 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1439749 Signed-off-by: Aleksei Slaikovskii <aslaikov(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3CapabilitiesServer.java 1 file changed, 27 insertions(+), 13 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Jenkins CI: Passed CI tests Aleksei Slaikovskii: Verified -- To view, visit https://gerrit.ovirt.org/75309 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7c393a9e7c0c1b4d4932f15a43a985f6f940c897 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Aleksei Slaikovskii <aslaikov(a)redhat.com> Gerrit-Reviewer: Aleksei Slaikovskii <aslaikov(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: added possibility to add failing value to validation m...
by Code Review 11 Apr '17

11 Apr '17

>From Martin Peřina <mperina(a)redhat.com>: Martin Peřina has submitted this change and it was merged. Change subject: core: added possibility to add failing value to validation message ...................................................................... core: added possibility to add failing value to validation message in bean validation one should be able to add validated value into the custom interpolated message. It seems that our system does not support that, this patch allows to use variable ${validatedValue} as defined in bean validation. Change-Id: Ieedf167113a49437419e5c6c400fa16c46310074 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/ValidationUtils.java 1 file changed, 12 insertions(+), 5 deletions(-) Approvals: Martin Sivák: Looks good to me, but someone else must approve Martin Mucha: Verified Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/75156 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieedf167113a49437419e5c6c400fa16c46310074 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: CertificationValidityChecker indentation fix
by Code Review 11 Apr '17

11 Apr '17

>From Martin Peřina <mperina(a)redhat.com>: Martin Peřina has submitted this change and it was merged. Change subject: core: CertificationValidityChecker indentation fix ...................................................................... core: CertificationValidityChecker indentation fix Change-Id: I14f92d9fa09feed4f52e7e3d59086013b8f28625 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CertificationValidityChecker.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/75428 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I14f92d9fa09feed4f52e7e3d59086013b8f28625 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: CertificationValidityChecker host name logging
by Code Review 11 Apr '17

11 Apr '17

>From Martin Peřina <mperina(a)redhat.com>: Martin Peřina has submitted this change and it was merged. Change subject: core: CertificationValidityChecker host name logging ...................................................................... core: CertificationValidityChecker host name logging This patch avoids attempting to audit log the host's name when a host is not past (e.g., when the engine's certificate is checked). This patch solves Coverity CID 1373490. Change-Id: Ib2bd0048a44d9c31653fd0ad9d34c1ef5ffffaca Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CertificationValidityChecker.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/75429 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib2bd0048a44d9c31653fd0ad9d34c1ef5ffffaca Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: aaa: Add support for OpenId Connect password grant scope
by Code Review 11 Apr '17

11 Apr '17

>From Martin Peřina <mperina(a)redhat.com>: Martin Peřina has submitted this change and it was merged. Change subject: aaa: Add support for OpenId Connect password grant scope ...................................................................... aaa: Add support for OpenId Connect password grant scope Add support for OpenId password grant scope, so OpenShift can obtain token from oVirt Engine SSO from command line. Change-Id: I9c2d2a7e0e66dc39795299a364cf5b2e41bc745d Bug-Url: https://bugzilla.redhat.com/1416491 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/OAuthTokenServlet.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SsoUtils.java 2 files changed, 17 insertions(+), 2 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Ravi Nori: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/75414 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9c2d2a7e0e66dc39795299a364cf5b2e41bc745d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Expose `driver` field of host devices
by Code Review 10 Apr '17

10 Apr '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Expose `driver` field of host devices ...................................................................... restapi: Expose `driver` field of host devices Change-Id: I9dcdfa0b069655629ef0fae0959188631b2da9d2 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1430673 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostDeviceMapper.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Jenkins CI: Passed CI tests Martin Betak: Verified -- To view, visit https://gerrit.ovirt.org/74451 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9dcdfa0b069655629ef0fae0959188631b2da9d2 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0