April 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Use external providers trust store for neutron API
by Code Review 06 Apr '17

06 Apr '17

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: engine: Use external providers trust store for neutron API ...................................................................... engine: Use external providers trust store for neutron API Use the external providers trust store to connect to external network providers neutron API. This enables the usage of self signed certificates by external network providers neutron API, if the certificate of the external network provider, or its certification authority, is in engine's external providers trust store. On the other hand, this change requires that the certificate of the external network provider, or its certification authority, is added to the external providers trust store. The external providers trust store does not contain any default entries, especially it does not contain the usual root certification authorities. Via the web user interface of the "Test" functionality the user can add the certificate of the external network providers neutron API comfortably. This patch does not effect the keystone API. Change-Id: I79a289015329c0fa904b984a8764e73a18da9e5f Signed-off-by: Dominik Holler <dholler(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/openstack/BaseNetworkProviderProxy.java 1 file changed, 41 insertions(+), 5 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Dominik Holler: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/74839 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I79a289015329c0fa904b984a8764e73a18da9e5f Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Enable test of external network provider with HTTPS
by Code Review 06 Apr '17

06 Apr '17

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: engine: Enable test of external network provider with HTTPS ...................................................................... engine: Enable test of external network provider with HTTPS To enable the configuration test of external network providers with HTTPS the BaseNetworkProviderProxy inherits from BaseProviderProxy to share it's getCertificateChain() method. During the test it is possible to add the certificate of the external network provider to the external providers trust store via the web user interface. Change-Id: I6fffd3fe3d2eef93eedd1379bb5de23b09eb8c31 Signed-off-by: Dominik Holler <dholler(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/openstack/BaseNetworkProviderProxy.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/openstack/ExternalNetworkProviderProxy.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/openstack/OpenstackNetworkProviderProxy.java 3 files changed, 20 insertions(+), 30 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Marcin Mirecki: Looks good to me, but someone else must approve Dominik Holler: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/74907 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6fffd3fe3d2eef93eedd1379bb5de23b09eb8c31 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Use external providers trust store for keystone API
by Code Review 06 Apr '17

06 Apr '17

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: engine: Use external providers trust store for keystone API ...................................................................... engine: Use external providers trust store for keystone API Move CustomizedRESTEasyConnector to a separate class, and use it by the BaseNetworkProviderProxy and the ExternalNetworkTokenProvider. This enables the ExternalNetworkTokenProvider to access keystone API via HTTPS with certificates from the engine's external providers trust store. This should be the last patch to enable HTTPS for external network providers. Change-Id: Iecf03549c89f4b2e17ab07c1e0d9ba0d24408547 Signed-off-by: Dominik Holler <dholler(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/openstack/BaseNetworkProviderProxy.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/openstack/CustomizedRESTEasyConnector.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/openstack/ExternalNetworkTokenProvider.java 3 files changed, 68 insertions(+), 60 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Dominik Holler: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/74911 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iecf03549c89f4b2e17ab07c1e0d9ba0d24408547 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: aaa: Running the command logon on the VM via the REST failed
by Code Review 06 Apr '17

06 Apr '17

>From Martin Peřina <mperina(a)redhat.com>: Martin Peřina has submitted this change and it was merged. Change subject: aaa: Running the command logon on the VM via the REST failed ...................................................................... aaa: Running the command logon on the VM via the REST failed Logon on VM using restapi needs password access scope dependency assigned to restapi scope. Change-Id: I80879311bc8d7c4d6ef5c656c6fb6a97c911b345 Bug-Url: https://bugzilla.redhat.com/1438484 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- A packaging/dbscripts/upgrade/04_02_0220_add_password_access_to_restapi_scope_dependency.sql 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Ravi Nori: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/75236 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I80879311bc8d7c4d6ef5c656c6fb6a97c911b345 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Add audit log for unsupported status host upgrade ch...
by Code Review 06 Apr '17

06 Apr '17

>From Martin Peřina <mperina(a)redhat.com>: Martin Peřina has submitted this change and it was merged. Change subject: engine: Add audit log for unsupported status host upgrade check failure ...................................................................... engine: Add audit log for unsupported status host upgrade check failure Host upgrade check failure due to unsupported status should log an audit log event for the failure. Change-Id: I363ee98d0fa1be50b54fdf5f2acd462e02ae9cae Bug-Url: https://bugzilla.redhat.com/1433445 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/HostUpdatesChecker.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 3 files changed, 5 insertions(+), 3 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Ravi Nori: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/75084 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I363ee98d0fa1be50b54fdf5f2acd462e02ae9cae Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webamdin: SanStorageModelBase removeIf usage
by Code Review 06 Apr '17

06 Apr '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: webamdin: SanStorageModelBase removeIf usage ...................................................................... webamdin: SanStorageModelBase removeIf usage In order to remove items from lists, SanStorageModelBase used to copy them (using Linq#toList), iterate over the new lists and remove items from the original ones. This meant iterating each list twice instead of just once. This patch improves this model's performance by using Java 8's Collection#removeIf method, allowing to iterate over the list only once and remove items from it on the fly. Change-Id: I8242cba242e0310fb58cedd7cc559a657d0580e7 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanStorageModelBase.java 1 file changed, 4 insertions(+), 14 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified Idan Shaby: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/75159 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8242cba242e0310fb58cedd7cc559a657d0580e7 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Remove java.util.Optional override
by Code Review 06 Apr '17

06 Apr '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: Remove java.util.Optional override ...................................................................... webadmin: Remove java.util.Optional override Upgrading the GWT version the project uses introduced JDK 8 support. Hence, there's no longer a need to override java.util.Optional, and it can (and should!) be removed. Change-Id: I06ee064a29a10d4a48ae922a296d4c92d9c68f26 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/external/Optional.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/cluster/ClusterPopupPresenterWidget.java 2 files changed, 2 insertions(+), 76 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/75158 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I06ee064a29a10d4a48ae922a296d4c92d9c68f26 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Fix typo in SanStorageModelBase comment
by Code Review 06 Apr '17

06 Apr '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: Fix typo in SanStorageModelBase comment ...................................................................... webadmin: Fix typo in SanStorageModelBase comment Change-Id: I7e0f4b7d8793931307161fdc89a6bc6ecbdb341f Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanStorageModelBase.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified Idan Shaby: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/75207 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7e0f4b7d8793931307161fdc89a6bc6ecbdb341f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove redundant Injector.injectMembers()
by Code Review 05 Apr '17

05 Apr '17

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: core: Remove redundant Injector.injectMembers() ...................................................................... core: Remove redundant Injector.injectMembers() Removed redundant Injector.injectMembers(AuditLogableBase), because log message does not contain any variables that need to be injected. Change-Id: I3e854b3426d3bbf47821af86fd46a92e281d9e81 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolMonitor.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/75243 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3e854b3426d3bbf47821af86fd46a92e281d9e81 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Don't add host statistics by default
by Code Review 05 Apr '17

05 Apr '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Don't add host statistics by default ...................................................................... restapi: Don't add host statistics by default In version 3 of the API the hosts used to have the statistics included inline by default. For example a request like this: GET /ovirt-engine/api/hosts/123 Produced a response like this: <host id="123" href="/ovirt-engine/api/hosts/123"> <name>myhost</name> ... <link rel="statistics" href="/ovirt-engine/api/hosts/123/statistics"/> ... <statistics> <statitstic id="..." href="..."> <name>memory.total</name> <description>Total memory</description> ... </statistic> ... </statistics> </host> For the collection of hosts the behaviour was sligthly different: the statistics were included only if the 'detail' parameter was used to request it: GET /ovirt-engine/api/hosts?detail=statistics In version 4 of the API the support for this kind of aggregation, and support for this 'detail' parameter was removed from almost all places, except from hosts. This has a negative side effect in the SDKs: the XML tag that contains the statistics doesn't contain a valid 'href' attribute, and as a result the 'follow_link' method of the SDKs generates an exception. The workaround for that is to check before calling the 'follow_link' method. For example, in the Ruby SDK: statistics = connection.link?(host.statistics) ? connection.follow_link(host.statistics) : host.statistics To avoid this abnormality in the API this patch removes this mechanism from version 4 of the API, and moves it to the version 3 compatibility layer. Change-Id: I5aa6075195e1479746a063acb89f582efa006a14 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostsResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/helpers/V3HostHelper.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3HostServer.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3HostsServer.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostsResourceTest.java 7 files changed, 66 insertions(+), 69 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/74925 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5aa6075195e1479746a063acb89f582efa006a14 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Boris Odnopozov <bodnopoz(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0