April 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Remove redundant methods in StorageDRListModel
by Code Review 25 Apr '17

25 Apr '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Remove redundant methods in StorageDRListModel ...................................................................... webadmin: Remove redundant methods in StorageDRListModel Change-Id: I1273f6dc2c3d92432505d8ed983515626d3bb7a4 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageDRListModel.java 1 file changed, 0 insertions(+), 16 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Sahina Bose: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/76007 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1273f6dc2c3d92432505d8ed983515626d3bb7a4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Benny Zlotnik <bzlotnik(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: webadmin: ovs renames
by Code Review 25 Apr '17

25 Apr '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: webadmin: ovs renames ...................................................................... webadmin: ovs renames Switch type(Experimental!) —> Switch type LEGACY —> Linux Bridge OVS —> OVS (experimental) Change-Id: Ieb8878d9e061bae8e95a44acd4030d77e1ce9f6e Bug-Url: https://bugzilla.redhat.com/1438298 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationConstants.properties 3 files changed, 8 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Martin Mucha: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/75957 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieb8878d9e061bae8e95a44acd4030d77e1ce9f6e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-live[ovirt-live-4.1]: fix CentOS repos
by Code Review 25 Apr '17

25 Apr '17

>From Lev Veyde <lveyde(a)redhat.com>: Lev Veyde has submitted this change and it was merged. Change subject: fix CentOS repos ...................................................................... fix CentOS repos Change-Id: I6b4d0770a2493e958004d456c749a61d899c455d Signed-off-by: Lev Veyde <lveyde(a)redhat.com> --- M centos-7/kickstart/ovirt-live-ovirt-custom.ks.in 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Lev Veyde: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/76029 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6b4d0770a2493e958004d456c749a61d899c455d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-4.1 Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: enable concurent runs for manual system jobs
by Code Review 25 Apr '17

25 Apr '17

>From Eyal Edri <eedri(a)redhat.com>: Eyal Edri has submitted this change and it was merged. Change subject: enable concurent runs for manual system jobs ...................................................................... enable concurent runs for manual system jobs jira: https://ovirt-jira.atlassian.net/browse/OVIRT-1316 Change-Id: I862e676a48100d20eb0412db31b9b50fe8888b59 Signed-off-by: Eyal Edri <eedri(a)redhat.com> --- M jobs/confs/projects/ovirt/system-tests.yaml 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Eyal Edri: Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests Daniel Belenky: Verified -- To view, visit https://gerrit.ovirt.org/75691 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I862e676a48100d20eb0412db31b9b50fe8888b59 Gerrit-PatchSet: 6 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: fix spec_params value in vm_device
by Code Review 25 Apr '17

25 Apr '17

>From Eli Mesika <emesika(a)redhat.com>: Eli Mesika has submitted this change and it was merged. Change subject: core: fix spec_params value in vm_device ...................................................................... core: fix spec_params value in vm_device The squashing 03_06 patch replaced by mistake the following column values: initrd_url column in vm_static table in file 01100_insert_vm_static.sql spec_params column in vm_device table in file 01200_insert_vm_device.sql description column in policy_units table in file 00340_insert_policy_units.sql with UUID while in original it was empty. As a result an exception is thrown in engine when trying to create a map from this value for spec_params or the value is incorrect in the other cases. This patch fixes that issue. Change-Id: I281b8953401a9b8e71ee08031af9c9756fc72b32 Signed-off-by: emesika <emesika(a)redhat.com> --- M packaging/dbscripts/data/00340_insert_policy_units.sql M packaging/dbscripts/data/01100_insert_vm_static.sql M packaging/dbscripts/data/01200_insert_vm_device.sql 3 files changed, 17 insertions(+), 17 deletions(-) Approvals: Eli Mesika: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Andrej Krejcir: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/76013 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I281b8953401a9b8e71ee08031af9c9756fc72b32 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: ovs renames
by Code Review 25 Apr '17

25 Apr '17

>From Tomas Jelinek <tjelinek(a)redhat.com>: Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: ovs renames ...................................................................... webadmin: ovs renames Switch type(Experimental!) —> Switch type LEGACY —> Linux Bridge OVS —> OVS (experimental) Change-Id: Ieb8878d9e061bae8e95a44acd4030d77e1ce9f6e Bug-Url: https://bugzilla.redhat.com/1438298 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationConstants.properties 3 files changed, 8 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Martin Mucha: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/75956 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieb8878d9e061bae8e95a44acd4030d77e1ce9f6e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: missing default route icon
by Code Review 25 Apr '17

25 Apr '17

>From Tomas Jelinek <tjelinek(a)redhat.com>: Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: missing default route icon ...................................................................... webadmin: missing default route icon Change-Id: Icbfe212a8c151e444d8ff6c35ceebdf83aad5060 Bug-Url: https://bugzilla.redhat.com/1434731 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkPanel.java 1 file changed, 18 insertions(+), 10 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Looks good to me, but someone else must approve Martin Mucha: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/76015 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icbfe212a8c151e444d8ff6c35ceebdf83aad5060 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[master]: produceReport: Add pre-upgrade validation
by Code Review 25 Apr '17

25 Apr '17

>From Lev Veyde <lveyde(a)redhat.com>: Lev Veyde has submitted this change and it was merged. Change subject: produceReport: Add pre-upgrade validation ...................................................................... produceReport: Add pre-upgrade validation This patch add a new session to report called Pre-upgrade, which will do SQL commands to validate users database for upgrade scenario. In this initial commit, we added the skill to check hosts health. Finally, we also split the sql commands and bash script for plainness. Change-Id: I5d59a7e7fc896a4a59e08fee1d637d0289e2d2ce Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/produceReport.sh A src/inventory_report/sqls/cleanup.sql A src/inventory_report/sqls/hosts_create_related_lookup_tables.sql A src/inventory_report/sqls/hosts_query_check_health.sql 4 files changed, 98 insertions(+), 29 deletions(-) Approvals: Lev Veyde: Looks good to me, approved Douglas Schilling Landgraf: Verified Sandro Bonazzola: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/75323 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5d59a7e7fc896a4a59e08fee1d637d0289e2d2ce Gerrit-PatchSet: 7 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-live[ovirt-live-4.1]: build: ovirt-live-4.1.2 tc1
by Code Review 25 Apr '17

25 Apr '17

>From Lev Veyde <lveyde(a)redhat.com>: Lev Veyde has submitted this change and it was merged. Change subject: build: ovirt-live-4.1.2 tc1 ...................................................................... build: ovirt-live-4.1.2 tc1 Change-Id: Id0bb04d4301b1995968046bbbc3af249cf7fa464 Signed-off-by: Lev Veyde <lveyde(a)redhat.com> --- M centos-7/Makefile M centos-7/kickstart/ovirt-live-ovirt-custom.ks.in 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Lev Veyde: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/75992 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id0bb04d4301b1995968046bbbc3af249cf7fa464 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-4.1 Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Fix NPE on floating disk creation through REST
by Code Review 25 Apr '17

25 Apr '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Fix NPE on floating disk creation through REST ...................................................................... core: Fix NPE on floating disk creation through REST Commit d9a7c1c moved the read only property of a disk from the disk entity to the relation between a disk and a VM where it belongs, since the property was moved, validating whether a read only property is compatible should be done only in case of adding a disk that is connected to a VM. Change-Id: I5257e7ab9c048b31d134a0f09fbeceed7d596061 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/AddDiskCommand.java 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved Benny Zlotnik: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/75987 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5257e7ab9c048b31d134a0f09fbeceed7d596061 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Benny Zlotnik <bzlotnik(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0