May 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: build-tools: Escape ' when calling AbstractCheck#log
by Code Review 24 May '17

24 May '17

>From Vojtech Szocs <vszocs(a)redhat.com>: Vojtech Szocs has submitted this change and it was merged. Change subject: build-tools: Escape ' when calling AbstractCheck#log ...................................................................... build-tools: Escape ' when calling AbstractCheck#log Looks like the ' character is used for escaping: log(i, "shouldn't") -> "shouldnt" log(i, "shouldn''t") -> "shouldn't" Change-Id: Ifc1bd82f0eb82abc1b9886c8aa4686fba4b3d91d Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M build-tools-root/ovirt-checkstyle-extension/src/main/java/org/ovirt/checkstyle/checks/NlsCheck.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Greg Sheremeta: Looks good to me, approved Vojtech Szocs: Verified -- To view, visit https://gerrit.ovirt.org/77042 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifc1bd82f0eb82abc1b9886c8aa4686fba4b3d91d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: frontend: Small fixes
by Code Review 24 May '17

24 May '17

>From Vojtech Szocs <vszocs(a)redhat.com>: Vojtech Szocs has submitted this change and it was merged. Change subject: frontend: Small fixes ...................................................................... frontend: Small fixes - OvirtXsrfProtectedServiceServlet: - remove unnecessary null check - ApplicationLogManager: - remove unnecessary "final" (method param) In GWT applications, using "final" keyword makes sense when following a specific design (e.g. immutability) or when we need to satisfy Java lang. constraints (e.g. must refer to "final" outer variable from inside an inner class). Other than that, no need to use "final" as the GWT compiler takes care of any (static analysis based) optimizations when doing Java-to-JS compilation. Change-Id: Ie9f45278bb007d93a549347817851a1859b86ddc Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/OvirtXsrfProtectedServiceServlet.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/logging/ApplicationLogManager.java 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved Vojtech Szocs: Verified -- To view, visit https://gerrit.ovirt.org/77041 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie9f45278bb007d93a549347817851a1859b86ddc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Enable disk transferring for users via REST.
by Code Review 24 May '17

24 May '17

>From Daniel Erez <derez(a)redhat.com>: Daniel Erez has submitted this change and it was merged. Change subject: core: Enable disk transferring for users via REST. ...................................................................... core: Enable disk transferring for users via REST. This patch enables image transferring for not-admin users. Until now, it was prevented in the system due to two main reasons: 1. GetImageTransferByIdQuery was an Admin query, and is being called from image transfer REST commands. This patch changes it to a User query and makes the needed changes in the transfer DAO in terms of filtering, etc. 2. Transfer commands did not have any action group, making it unavailable for users with permissions to transfer an image. This patch defines those commands to belong to EDIT_DISK_PROPERTIE action group- which is the needed one to do a transfer. Change-Id: Icf8311d9d53ab88f7e3305fb8fa0ed4cd4ff078c Signed-off-by: Amit Aviram <aaviram(a)redhat.com> Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/GetImageTransferByIdQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/ImageTransferDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/ImageTransferDaoImpl.java M packaging/dbscripts/image_transfers_sp.sql 6 files changed, 34 insertions(+), 6 deletions(-) Approvals: Tal Nisan: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Daniel Erez: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/67586 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icf8311d9d53ab88f7e3305fb8fa0ed4cd4ff078c Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: new mapper for DnsResolverConfiguration
by Code Review 24 May '17

24 May '17

>From Ori Liel <oliel(a)redhat.com>: Ori Liel has submitted this change and it was merged. Change subject: restapi: new mapper for DnsResolverConfiguration ...................................................................... restapi: new mapper for DnsResolverConfiguration …and its usage from other mappers Change-Id: I9d0fcd6270466e4f66317231a390ba02b8fb3d6a Bug-Url: https://bugzilla.redhat.com/1160667 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- A backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/DnsResolverConfigurationMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/NetworkAttachmentMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/NetworkMapper.java 3 files changed, 88 insertions(+), 0 deletions(-) Approvals: Ori Liel: Looks good to me, approved Martin Mucha: Verified Ondřej Svoboda: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/65436 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9d0fcd6270466e4f66317231a390ba02b8fb3d6a Gerrit-PatchSet: 44 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Ondřej Svoboda <osvoboda(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: fixing upgrade script numbering
by Code Review 24 May '17

24 May '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: fixing upgrade script numbering ...................................................................... core: fixing upgrade script numbering An improper numbering of the upgrade script that added the prett_name column caused the upgrade script no to be executed by engine-setup Change-Id: I90297c303b94b20714d7e1b7b27662ccc6b11f2a Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1455033 Signed-off-by: emesika <emesika(a)redhat.com> --- R packaging/dbscripts/upgrade/03_06_2190_add_vds_dynamic_pretty_name.sql 1 file changed, 0 insertions(+), 0 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Eli Mesika: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/77229 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I90297c303b94b20714d7e1b7b27662ccc6b11f2a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: webadmin: PowerManagement Fence proxy subdialog wont close
by Code Review 24 May '17

24 May '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: webadmin: PowerManagement Fence proxy subdialog wont close ...................................................................... webadmin: PowerManagement Fence proxy subdialog wont close Fixed a bug where the dialog-triggering model (FenceProxyModel) had its items cleaned up [1] too early by making a deep copy of the current proxy list model. [1] AddRemoveRowWidget#cleanupModelItems Change-Id: I8f0ddd2cb0895cf13401edaeaf5a6c739d2a82d4 Bug-Url: https://bugzilla.redhat.com/1416550 Signed-off-by: Ravi Nori <rnori(a)redhat.com> Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> (cherry picked from commit d388923c0753239a1409887eada55eb5a8bf114e) --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/FenceProxyModel.java 1 file changed, 22 insertions(+), 6 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Ravi Nori: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/77190 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8f0ddd2cb0895cf13401edaeaf5a6c739d2a82d4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[master]: removing extra spaces, adding AS to have uniform syntax
by Code Review 24 May '17

24 May '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: removing extra spaces, adding AS to have uniform syntax ...................................................................... removing extra spaces, adding AS to have uniform syntax Change-Id: I961f2958bfc69aa5a3b3605070e5aa9e89809b57 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M src/inventory_report/produceReport/produceReport.sh 1 file changed, 8 insertions(+), 8 deletions(-) Approvals: Douglas Schilling Landgraf: Looks good to me, approved Martin Mucha: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/77226 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I961f2958bfc69aa5a3b3605070e5aa9e89809b57 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: configure auth of ovirt-provider-ovn
by Code Review 24 May '17

24 May '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: configure auth of ovirt-provider-ovn ...................................................................... packaging: configure auth of ovirt-provider-ovn Authentication requests to the ovirt-provider-ovn are forwarded to engine's SSO. For this reason the host name and certificate of the engine has to be configured in the ovirt-provider-ovn. For authorization the ovirt-provider-ovn requests session information about the authorization token from the engine's SSO. To do this, the ovirt-provider-ovn has to authorize itself as an valid client to the engine's SSO. This is done by including the combination of client_id and client_secret in the request for information from the ovirt-provider-ovn to engine's SSO. engine-setup generates a new client_secret and registers the pair of the encoded client_secret and a client_id into engine's database and stores this pair in the configuration of ovirt-provider-ovn, too. Change-Id: Ide901a6dcf8fc5b2a65dceb1edb1d1f6ab11a7c1 Bug-Url: https://bugzilla.redhat.com/1436154 Signed-off-by: Dominik Holler <dholler(a)redhat.com> Signed-off-by: Marcin Mirecki <mmirecki(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/engine/constants.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/network/ovirtproviderovn.py 2 files changed, 118 insertions(+), 8 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Dominik Holler: Verified Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/76722 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ide901a6dcf8fc5b2a65dceb1edb1d1f6ab11a7c1 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: engine: remove snapshots table constraints
by Code Review 24 May '17

24 May '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: engine: remove snapshots table constraints ...................................................................... engine: remove snapshots table constraints The RestoreAllSnapshotsCommand is a transactive command. As part of the flow, first the snapshot entry is locked, then if needed memory volumes will be deleted. However, the RemoveDiskCommand is a non-transactive command and when it will try to delete the memory disk, it will need to update also the snapshot row that contains the memory disk id. But since that the snapshot row is already locked by the first command, the RemoveDiskCommand will fail to get the lock. This patch remove the constraints between the base_disks and the snapshots. A better solution is to make RestoreAllSnapshotsCommand a non-transactive command, and add compensation logic. Also, newer version of Postgres will permit better locking, avoiding this situation. Bugs: BZ 1454823: Restore the constraints after upgrading the Postgres version. BZ 1454830: Make RestoreAllSnapshotsCommand non-transactive command and add compensation logic Change-Id: Iffc45d2ef28b65894504e49f6e966c81c4a16c3f Bug-Url: https://bugzilla.redhat.com/1427104 Signed-off-by: Fred Rolland <frolland(a)redhat.com> --- A packaging/dbscripts/upgrade/04_01_0810_drop_memory_snapshot_constraints.sql 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Freddy Rolland: Verified -- To view, visit https://gerrit.ovirt.org/77241 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iffc45d2ef28b65894504e49f6e966c81c4a16c3f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Refactor: Use macros in defaults file
by Code Review 24 May '17

24 May '17

>From Barak Korren <bkorren(a)redhat.com>: Barak Korren has submitted this change and it was merged. Change subject: Refactor: Use macros in defaults file ...................................................................... Refactor: Use macros in defaults file Previous refactor script was not complete, we had another (older) defaults section in the file that is still in use by older jobs. Change-Id: I11d529635a34ecb0675f8e38b7398c6b3360d1f1 Signed-off-by: Barak Korren <bkorren(a)redhat.com> Jira-Ticket: https://ovirt-jira.atlassian.net/browse/OVIRT-1400 --- M jobs/confs/projects/defaults.yaml 1 file changed, 2 insertions(+), 15 deletions(-) Approvals: Eyal Edri: Looks good to me Barak Korren: Verified; Looks good to me, approved; Ready for merge Gil Shinar: Looks good to me Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/77196 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I11d529635a34ecb0675f8e38b7398c6b3360d1f1 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>

1 0