May 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: testDetermineTotalImageInitialSizeFromNfsToCow NPE
by Code Review 14 May '17

14 May '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: testDetermineTotalImageInitialSizeFromNfsToCow NPE ...................................................................... core: testDetermineTotalImageInitialSizeFromNfsToCow NPE Commit 541c6a introduced ImagesHandler#determineTotalImageInitialSize and its test, ImagesHandlerTest#testDetermineTotalImageInitialSizeFromNfsToCow. determineTotalImageInitialSize could in theory return null, so if a bug is introduced there, the test may error out with an NPE instead "cleanly" failing. Comparing java.lang.Longs instead of primitive longs in the test solves this issue. This patch solves Coverity CID 1375001. Change-Id: I8b644c3dd79ea62cda668ff7ed7e74e78a90abc3 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/image/ImagesHandlerTest.java 1 file changed, 2 insertions(+), 5 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified Freddy Rolland: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/76769 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8b644c3dd79ea62cda668ff7ed7e74e78a90abc3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Add lago-ost-plugin jobs
by Code Review 14 May '17

14 May '17

>From Eyal Edri <eedri(a)redhat.com>: Eyal Edri has submitted this change and it was merged. Change subject: Add lago-ost-plugin jobs ...................................................................... Add lago-ost-plugin jobs Uses the same Lago CI flow. Change-Id: I6a0c1b3a2e67cc62ee6db81322c8454f97c42a75 Signed-off-by: Nadav Goldin <ngoldin(a)redhat.com> --- A jobs/confs/projects/lago/lago_ost_plugin.yaml M jobs/confs/yaml/scms/lago.yaml 2 files changed, 52 insertions(+), 0 deletions(-) Approvals: Nadav Goldin: Verified; Ready for review Gal Ben Haim: Looks good to me Eyal Edri: Looks good to me, approved; Ready for merge Gil Shinar: Looks good to me Daniel Belenky: Looks good to me Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/76641 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6a0c1b3a2e67cc62ee6db81322c8454f97c42a75 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gal Ben Haim <galbh2(a)gmail.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: SyntaxChecker type inference
by Code Review 14 May '17

14 May '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: SyntaxChecker type inference ...................................................................... core: SyntaxChecker type inference Change-Id: I1356cca3e1ef0462af1768fbd9ae3efa5195f12e Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/76789 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1356cca3e1ef0462af1768fbd9ae3efa5195f12e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Remove PairFirstComparator
by Code Review 12 May '17

12 May '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: engine: Remove PairFirstComparator ...................................................................... engine: Remove PairFirstComparator PairFirstComparator was a convenience class introduced before the engine used Java 8. Now that it does (including in the frontend), there's no advantage in using new PairFirstComparator<>(someComparator) over Java's built in mechanism of Comparator.comparing(Pair::getFirst, someComparator). This patch removes this now-redundant class and uses Java's built-in mechanisms instead. Change-Id: Ic7409a72d09821df907af207563f8eabc5953504 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/PairFirstComparator.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/SizeConverter.java D backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/PairFirstComparatorTest.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkClusterListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/AbstractUserPortalListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkHostView.java 7 files changed, 6 insertions(+), 62 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified; Looks good to me, approved Vojtech Szocs: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/76488 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic7409a72d09821df907af207563f8eabc5953504 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-live[ovirt-live-4.1]: oVirt Live 4.1.2 RC2
by Code Review 12 May '17

12 May '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: oVirt Live 4.1.2 RC2 ...................................................................... oVirt Live 4.1.2 RC2 Change-Id: Ie5b517a4306bcb35a51076b66e285ddab2daa759 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M centos-7/Makefile M centos-7/kickstart/ovirt-live-ovirt-custom.ks.in 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/76759 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie5b517a4306bcb35a51076b66e285ddab2daa759 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-4.1 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: add build-on-demand jobs to python-sdk
by Code Review 12 May '17

12 May '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: add build-on-demand jobs to python-sdk ...................................................................... add build-on-demand jobs to python-sdk Change-Id: Ia0bb02761ab39068f166c1bcb191188b8796133e Signed-off-by: Eyal Edri <eedri(a)redhat.com> --- M jobs/confs/projects/ovirt-engine-sdk/ovirt-engine-sdk_build-artifacts.yaml M jobs/confs/yaml/templates/standard-stage.yaml 2 files changed, 19 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved; Ready for merge Eyal Edri: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/76734 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia0bb02761ab39068f166c1bcb191188b8796133e Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: webadmin, userportal: Ensure table column vertical separator
by Code Review 12 May '17

12 May '17

>From Piotr Kliczewski <piotr.kliczewski(a)gmail.com>: Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin,userportal: Ensure table column vertical separator ...................................................................... webadmin,userportal: Ensure table column vertical separator 1, move `border-right` & `margin-right` from ResizableHeader.css into TabCellTable.css (base style for most table widgets) 2, remove redundancy in PopupCellTable.css (same styles already declared in TabCellTable.css) 3, cleanup px-based values, e.g. `padding: 0 3px` instead of the unnecessary verbose `padding: 0px 3px` Change-Id: I9d26b95254619767a88a83b86489f488f87b76dd Bug-Url: https://bugzilla.redhat.com/1403847 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/css/PopupCellTable.css M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/css/ResizableHeader.css M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/css/TabCellTable.css 3 files changed, 8 insertions(+), 27 deletions(-) Approvals: Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved Vojtech Szocs: Verified -- To view, visit https://gerrit.ovirt.org/76682 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9d26b95254619767a88a83b86489f488f87b76dd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: aaa: SSO token used for the API expires when running only qu...
by Code Review 12 May '17

12 May '17

>From Piotr Kliczewski <piotr.kliczewski(a)gmail.com>: Piotr Kliczewski has submitted this change and it was merged. Change subject: aaa: SSO token used for the API expires when running only queries ...................................................................... aaa: SSO token used for the API expires when running only queries The session soft limit should be updated for all queries executed by ovirt-app-api scope. Change-Id: I33d298275f44b89e49c0fb0021454f567f6f9093 Bug-Url: https://bugzilla.redhat.com/1434605 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/SessionDataContainer.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Ravi Nori: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/76715 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I33d298275f44b89e49c0fb0021454f567f6f9093 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-release[ovirt-4.1]: build: 4.1.2 rc2
by Code Review 12 May '17

12 May '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: build: 4.1.2 rc2 ...................................................................... build: 4.1.2 rc2 Change-Id: I8fc95aebb4481fae6a0c6e1cbddc1445812aaff3 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac M ovirt-release41.spec.in 2 files changed, 5 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/76756 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8fc95aebb4481fae6a0c6e1cbddc1445812aaff3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: ovirt-4.1 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Ryan Barry <rbarry(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Yuval Turgeman <yturgema(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[master]: Bump version
by Code Review 12 May '17

12 May '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Bump version ...................................................................... Bump version Change-Id: I003a48b51f1c0a64dead32602fa2b6fc96742205 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M generator/pom.xml M pom.xml M sdk/pom.xml 3 files changed, 3 insertions(+), 3 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/76732 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I003a48b51f1c0a64dead32602fa2b6fc96742205 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0