May 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Use AuditLogImpl for audit logging
by Code Review 30 May '17

30 May '17

>From Martin Peřina <mperina(a)redhat.com>: Martin Peřina has submitted this change and it was merged. Change subject: engine: Use AuditLogImpl for audit logging ...................................................................... engine: Use AuditLogImpl for audit logging Change-Id: Iea712b26022ecac8b63fb9f9eb35af2da016b04d Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpool/MacPoolUsingRanges.java 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests Moti Asayag: Verified -- To view, visit https://gerrit.ovirt.org/77220 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iea712b26022ecac8b63fb9f9eb35af2da016b04d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Use AuditLogableImpl for logging event
by Code Review 30 May '17

30 May '17

>From Martin Peřina <mperina(a)redhat.com>: Martin Peřina has submitted this change and it was merged. Change subject: engine: Use AuditLogableImpl for logging event ...................................................................... engine: Use AuditLogableImpl for logging event The Vnic events can be simply logged using the AuditLogableImpl. In addition, the Vm Id should be included as well to give the event the right context in which it was created. Change-Id: I6e5fc06ddc7bdd9d57ba1c63e0f275223b4fdc7b Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/VmInterfaceManager.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/VmInterfaceManagerTest.java 2 files changed, 17 insertions(+), 14 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests Moti Asayag: Verified -- To view, visit https://gerrit.ovirt.org/77222 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6e5fc06ddc7bdd9d57ba1c63e0f275223b4fdc7b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Use AuditLogableImpl for logging events
by Code Review 30 May '17

30 May '17

>From Martin Peřina <mperina(a)redhat.com>: Martin Peřina has submitted this change and it was merged. Change subject: engine: Use AuditLogableImpl for logging events ...................................................................... engine: Use AuditLogableImpl for logging events The AuditLogableImpl is the recommended implementation for logging events that don't need any data-resolving (i.e. getters of AuditLogableBase). Change-Id: I56b957e190f48aff9d1f0f75b8ba391ff9fb7b23 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolMonitor.java 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests Moti Asayag: Verified -- To view, visit https://gerrit.ovirt.org/77215 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I56b957e190f48aff9d1f0f75b8ba391ff9fb7b23 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Extracts MessageBundler from AuditLogDirector
by Code Review 30 May '17

30 May '17

>From Martin Peřina <mperina(a)redhat.com>: Martin Peřina has submitted this change and it was merged. Change subject: engine: Extracts MessageBundler from AuditLogDirector ...................................................................... engine: Extracts MessageBundler from AuditLogDirector The message bundler is used outside of the context of AuditLogDirecto, therefore it can be pulled into its own class. Change-Id: Ia4f74dab34981fc2c215b939d7d5c4725ff262f5 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/UpdateVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/AffinityRulesEnforcementManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/MessageBundler.java 7 files changed, 50 insertions(+), 38 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests Moti Asayag: Verified -- To view, visit https://gerrit.ovirt.org/76699 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia4f74dab34981fc2c215b939d7d5c4725ff262f5 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Use AuditLogableImpl for logging events
by Code Review 30 May '17

30 May '17

>From Martin Peřina <mperina(a)redhat.com>: Martin Peřina has submitted this change and it was merged. Change subject: engine: Use AuditLogableImpl for logging events ...................................................................... engine: Use AuditLogableImpl for logging events The AuditLogableImpl is the recommended implementation for logging events that don't need any data-resolving (i.e. getters of AuditLogableBase). Change-Id: I8e418a508f06e4e5f1ad69a20832f5af00e4b612 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HostedEngineImporter.java 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Denis Chaplygin: Looks good to me, but someone else must approve Martin Sivák: Looks good to me, approved Alona Kaplan: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Phillip Bailey: Looks good to me, but someone else must approve Moti Asayag: Verified -- To view, visit https://gerrit.ovirt.org/77214 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8e418a508f06e4e5f1ad69a20832f5af00e4b612 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Inject AuditLogDirector instead of instantiation
by Code Review 30 May '17

30 May '17

>From Martin Peřina <mperina(a)redhat.com>: Martin Peřina has submitted this change and it was merged. Change subject: engine: Inject AuditLogDirector instead of instantiation ...................................................................... engine: Inject AuditLogDirector instead of instantiation AuditLogDirector should be a bean and retrieved via injection and not by an explicit instantiation. Change-Id: If9d9d6cac3c9bcaedcdaaeac6241d22ec0197e4d Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestartVdsVmsOperation.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolMonitor.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/InstallerMessages.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/VdsDeploy.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/NetworkConfigurator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/VmInterfaceManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpool/MacPoolUsingRanges.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/VnicProfileHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/SingleAgentFenceActionExecutor.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManagerAuditLogger.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerBrokerImpl.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerBrokerObjectBuilder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerDiscovery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/PowerSavingBalancePolicyUnit.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/CINDERStorageHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/StorageHelperBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/CinderBroker.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/ExtendCinderDiskCommandCallback.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/RemoveCinderDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/MetadataDiskDescriptionHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ovfstore/CreateOvfVolumeForStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/AsyncTaskManager.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/macpool/MacPoolPerClusterTest.java 23 files changed, 59 insertions(+), 25 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests Moti Asayag: Verified -- To view, visit https://gerrit.ovirt.org/76718 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If9d9d6cac3c9bcaedcdaaeac6241d22ec0197e4d Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Use AuditLogableImpl for simple logging
by Code Review 30 May '17

30 May '17

>From Martin Peřina <mperina(a)redhat.com>: Martin Peřina has submitted this change and it was merged. Change subject: engine: Use AuditLogableImpl for simple logging ...................................................................... engine: Use AuditLogableImpl for simple logging Change-Id: I7320f9b048ad594558d7357b2c9e0146494d7bb1 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/RegisterDiskCommand.java 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Moti Asayag: Verified -- To view, visit https://gerrit.ovirt.org/77213 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7320f9b048ad594558d7357b2c9e0146494d7bb1 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Do not instantiate AuditLogDirector
by Code Review 30 May '17

30 May '17

>From Martin Peřina <mperina(a)redhat.com>: Martin Peřina has submitted this change and it was merged. Change subject: engine: Do not instantiate AuditLogDirector ...................................................................... engine: Do not instantiate AuditLogDirector AuditLogDirector is a singleton bean and such, its instance should be obtained via the CDI. Change-Id: I482b4ba2ee2a57f569925033269afa552d2cf4f1 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/VmInfoBuildUtils.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxy.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/storage/StorageDomainHelper.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostNetworkTopologyPersisterImpl.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/VmInfoBuildUtilsTest.java D backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectBuilderTest.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilderTest.java 9 files changed, 388 insertions(+), 355 deletions(-) Approvals: Martin Peřina: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/76790 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I482b4ba2ee2a57f569925033269afa552d2cf4f1 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: provider: make sure to log cause of test connection failure
by Code Review 30 May '17

30 May '17

>From Martin Peřina <mperina(a)redhat.com>: Martin Peřina has submitted this change and it was merged. Change subject: provider: make sure to log cause of test connection failure ...................................................................... provider: make sure to log cause of test connection failure Change-Id: Id9518ef6435688ccf71711b3309660eefcbf277e Signed-off-by: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/storage/AbstractOpenStackStorageProviderProxy.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Piotr Kliczewski: Verified Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/74653 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id9518ef6435688ccf71711b3309660eefcbf277e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-2.1]: packaging: spec: Add requirement for rubygem-fluent-plugin-c...
by Code Review 30 May '17

30 May '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: spec: Add requirement for rubygem-fluent-plugin-collectd-nest ...................................................................... packaging: spec: Add requirement for rubygem-fluent-plugin-collectd-nest Change-Id: I083eaf60fa961118c8d60d076fcaf613e8fc37ab Signed-off-by: Lev Veyde <lveyde(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1426897 (cherry picked from commit b27c2281732e05f171952ad4221bc1aa47dbadee) --- M ovirt-hosted-engine-setup.spec.in 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/77531 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I083eaf60fa961118c8d60d076fcaf613e8fc37ab Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-2.1 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0