May 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine-sdk-ruby[master]: Add Error.fault
by Code Review 28 May '17

28 May '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: Add Error.fault ...................................................................... Add Error.fault Currently when a fault is returned by the server the information that it contains is used to generate an exception message, and then this discarded. This patch changes the SDK so that the fault object is copied to the 'Error.fault' attribute instead of discarded. Change-Id: I98ff05baebb174bf9446b6098a28b3cb5da81021 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M sdk/lib/ovirtsdk4/connection.rb M sdk/lib/ovirtsdk4/error.rb M sdk/spec/vm_service_spec.rb 3 files changed, 29 insertions(+), 7 deletions(-) Approvals: Ondra Machacek: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/76865 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I98ff05baebb174bf9446b6098a28b3cb5da81021 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Boris Odnopozov <bodnopoz(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[sdk_4.1]: Add Error.code
by Code Review 28 May '17

28 May '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: Add Error.code ...................................................................... Add Error.code This patch adds a new 'code' attribute to the Error class. For errors that are HTTP related, this will contain the HTTP response code. For example, if the method to retrieve a virtual machine fails because it doesn't exist, this will contain the value 404. The users of the SDK can use it like this: # Get the identifier of the virtual machine from some place, maybe # from a database that is out of sync with the engine: id = ... # Find the service that manages that virtual machine. Note that this # will always succeed, even if the virtual machine doesn't exist, as # the calls to the 'whatever_service' methods *do not* perform any # call to the server. vm_service = vms_service.vm_service(id) # Try to retrieve the virtual machine. This *does* send the request # to the server, hence it may fail if the virtual machine doesn't # exist. begin vm = vm_service.get rescue OvirtSDK4::Error => error if error.code == 404 # The virtual machine doesn't exist, handle it. ... else # Something else happened that we don't know how to handle. raise end end For errors that aren't HTTP related, the value of the new attribute will be 'nil'. Change-Id: I6e3fc71e17fa1726049ca1e49c8cc9e295c15b0c Bug-Url: https://bugzilla.redhat.com/1443420 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 512ab31f477f9f1ec763a7face556013ffef4c7e) --- M sdk/lib/ovirtsdk4.rb M sdk/lib/ovirtsdk4/connection.rb A sdk/lib/ovirtsdk4/error.rb M sdk/spec/vm_service_spec.rb 4 files changed, 47 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/77009 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6e3fc71e17fa1726049ca1e49c8cc9e295c15b0c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.1 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[sdk_4.1]: Add example how to attach LUN disk to VM
by Code Review 28 May '17

28 May '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: Add example how to attach LUN disk to VM ...................................................................... Add example how to attach LUN disk to VM This example add an example how to add LUN disk to VM. Change-Id: I8a0ca0f90e89c3a229941b48afae74f95d6eeec0 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> (cherry picked from commit 088a9d6b75709e0a3603c5cc38602672eb7b7b89) --- A sdk/examples/add_lun_disk_to_vm.rb 1 file changed, 67 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/77007 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8a0ca0f90e89c3a229941b48afae74f95d6eeec0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.1 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[master]: pre-upgrade-checks: Use Caps for Tables
by Code Review 27 May '17

27 May '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: pre-upgrade-checks: Use Caps for Tables ...................................................................... pre-upgrade-checks: Use Caps for Tables Change-Id: I16a568717e261f67ed413cdc5b7dfb60e6746019 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/produceReport/pre-upgrade-checks 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/77417 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I16a568717e261f67ed413cdc5b7dfb60e6746019 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[master]: inventory: Use sort unique to display past engines
by Code Review 27 May '17

27 May '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: inventory: Use sort unique to display past engines ...................................................................... inventory: Use sort unique to display past engines Change-Id: Iaa1d7d1a2bf7ccad6117cce594cb32ed6c16ecad Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/produceReport/produceReport.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/77416 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaa1d7d1a2bf7ccad6117cce594cb32ed6c16ecad Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[master]: inventory: only shows upgraded engines field if necessary
by Code Review 26 May '17

26 May '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: inventory: only shows upgraded engines field if necessary ...................................................................... inventory: only shows upgraded engines field if necessary Previously, we always showed the field 'Probable past the engine versions even when no upgrades happened from 3.y or show duplicate data. This patch will make sure we display this field only when needed and with no duplicate data. Change-Id: I1e82fdc1d00c6f11e3814dd5fb8d655f60d2c0f5 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/produceReport/produceReport.sh 1 file changed, 15 insertions(+), 11 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/77414 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1e82fdc1d00c6f11e3814dd5fb8d655f60d2c0f5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[master]: inventory: remove unneeded double quotes from msg
by Code Review 26 May '17

26 May '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: inventory: remove unneeded double quotes from msg ...................................................................... inventory: remove unneeded double quotes from msg Change-Id: I34db0360bb66f4c8f07d2564e5fae52b7171a76e Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/importDumpIntoNewDb.sh 1 file changed, 7 insertions(+), 7 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/77411 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I34db0360bb66f4c8f07d2564e5fae52b7171a76e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[master]: inventory script: warn about vds_groups and cluster tables c...
by Code Review 26 May '17

26 May '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: inventory script: warn about vds_groups and cluster tables coexist ...................................................................... inventory script: warn about vds_groups and cluster tables coexist vds_groups table has been renamed to cluster, shouldn't coexist Change-Id: Ibb72982c604c429cf6994e2a1859035d0c3b1aac Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/Makefile.am M src/inventory_report/produceReport/pre-upgrade-checks M src/inventory_report/produceReport/produceReport.sh A src/inventory_report/produceReport/sqls/table_check_if_vds_groups_and_cluster_coexist.sql 4 files changed, 19 insertions(+), 0 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/77209 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibb72982c604c429cf6994e2a1859035d0c3b1aac Gerrit-PatchSet: 5 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: cockpit-ovirt: add fedora 26
by Code Review 26 May '17

26 May '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: cockpit-ovirt: add fedora 26 ...................................................................... cockpit-ovirt: add fedora 26 Change-Id: I4fd5aeb32e5e02d3a94fade87abb691c10e5434f Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/projects/cockpit-ovirt/cockpit-ovirt.yaml 1 file changed, 10 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/77404 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4fd5aeb32e5e02d3a94fade87abb691c10e5434f Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Ryan Barry <rbarry(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: edit Vm from pool did not show the RNG config
by Code Review 26 May '17

26 May '17

>From Martin Betak <mbetak(a)redhat.com>: Martin Betak has submitted this change and it was merged. Change subject: webadmin: edit Vm from pool did not show the RNG config ...................................................................... webadmin: edit Vm from pool did not show the RNG config The problem was that the updateRngDevice() checked if the getIsRngEnabled() is changable or not. This is an incorrect check in the edit VM from pool where (almost) all fields are disabled. Solved by removing this check completely because it could never result to "false". Change-Id: I00da6580da7c458bdd5585b8e921097880cd83d1 Bug-Url: https://bugzilla.redhat.com/1429912 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants.properties 3 files changed, 0 insertions(+), 18 deletions(-) Approvals: Tomas Jelinek: Verified Jakub Niedermertl: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Martin Betak: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/77343 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I00da6580da7c458bdd5585b8e921097880cd83d1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0