June 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin, userportal: Improve GWT symbol map handling
by Code Review 06 Jun '17

06 Jun '17

>From Vojtech Szocs <vszocs(a)redhat.com>: Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin,userportal: Improve GWT symbol map handling ...................................................................... webadmin,userportal: Improve GWT symbol map handling Before this patch, GWT .symbolMap files were installed through optional `{webadmin-portal,userportal}-debuginfo` RPM packages, which used the following layout: $PREFIX/share/ovirt-engine/gwt-symbols/webadmin/symbolMaps/ $PREFIX/share/ovirt-engine/gwt-symbols/userportal/symbolMaps/ with above directories containing <gwtPermStrongName>.symbolMap files. This had two main drawbacks: 1, GWT symbol maps were optional (not available right after Engine installation), imposing one extra step when trying to diagnose and fix GWT UI related problems 2, GWT symbol maps are big: 9 locales x 3 user agents = 27 .symbolMap files for each GWT application, for WebAdmin each .symbolMap file is ~37 M (x 27 = ~1 G) After this patch, GWT .symbolMap files are part of the core UI packages, using the following layout: $PREFIX/share/ovirt-engine/gwt-symbols/webadmin/symbolMaps.zip $PREFIX/share/ovirt-engine/gwt-symbols/userportal/symbolMaps.zip This solves both issues listed above. In case of an uncaught UI exception, `OvirtRemoteLoggingService` servlet opens the .zip file (using Java 8 zip FileSystem support) and streams relevant .symbolMap content needed for Java stack trace de-obfuscation. This also means that `{webadmin-portal,userportal}-debuginfo` RPM packages are now unnecessary and are therefore removed. Change-Id: I083a3b8ad5588f56b8569c862240591a44002326 Bug-Url: https://bugzilla.redhat.com/1431545 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M Makefile M backend/manager/modules/restapi/apidoc/pom.xml M backend/manager/modules/restapi/interface/definition/pom.xml A frontend/webadmin/modules/frontend-assemblies/pom.xml A frontend/webadmin/modules/frontend-assemblies/src/main/resources/assemblies/gwt-symbols.xml D frontend/webadmin/modules/frontend-symbols/pom.xml D frontend/webadmin/modules/frontend-symbols/resources/userportal/.keep D frontend/webadmin/modules/frontend-symbols/resources/webadmin/.keep M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/OvirtRemoteLoggingService.java M frontend/webadmin/modules/gwt-common/pom.xml M frontend/webadmin/modules/pom.xml M frontend/webadmin/modules/userportal-gwtp/pom.xml M frontend/webadmin/modules/webadmin/pom.xml M ovirt-engine.spec.in M pom.xml 15 files changed, 162 insertions(+), 144 deletions(-) Approvals: Jenkins CI: Passed CI tests Greg Sheremeta: Verified; Looks good to me, approved Vojtech Szocs: Verified -- To view, visit https://gerrit.ovirt.org/75420 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I083a3b8ad5588f56b8569c862240591a44002326 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Free pooled VM lock independently from context locks
by Code Review 06 Jun '17

06 Jun '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: Free pooled VM lock independently from context locks ...................................................................... core: Free pooled VM lock independently from context locks When a non-prestarted VM is allocated from VM Pool, it is locked early in AttachUserToVmFromPoolAndRunCommand flow, before other locks of the command are taken. It is possible that it is also freed before that moment, so context.getLock() != null condition will be false, but the VM lock is already taken and must be freed. Change-Id: I628946d781ecbe280562efe7cf7e3a3c84801f39 Bug-Url: https://bugzilla.redhat.com/1433924 Bug-Url: https://bugzilla.redhat.com/1432105 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachUserToVmFromPoolAndRunCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AttachUserToVmFromPoolAndRunParameters.java 2 files changed, 14 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/77820 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I628946d781ecbe280562efe7cf7e3a3c84801f39 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Extra audit log message when creating instance type
by Code Review 06 Jun '17

06 Jun '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: Extra audit log message when creating instance type ...................................................................... core: Extra audit log message when creating instance type When instance type is created with AddVmTemplateCommand, an extra audit log message is produced in END_SUCCESS state. Adding a check to eliminate it. Change-Id: I8092c44d844db6e55e9a051c01dc03fe43b6638b Bug-Url: https://bugzilla.redhat.com/1452218 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/76999 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8092c44d844db6e55e9a051c01dc03fe43b6638b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Use collection addAll instead of a for loop in ImagesH...
by Code Review 06 Jun '17

06 Jun '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Use collection addAll instead of a for loop in ImagesHandler ...................................................................... core: Use collection addAll instead of a for loop in ImagesHandler Change-Id: I7a50377dd3503d4acdb7c4ee2654305ae9c3bfab Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/ImagesHandler.java 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/77876 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7a50377dd3503d4acdb7c4ee2654305ae9c3bfab Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Use Java streams in ImagesHandler
by Code Review 06 Jun '17

06 Jun '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Use Java streams in ImagesHandler ...................................................................... core: Use Java streams in ImagesHandler Change-Id: I7b3cd4e682486d10d54025b9f53ed013b62fd720 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/ImagesHandler.java 1 file changed, 54 insertions(+), 109 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/77281 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7b3cd4e682486d10d54025b9f53ed013b62fd720 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Benny Zlotnik <bzlotnik(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove null checks in ImagesHandler methods
by Code Review 06 Jun '17

06 Jun '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Remove null checks in ImagesHandler methods ...................................................................... core: Remove null checks in ImagesHandler methods Remove null checks in getDiskImagesByIdMap and getDiskImageIds as all usages are for non null objects Change-Id: If5d5c1180c385e3a87de6146cd4a97dd7bcc5825 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/ImagesHandler.java 1 file changed, 2 insertions(+), 7 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/77877 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If5d5c1180c385e3a87de6146cd4a97dd7bcc5825 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Update relative path in test.
by Code Review 06 Jun '17

06 Jun '17

>From Maor Lipchuk <mlipchuk(a)redhat.com>: Maor Lipchuk has submitted this change and it was merged. Change subject: core: Update relative path in test. ...................................................................... core: Update relative path in test. Use relative path of bll instead of root backend - when running tests from the IDE the working directory is the root folder although run it from bll with mvn will use working directory of backend/manager/modules/bll, therefore changing the relative path of the XML file in the test to be relative to bll so jenkins tests will pass and for the IDE the working directory should be changed manually in the run configurations to be backend/manager/modules/bll. Change-Id: I54a8b0264e453696d168fc12a9ce6d9e6da5e946 Bug-Url: https://bugzilla.redhat.com/1443641 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/utils/OvfUtilsTest.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/77811 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I54a8b0264e453696d168fc12a9ce6d9e6da5e946 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Use disk id instead of volume id in OvfUtilsTest
by Code Review 06 Jun '17

06 Jun '17

>From Maor Lipchuk <mlipchuk(a)redhat.com>: Maor Lipchuk has submitted this change and it was merged. Change subject: core: Use disk id instead of volume id in OvfUtilsTest ...................................................................... core: Use disk id instead of volume id in OvfUtilsTest This fix is related to test of unregistered disks. The engine filters out disks which are attached to VMs to know which are unregistered disks and which are not. Since the filtering is being done with the disk id the test should be changed to use the disk id in the OVF instead of the volume id. Change-Id: Ib5d1f613a6ead694e93f8a29cda53b0f24d6de03 Bug-Url: https://bugzilla.redhat.com/1443641 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/utils/OvfUtilsTest.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/77677 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib5d1f613a6ead694e93f8a29cda53b0f24d6de03 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[master]: replace important icon with warning one.
by Code Review 06 Jun '17

06 Jun '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: replace important icon with warning one. ...................................................................... replace important icon with warning one. both produced exclamation symbol, one in triangle (this one stays), and other without any graphical support at all(this one was replaced). This created uncertainty where they differ (except for the triangle part), and exclamation without trinagle was much narrower then other symbol, which disrupted alignment. Change-Id: I6fdcb5225bc25d36307e007c0c4e057b618a8c28 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M src/inventory_report/produceReport/pre-upgrade-checks M src/inventory_report/produceReport/produceReport.sh 2 files changed, 3 insertions(+), 4 deletions(-) Approvals: Douglas Schilling Landgraf: Looks good to me, approved Martin Mucha: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/77886 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6fdcb5225bc25d36307e007c0c4e057b618a8c28 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Introducing DiskOperationsValidator
by Code Review 06 Jun '17

06 Jun '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Introducing DiskOperationsValidator ...................................................................... core: Introducing DiskOperationsValidator Add DiskOperationsValidator which allows validating whether a command can be run on various disk content types instead of validating each content type individually Change-Id: If8e121d8ade58925a45c5832bfe4c93a210de157 Bug-Url: https://bugzilla.redhat.com/1452988 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/DiskOperationsValidator.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/storage/DiskOperationsValidatorTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 8 files changed, 96 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Idan Shaby: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/77452 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If8e121d8ade58925a45c5832bfe4c93a210de157 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Benny Zlotnik <bzlotnik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0