July 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: backend: don't remove VG ID of direct lun that is a part of ...
by Code Review 20 Jul '17

20 Jul '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/79480 ) Change subject: backend: don't remove VG ID of direct lun that is a part of a SD ...................................................................... backend: don't remove VG ID of direct lun that is a part of a SD When synchronizing a direct lun, the VG ID that comes from getDeviceList used to be changed to an empty string before updating the lun in the DB, assuming that a direct lun doesn't have a VG ID and thus the information that comes from vdsm is old and irrelevant. That isn't true when talking about a lun which is a part of a storage domain (and thus has a VG ID) and is also used as a direct lun. Therefore, this patch makes sure that when synchronizing a direct lun, the VG ID will be updated only if it is not an empty string. Change-Id: I3171bee8bc0d45c459977638919489bb25cc4e49 Bug-Url: https://bugzilla.redhat.com/1471759 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/SyncDirectLunsCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/pool/SyncDirectLunsCommandTest.java 2 files changed, 27 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, but someone else must approve Allon Mureinik: Looks good to me, approved Freddy Rolland: Looks good to me, but someone else must approve Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/79480 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3171bee8bc0d45c459977638919489bb25cc4e49 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in otopi[master]: core: Dump env keys when added even if None
by Code Review 20 Jul '17

20 Jul '17

>From Yedidyah Bar David <didi(a)redhat.com>: Yedidyah Bar David has submitted this change and it was merged. ( https://gerrit.ovirt.org/79640 ) Change subject: core: Dump env keys when added even if None ...................................................................... core: Dump env keys when added even if None This can help debugging, by seeing which keys are added and when. Change-Id: Iedbffc66783dc07706397f4b324ef2ebc546504d Bug-Url: https://bugzilla.redhat.com/1328764 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M src/otopi/context.py 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Ido Rosenzwig: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Yedidyah Bar David: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/79640 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iedbffc66783dc07706397f4b324ef2ebc546504d Gerrit-PatchSet: 2 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in otopi[master]: core: Validate that keys are filtered before log creation
by Code Review 20 Jul '17

20 Jul '17

>From Yedidyah Bar David <didi(a)redhat.com>: Yedidyah Bar David has submitted this change and it was merged. ( https://gerrit.ovirt.org/79341 ) Change subject: core: Validate that keys are filtered before log creation ...................................................................... core: Validate that keys are filtered before log creation Change-Id: Idbcb56a8992dd6a8d4fac4e3ad44655e4ea55f09 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M src/otopi/constants.py M src/plugins/otopi/core/log.py 2 files changed, 29 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Yedidyah Bar David: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/79341 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idbcb56a8992dd6a8d4fac4e3ad44655e4ea55f09 Gerrit-PatchSet: 4 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in otopi[master]: Use before/after in STAGE_BOOT
by Code Review 20 Jul '17

20 Jul '17

>From Yedidyah Bar David <didi(a)redhat.com>: Yedidyah Bar David has submitted this change and it was merged. ( https://gerrit.ovirt.org/79566 ) Change subject: Use before/after in STAGE_BOOT ...................................................................... Use before/after in STAGE_BOOT Get rid of priorities, use before/after instead. Change-Id: I494ad9eba07f78aec79d15942eb0a0adeace3c99 Bug-Url: https://bugzilla.redhat.com/1472325 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M src/otopi/constants.py M src/plugins/otopi/core/config.py M src/plugins/otopi/core/log.py M src/plugins/otopi/core/misc.py M src/plugins/otopi/dialog/human.py M src/plugins/otopi/dialog/machine.py M src/plugins/otopi/dialog/misc.py M src/plugins/otopi/packagers/dnfpackager.py M src/plugins/otopi/packagers/yumpackager.py M src/plugins/otopi/system/info.py 10 files changed, 26 insertions(+), 10 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Yedidyah Bar David: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/79566 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I494ad9eba07f78aec79d15942eb0a0adeace3c99 Gerrit-PatchSet: 2 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-host-deploy[master]: Do not install collectd-virt package
by Code Review 20 Jul '17

20 Jul '17

>From Yedidyah Bar David <didi(a)redhat.com>: Yedidyah Bar David has submitted this change and it was merged. ( https://gerrit.ovirt.org/79626 ) Change subject: Do not install collectd-virt package ...................................................................... Do not install collectd-virt package collectd-virt is not required, do not insatall. Change-Id: Idd1335de2a928223960a8802e1fcc91541633362 Bug-Url: https://bugzilla.redhat.com/1473163 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M src/plugins/ovirt-host-deploy/collectd/packages.py 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Shirly Radco: Verified Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/79626 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idd1335de2a928223960a8802e1fcc91541633362 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Explicitly require JEE concurrency API
by Code Review 20 Jul '17

20 Jul '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. ( https://gerrit.ovirt.org/79615 ) Change subject: core: Explicitly require JEE concurrency API ...................................................................... core: Explicitly require JEE concurrency API A recent patch changed the 'utils' module to use the JEE concurrency API, but it didn't explicitly include the required artifact in the POM file. In some environemts this means that the project won't build correctly, in particular it doesn't build correctly in the latest version of IntelliJ IDEA. This patch adds the dependency, as it is good practice and solves the issue in this environment. Change-Id: Ib449fcd2d72c8ed3d7d3f6964264a94931e2d990 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/utils/pom.xml 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Ravi Nori: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/79615 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib449fcd2d72c8ed3d7d3f6964264a94931e2d990 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Update to model 4.2.14
by Code Review 20 Jul '17

20 Jul '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. ( https://gerrit.ovirt.org/79616 ) Change subject: restapi: Update to model 4.2.14 ...................................................................... restapi: Update to model 4.2.14 The more relevant changes in this new version of the model are the following: * Add Link Layer Discovery Protocol (LLDP). * Add a `refresh` parameter to `FilesService.list`. Change-Id: I599d44165274a89ade4249178612ac753ae7c79f Related-To: https://bugzilla.redhat.com/1414207 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostNicResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostNicsResourceTest.java M pom.xml 3 files changed, 9 insertions(+), 2 deletions(-) Approvals: Dominik Holler: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/79616 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I599d44165274a89ade4249178612ac753ae7c79f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: webadmin: Conditionally disable affinity labels widget
by Code Review 20 Jul '17

20 Jul '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. ( https://gerrit.ovirt.org/79508 ) Change subject: webadmin: Conditionally disable affinity labels widget ...................................................................... webadmin: Conditionally disable affinity labels widget This patch disables the affinity labels selection widget in the affinity labels side tab of the new/edit host and VM popups when no labels are present in the system. Change-Id: Id10e26e1e72069f02531e04bb7ecb30cd955cb8a Bug-Url: https://bugzilla.redhat.com/1465862 Signed-off-by: Phillip Bailey <phbailey(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AbstractItemSelectionWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AbstractItemSelectionWithListWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AffinityLabelSelectionWithListWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java 5 files changed, 47 insertions(+), 56 deletions(-) Approvals: Tal Nisan: Passed CI tests Alexander Wels: Looks good to me, approved Phillip Bailey: Verified -- To view, visit https://gerrit.ovirt.org/79508 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id10e26e1e72069f02531e04bb7ecb30cd955cb8a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: fence agent layout
by Code Review 19 Jul '17

19 Jul '17

>From Greg Sheremeta <gshereme(a)redhat.com>: Greg Sheremeta has submitted this change and it was merged. ( https://gerrit.ovirt.org/79620 ) Change subject: webadmin: fence agent layout ...................................................................... webadmin: fence agent layout - Fixed issue where - button was wrapping to next line in fence agents - Fixed issue where - button was wrapping to next line power management proxy preference. Change-Id: I2051f1977fb3f70f5836ab9d7b20ee995c79b950 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/FenceAgentWidget.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/HostProxySourceWidget.ui.xml 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/79620 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2051f1977fb3f70f5836ab9d7b20ee995c79b950 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: scheduling: Add support for HugePages to scheduler
by Code Review 19 Jul '17

19 Jul '17

>From Martin Sivák <msivak(a)redhat.com>: Martin Sivák has submitted this change and it was merged. ( https://gerrit.ovirt.org/79505 ) Change subject: scheduling: Add support for HugePages to scheduler ...................................................................... scheduling: Add support for HugePages to scheduler This patch adds the structure to track pending HugePage allocations and a policy unit that uses it to decide whether a host can be used to start a HugePage backed VM. Bug-Url: https://bugzilla.redhat.com/1461476 Change-Id: I64703f4f0447dadc5a09041812e99900b128e8b4 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SlaValidator.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/pending/PendingHugePages.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/HugePagesFilterPolicyUnit.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/policyunits/HugePagesFilterPolicyUnitTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 8 files changed, 382 insertions(+), 3 deletions(-) Approvals: Martin Sivák: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/79505 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I64703f4f0447dadc5a09041812e99900b128e8b4 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0