July 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: add 'vdsm-' prefix for display networks
by Code Review 31 Jul '17

31 Jul '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. ( https://gerrit.ovirt.org/79985 ) Change subject: core: add 'vdsm-' prefix for display networks ...................................................................... core: add 'vdsm-' prefix for display networks VDSM used to add the 'vdsm-' to the name of the display network that is part of the graphics device definition. We follow the same rule. Change-Id: Ibae59d9dffaf9456b80c9a7f85dbb0f5c409eda2 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/LibvirtVmXmlBuilder.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Looks good to me, but someone else must approve Arik Hadas: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/79985 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibae59d9dffaf9456b80c9a7f85dbb0f5c409eda2 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: setup: Add Engine FQDN to the answerfile
by Code Review 31 Jul '17

31 Jul '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. ( https://gerrit.ovirt.org/79455 ) Change subject: packaging: setup: Add Engine FQDN to the answerfile ...................................................................... packaging: setup: Add Engine FQDN to the answerfile Add the Engine FQDN to summary on any separate host setup Change-Id: I11ea88d2004e8ebc38cf55a026aa7e24422ca5da bug-Url: https://bugzilla.redhat.com/1465859 Signed-off-by: Ido Rosenzwig <irosenzw(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/engine/constants.py 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Ido Rosenzwig: Verified Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/79455 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I11ea88d2004e8ebc38cf55a026aa7e24422ca5da Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: db: fix direct permissions table access
by Code Review 31 Jul '17

31 Jul '17

>From Martin Peřina <mperina(a)redhat.com>: Martin Peřina has submitted this change and it was merged. ( https://gerrit.ovirt.org/79989 ) Change subject: db: fix direct permissions table access ...................................................................... db: fix direct permissions table access The following patch fixes a direct deletion of an entity and was replaced by a call to the corresponding SP Change-Id: I3093be86fc44e73f1da5b04c17f0c285423543fa Signed-off-by: emesika <emesika(a)redhat.com> --- M packaging/dbscripts/vms_sp.sql 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Martin Peřina: Looks good to me, approved Eli Mesika: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/79989 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3093be86fc44e73f1da5b04c17f0c285423543fa Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: move up Loading spinner
by Code Review 31 Jul '17

31 Jul '17

>From Alexander Wels <awels(a)redhat.com>: Alexander Wels has submitted this change and it was merged. ( https://gerrit.ovirt.org/79949 ) Change subject: webadmin: move up Loading spinner ...................................................................... webadmin: move up Loading spinner The loading spinner looked a little too low. Moved it up 120px. Change-Id: I4d2b01db05d64e3bac2aea8bfcf07b30523a1a7b Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/main/resources/META-INF/resources/GwtHostPage.jsp 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Greg Sheremeta: Verified -- To view, visit https://gerrit.ovirt.org/79949 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4d2b01db05d64e3bac2aea8bfcf07b30523a1a7b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-live[ovirt-live-4.1]: build: ovirt-live 4.1.5 rc1
by Code Review 31 Jul '17

31 Jul '17

>From Lev Veyde <lveyde(a)redhat.com>: Lev Veyde has submitted this change and it was merged. ( https://gerrit.ovirt.org/79992 ) Change subject: build: ovirt-live 4.1.5 rc1 ...................................................................... build: ovirt-live 4.1.5 rc1 Change-Id: I6bdf9f1528aa446fd326f488c05a485a39278193 Signed-off-by: Lev Veyde <lveyde(a)redhat.com> --- M centos-7/Makefile M centos-7/kickstart/ovirt-live-ovirt-custom.ks.in 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Lev Veyde: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/79992 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6bdf9f1528aa446fd326f488c05a485a39278193 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-4.1 Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: plugins: network: add warning about unsupported bonds
by Code Review 31 Jul '17

31 Jul '17

>From Simone Tiraboschi <stirabos(a)redhat.com>: Simone Tiraboschi has submitted this change and it was merged. ( https://gerrit.ovirt.org/79751 ) Change subject: plugins: network: add warning about unsupported bonds ...................................................................... plugins: network: add warning about unsupported bonds The user is warned when bonds in modes 0, 5 or 6 are configured. These bonds are excluded from the valid values and cannot be chosen by the user during setup by default. Change-Id: I0dbde6c161cd485c0b50ef0397d028d78c97e0eb Bug-Url: https://bugzilla.redhat.com/1233127 Signed-off-by: Ido Rosenzwig <irosenzw(a)redhat.com> --- M src/ovirt_hosted_engine_setup/constants.py M src/plugins/gr-he-common/network/bridge.py 2 files changed, 32 insertions(+), 0 deletions(-) Approvals: Simone Tiraboschi: Looks good to me, approved Ido Rosenzwig: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/79751 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0dbde6c161cd485c0b50ef0397d028d78c97e0eb Gerrit-PatchSet: 11 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: re-enable SSL support for OVN northdb connection
by Code Review 31 Jul '17

31 Jul '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. ( https://gerrit.ovirt.org/77807 ) Change subject: packaging: re-enable SSL support for OVN northdb connection ...................................................................... packaging: re-enable SSL support for OVN northdb connection OVN northdb SSL support had to be disabled due to an OVN bug. This is now fixed, so SSL for the northdb can be re-enabled. Change-Id: Ida02a651851715e076170706ee259945abbbe600 Signed-off-by: Marcin Mirecki <mmirecki(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1448867 --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/network/ovirtproviderovn.py 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Marcin Mirecki: Verified Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, but someone else must approve Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/77807 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ida02a651851715e076170706ee259945abbbe600 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: frontned: remove ui network name/vnic profile restrictions
by Code Review 31 Jul '17

31 Jul '17

>From Alona Kaplan <alkaplan(a)redhat.com>: Alona Kaplan has submitted this change and it was merged. ( https://gerrit.ovirt.org/79459 ) Change subject: frontned: remove ui network name/vnic profile restrictions ...................................................................... frontned: remove ui network name/vnic profile restrictions Change-Id: I86a74f3908cf6e545b8e42d3694f6058c4c5c22b Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VnicProfile.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Cloner.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/VnicProfileModel.java 4 files changed, 18 insertions(+), 25 deletions(-) Approvals: Ales Musil: Looks good to me, but someone else must approve Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Leon Goldberg: Verified Vojtech Szocs: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/79459 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I86a74f3908cf6e545b8e42d3694f6058c4c5c22b Gerrit-PatchSet: 18 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Ales Musil <amusil(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: prevent NPE when exporting networkless NIC
by Code Review 31 Jul '17

31 Jul '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. ( https://gerrit.ovirt.org/79965 ) Change subject: core: prevent NPE when exporting networkless NIC ...................................................................... core: prevent NPE when exporting networkless NIC As part of the recent changes aim to align the OVF generation in oVirt with the standard specification of OVF, we changed the OVF generator to write the actual network names in the NetworkSection rather than a single network named "Network 1". What we missed, however, is that a NIC may not be associated with any network. This leads to an NPE in the OVF generation process. Adding a null-check to prevent that. Change-Id: I7d120cfaf75f5c0036b3df0062fed2600945e4da Bug-Url: https://bugzilla.redhat.com/1476191 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfWriter.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/79965 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7d120cfaf75f5c0036b3df0062fed2600945e4da Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: AddEmptyStoragePoolCommand: set vdsmName to default ne...
by Code Review 31 Jul '17

31 Jul '17

>From Daniel Erez <derez(a)redhat.com>: Daniel Erez has submitted this change and it was merged. ( https://gerrit.ovirt.org/79971 ) Change subject: core: AddEmptyStoragePoolCommand: set vdsmName to default network ...................................................................... core: AddEmptyStoragePoolCommand: set vdsmName to default network vdsm_name must not be null; Set vdsmName to the default network created in addDefaultNetworks. This patch fixes OST that was broken by https://gerrit.ovirt.org/#/c/79116/ Change-Id: Ie76729c169915a0fdfc7dc322cbdec099d41c693 Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/AddEmptyStoragePoolCommand.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Leon Goldberg: Verified -- To view, visit https://gerrit.ovirt.org/79971 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie76729c169915a0fdfc7dc322cbdec099d41c693 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0