July 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: report DefaultRoute ReportedConfiguration for every ne...
by Code Review 16 Jul '17

16 Jul '17

>From Alona Kaplan <alkaplan(a)redhat.com>: Alona Kaplan has submitted this change and it was merged. ( https://gerrit.ovirt.org/78010 ) Change subject: core: report DefaultRoute ReportedConfiguration for every network ...................................................................... core: report DefaultRoute ReportedConfiguration for every network before default route in-sync/out-of-sync was reported only for network, which has default route role. This might be confusing and has some negative side-effects. Now this will be reported for every network, where all other networks than one having default route role will be always in-sync. Change-Id: Ifa2f8dbc2118e1f14fc7f6f7bd9d9d7b416eab9a Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkInSyncWithVdsNetworkInterface.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/NetworkInSyncWithVdsNetworkInterfaceTest.java 2 files changed, 42 insertions(+), 35 deletions(-) Approvals: Martin Mucha: Verified Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78010 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifa2f8dbc2118e1f14fc7f6f7bd9d9d7b416eab9a Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: Refine live merge validation
by Code Review 16 Jul '17

16 Jul '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. ( https://gerrit.ovirt.org/79094 ) Change subject: core: Refine live merge validation ...................................................................... core: Refine live merge validation Currently, there is a validation that disable running concurrent live merge even for snapshots that created on different disks. In this patch, validation is refined to disable executing concurrent live merge operations only if the snapshots contain same disk(s). Note that this new validation is only used for live merge. There are other operations (add Vm from snapshot, create Vm template, migrate Vm and remove Vm) that will still use the previous validation. In case we decide we want to refine the validation for those operations, this will be done in separate patches. Change-Id: I984b4ccf10993e982363e8b35871e97fed57e56e Bug-Url: https://bugzilla.redhat.com/1465539 Signed-off-by: Ala Hino <ahino(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/snapshots/RemoveSnapshotCommandTest.java 3 files changed, 66 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Ala Hino: Verified -- To view, visit https://gerrit.ovirt.org/79094 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I984b4ccf10993e982363e8b35871e97fed57e56e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Benny Zlotnik <bzlotnik(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: different DC/Cluster UUID per installation
by Code Review 16 Jul '17

16 Jul '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. ( https://gerrit.ovirt.org/79442 ) Change subject: core: different DC/Cluster UUID per installation ...................................................................... core: different DC/Cluster UUID per installation Generate different UUID for Cluster/DC per installation. The default UUID of Cluster/DC was changed and should be changed in the script in order to generate a unique UUID per installation. Change-Id: I1491f7743be8b5ddb93b6ac00e0120710f0bce08 Bug-Url: https://bugzilla.redhat.com/1468968 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M packaging/dbscripts/dbfunc-custom.sh 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Eli Mesika: Verified; Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/79442 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1491f7743be8b5ddb93b6ac00e0120710f0bce08 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: DiskValidator#isDiskAttachedToAnyVm streams
by Code Review 16 Jul '17

16 Jul '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. ( https://gerrit.ovirt.org/79334 ) Change subject: core: DiskValidator#isDiskAttachedToAnyVm streams ...................................................................... core: DiskValidator#isDiskAttachedToAnyVm streams This patches changes the implementation of the isDiskAttachedToAnyVm method to first generate the list of offending VM names (which should be a non-op if there are none), and then perform the check on the generated string instead of the original list. While this patch doesn't have too much meaning on its own, it sets up the subsequent patch, which will add another filter clause to the aforementioned stream. Change-Id: I7c89929c040c9e6cb7913b24ba2484db34562752 Related-To: https://bugzilla.redhat.com/1414499 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/DiskValidator.java 1 file changed, 8 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/79334 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7c89929c040c9e6cb7913b24ba2484db34562752 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: Allow transferring images for down VMs
by Code Review 16 Jul '17

16 Jul '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. ( https://gerrit.ovirt.org/79335 ) Change subject: core: Allow transferring images for down VMs ...................................................................... core: Allow transferring images for down VMs Currently, DiskValidator#isDiskAttachedToAnyVm() is used to block image transfers on all non-floating disks. This behavior seems to be a bit too naive, as there's no storage-related not to upload/download an image that happens to have a database entry that ties it to a VM. For simplicity's sake, the operation is still blocked for any status other than DOWN. In the future, we can consider refining this restriction. Change-Id: Ia313a451f7642b10b1ee3a46d2ce1bdd1d2fa061 Bug-Url: https://bugzilla.redhat.com/1414499 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/TransferDiskImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/DiskValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/image/TransferDiskImageCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/storage/DiskValidatorTest.java 4 files changed, 24 insertions(+), 11 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/79335 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia313a451f7642b10b1ee3a46d2ce1bdd1d2fa061 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: Allow transferring for unplugged disks
by Code Review 16 Jul '17

16 Jul '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. ( https://gerrit.ovirt.org/79336 ) Change subject: core: Allow transferring for unplugged disks ...................................................................... core: Allow transferring for unplugged disks If a disk is not plugged to a VM, the VM's status is inconsequential. This patch refines the validation to ignore unplugged disks Change-Id: I761546f9e41daf74306863ce48f30003fa2de8fd Bug-Url: https://bugzilla.redhat.com/1414499 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/TransferDiskImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/DiskValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/image/TransferDiskImageCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/storage/DiskValidatorTest.java 4 files changed, 43 insertions(+), 27 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/79336 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I761546f9e41daf74306863ce48f30003fa2de8fd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: Sort results of DiskValidator#isDiskAPluggedToAnyNonDo...
by Code Review 16 Jul '17

16 Jul '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. ( https://gerrit.ovirt.org/79337 ) Change subject: core: Sort results of DiskValidator#isDiskAPluggedToAnyNonDownVm ...................................................................... core: Sort results of DiskValidator#isDiskAPluggedToAnyNonDownVm Change-Id: I0872fcca50ed21749b7c1477417b1a27efd3c7f4 Bug-Url: https://bugzilla.redhat.com/1414499 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/DiskValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/storage/DiskValidatorTest.java 2 files changed, 2 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/79337 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0872fcca50ed21749b7c1477417b1a27efd3c7f4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: set new Pool's images format to COW for 'auto select t...
by Code Review 16 Jul '17

16 Jul '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. ( https://gerrit.ovirt.org/79286 ) Change subject: core: set new Pool's images format to COW for 'auto select target' ...................................................................... core: set new Pool's images format to COW for 'auto select target' In case new pool is created based on a template with disk(s) and the 'Auto select target' checkbox (in 'Resource allocation' tab) is set, all Pool VM's images are required to be created with volume format set to the same format as the template's disk (RAW or COW). If RAW format is required for the Pool VM's images, then the Pool creation failed on validation phase. Because of that problem, the 'auto select target' feature isn't working and it is a regression (the regression was added in change id: I6f0f143). This patch fixes it by setting each diskImage.volumeFormat of the Pool's template to COW (or RAW if the disk storage type is CINDER) before creating the Pool's VMs. Change-Id: I9fd04cbcea08125e06c0b9ffb237bcb53057a61a Bug-Url: https://bugzilla.redhat.com/1468301 Signed-off-by: Sharon Gratch <sgratch(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolCommand.java 1 file changed, 16 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Sharon Gratch: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/79286 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9fd04cbcea08125e06c0b9ffb237bcb53057a61a Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: make hosts table status icon column wider
by Code Review 14 Jul '17

14 Jul '17

>From Alexander Wels <awels(a)redhat.com>: Alexander Wels has submitted this change and it was merged. ( https://gerrit.ovirt.org/79434 ) Change subject: webadmin: make hosts table status icon column wider ...................................................................... webadmin: make hosts table status icon column wider When the alert icon is displayed in the status icon column of the host table, it was getting cut off. The column width has been increased to allow it to be seen with the standard icons. Status icons wider then 19px (currently only the error status) will still cause the alert icon to be only partially rendered. Change-Id: I37474f9ded7cfd25222070216ae9d031b411e1ec Signed-off-by: Scott J Dickerson <sdickers(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabHostView.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Scott Dickerson: Verified -- To view, visit https://gerrit.ovirt.org/79434 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I37474f9ded7cfd25222070216ae9d031b411e1ec Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Scott Dickerson <sdickers(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove unused mocking from MacPoolPerClusterTest
by Code Review 14 Jul '17

14 Jul '17

>From Martin Betak <mbetak(a)redhat.com>: Martin Betak has submitted this change and it was merged. ( https://gerrit.ovirt.org/79408 ) Change subject: core: Remove unused mocking from MacPoolPerClusterTest ...................................................................... core: Remove unused mocking from MacPoolPerClusterTest Change-Id: I28046f395452f77713496fcc9e368e011b39f9c9 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/macpool/MacPoolPerClusterTest.java 1 file changed, 0 insertions(+), 6 deletions(-) Approvals: Martin Mucha: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Martin Betak: Verified Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/79408 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I28046f395452f77713496fcc9e368e011b39f9c9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0