July 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-4.1]: packaging: Add --after option to engine-host-update
by Code Review 05 Jul '17

05 Jul '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. ( https://gerrit.ovirt.org/78994 ) Change subject: packaging: Add --after option to engine-host-update ...................................................................... packaging: Add --after option to engine-host-update Bug-Url: Bug-Url: https://bugzilla.redhat.com/1467654 Change-Id: I3b09efac8fd2b1ccdbc52979bc196fe4a6572697 Signed-off-by: Lev Veyde <lveyde(a)redhat.com> --- M packaging/bin/engine-host-update.py 1 file changed, 27 insertions(+), 3 deletions(-) Approvals: Lev Veyde: Verified Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/78994 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3b09efac8fd2b1ccdbc52979bc196fe4a6572697 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: packaging: Added host-update FET
by Code Review 05 Jul '17

05 Jul '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. ( https://gerrit.ovirt.org/78989 ) Change subject: packaging: Added host-update FET ...................................................................... packaging: Added host-update FET Added host-update Field Engineering Tool. The tools allows to easily update RHEL-H hosts. Bug-Url: https://bugzilla.redhat.com/1467654 Change-Id: Iea497a82483c1a2533d8c7d948c9800a9fa051a2 Signed-off-by: Lev Veyde <lveyde(a)redhat.com> --- M ovirt-engine.spec.in A packaging/bin/engine-host-update.py 2 files changed, 789 insertions(+), 0 deletions(-) Approvals: Lev Veyde: Verified Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/78989 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iea497a82483c1a2533d8c7d948c9800a9fa051a2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: packaging: engine-host-update code cleanup
by Code Review 05 Jul '17

05 Jul '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. ( https://gerrit.ovirt.org/78990 ) Change subject: packaging: engine-host-update code cleanup ...................................................................... packaging: engine-host-update code cleanup Bug-Url: https://bugzilla.redhat.com/1467654 Change-Id: Id436f27c184864e142e1ad8abd0afac523aad342 Signed-off-by: Lev Veyde <lveyde(a)redhat.com> --- M packaging/bin/engine-host-update.py 1 file changed, 56 insertions(+), 133 deletions(-) Approvals: Lev Veyde: Verified Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/78990 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id436f27c184864e142e1ad8abd0afac523aad342 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: util: force global json rpc client deletion on exit
by Code Review 05 Jul '17

05 Jul '17

>From Simone Tiraboschi <stirabos(a)redhat.com>: Simone Tiraboschi has submitted this change and it was merged. ( https://gerrit.ovirt.org/79010 ) Change subject: util: force global json rpc client deletion on exit ...................................................................... util: force global json rpc client deletion on exit Force the deletion of the global json rpc client on exit by explicitly deleting the module before exiting since it holds a reference to the client in order to avoid expection on exit. Change-Id: I31dd4009d5aaf0ddd3b2ca97d1e7983b5e4d57c2 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1467362 --- M src/ovirt_hosted_engine_setup/vdsm_helper.py 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Simone Tiraboschi: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Jenny Tokar: Verified; Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/79010 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I31dd4009d5aaf0ddd3b2ca97d1e7983b5e4d57c2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: db: support for unique index in common func
by Code Review 05 Jul '17

05 Jul '17

>From Eli Mesika <emesika(a)redhat.com>: Eli Mesika has submitted this change and it was merged. ( https://gerrit.ovirt.org/78982 ) Change subject: db: support for unique index in common func ...................................................................... db: support for unique index in common func Adding support for the "UNIQUE" flag when creating an index. Change-Id: Ia9d82a72d52647bea6e53a33a450ed2580ca888b Signed-off-by: emesika <emesika(a)redhat.com> --- M packaging/dbscripts/common_sp.sql M packaging/dbscripts/upgrade/04_00_0110_add_index_on_vm_static.sql M packaging/dbscripts/upgrade/04_00_0640_add_index_on_vm_device.sql M packaging/dbscripts/upgrade/04_00_0700_create_label_tables.sql M packaging/dbscripts/upgrade/04_01_0220_memory_and_disk_images_storage_domain_view_join_indexes.sql M packaging/dbscripts/upgrade/04_01_0570_add_vm_affinity_to_host_structure.sql M packaging/dbscripts/upgrade/04_02_0200_add_disk_content_type.sql 7 files changed, 19 insertions(+), 13 deletions(-) Approvals: Eli Mesika: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/78982 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia9d82a72d52647bea6e53a33a450ed2580ca888b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: db: do not execute sql files as shell scripts
by Code Review 05 Jul '17

05 Jul '17

>From Eli Mesika <emesika(a)redhat.com>: Eli Mesika has submitted this change and it was merged. ( https://gerrit.ovirt.org/78778 ) Change subject: db: do not execute sql files as shell scripts ...................................................................... db: do not execute sql files as shell scripts This patch insures that id SQL scripts have the executable flag set that the upgrade will not try to execute them as shell scripts. Change-Id: If0e38818de1b53f07e57ccacbb1924d534869ece Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1464735 Signed-off-by: emesika <emesika(a)redhat.com> --- M packaging/dbscripts/dbfunc-common.sh 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Eli Mesika: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/78778 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If0e38818de1b53f07e57ccacbb1924d534869ece Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Allow slash at the end of NFS mount point string
by Code Review 05 Jul '17

05 Jul '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. ( https://gerrit.ovirt.org/73285 ) Change subject: engine: Allow slash at the end of NFS mount point string ...................................................................... engine: Allow slash at the end of NFS mount point string Change-Id: Ie053cde3a353412706d1deeaba32be9b94382498 Bug-Url: https://bugzilla.redhat.com/1425879 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/NfsMountPointConstraint.java M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/validation/NfsMountPointConstraintTest.java 2 files changed, 2 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Ondřej Svoboda: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/73285 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie053cde3a353412706d1deeaba32be9b94382498 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda <osvoboda(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: rename NFSMountPointConstraintTest to match the clas...
by Code Review 05 Jul '17

05 Jul '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. ( https://gerrit.ovirt.org/72967 ) Change subject: engine: rename NFSMountPointConstraintTest to match the class it checks ...................................................................... engine: rename NFSMountPointConstraintTest to match the class it checks Change-Id: I701c9967d0982136656e3e583569f5e2aad77604 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- R backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/validation/NfsMountPointConstraintTest.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/72967 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I701c9967d0982136656e3e583569f5e2aad77604 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: Make VmAnalyzer to treat a migrated Paused VM as success
by Code Review 05 Jul '17

05 Jul '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. ( https://gerrit.ovirt.org/78924 ) Change subject: core: Make VmAnalyzer to treat a migrated Paused VM as success ...................................................................... core: Make VmAnalyzer to treat a migrated Paused VM as success 1. When a VM is unexpectedly reported on a different host in Paused state, treat this as successful migration, much like the same situation with VM in Up state. (POSTCOPY paused state is excluded from this case.) 2. When a VM switches from MigratingTo to Paused, treat this as migration success, the same as switching from MigratingTo to Up. (POSTCOPY does not appear in this situation, because it comes after MigratingFrom.) Change-Id: I189d64cd0280244f8599c6e8d7c0c48c9d949350 Bug-Url: https://bugzilla.redhat.com/1454459 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/78924 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I189d64cd0280244f8599c6e8d7c0c48c9d949350 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: ModelListTreeViewModel type inference
by Code Review 05 Jul '17

05 Jul '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/79009 ) Change subject: webadmin: ModelListTreeViewModel type inference ...................................................................... webadmin: ModelListTreeViewModel type inference Change-Id: I91426295376609473178a137cd397f6a6f0653b1 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uicommon/model/ModelListTreeViewModel.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/79009 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I91426295376609473178a137cd397f6a6f0653b1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0