July 2017 - Engine-commits - oVirt List Archives

Change in ovirt-dwh[master]: packaging: Add a tool to perform vacuum on dwh db
by Code Review 25 Jul '17

25 Jul '17

>From Shirly Radco <sradco(a)redhat.com>: Shirly Radco has submitted this change and it was merged. ( https://gerrit.ovirt.org/79294 ) Change subject: packaging: Add a tool to perform vacuum on dwh db ...................................................................... packaging: Add a tool to perform vacuum on dwh db This tool can perform various vacuum operations without specifying the ovirt_engine_history db credentials. >From the tool usage: -a - analyze -A - analyze only -f - full vacuum -t - table(s) to vacuum. Use multi -t table for multi tables -v - verbose Change-Id: I4e77e32928b427a6838e76d1d37c963f7d954815 Bug-Url: https://bugzilla.redhat.com/1409766 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M .gitignore M Makefile M ovirt-engine-dwh.spec.in A packaging/bin/dwh-prolog.sh.in A packaging/bin/dwh-vacuum.sh A packaging/bin/generate-pgpass.sh M packaging/setup/ovirt_engine_setup/dwh/constants.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/db/__init__.py A packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/db/vacuum.py 9 files changed, 276 insertions(+), 0 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/79294 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4e77e32928b427a6838e76d1d37c963f7d954815 Gerrit-PatchSet: 16 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: upgrade: unset XDG_RUNTIME_DIR before calling libguestfs
by Code Review 25 Jul '17

25 Jul '17

>From Simone Tiraboschi <stirabos(a)redhat.com>: Simone Tiraboschi has submitted this change and it was merged. ( https://gerrit.ovirt.org/79755 ) Change subject: upgrade: unset XDG_RUNTIME_DIR before calling libguestfs ...................................................................... upgrade: unset XDG_RUNTIME_DIR before calling libguestfs Newer (> 1.32 - RHEL 7.4) version of libguestfs relies on the value of XDG_RUNTIME_DIR, if set, to choose its temporary directory. Since we are changing from root user to vdsm user, we have to unset XDG_RUNTIME_DIR as well. Bug-Url: https://bugzilla.redhat.com/1467813 Change-Id: Icda24ad4cc381126ddc094377babf413457e5eb7 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/plugins/gr-he-common/vm/boot_disk.py 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Simone Tiraboschi: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/79755 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icda24ad4cc381126ddc094377babf413457e5eb7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Add 4.1 branch to ovirt-ansible job
by Code Review 25 Jul '17

25 Jul '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. ( https://gerrit.ovirt.org/79766 ) Change subject: Add 4.1 branch to ovirt-ansible job ...................................................................... Add 4.1 branch to ovirt-ansible job Change-Id: I1f2ccd5b90a9c5f398a4236dbb6a32704c7e1d58 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M jobs/confs/projects/ovirt-ansible/ovirt-ansible.yaml 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/79766 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1f2ccd5b90a9c5f398a4236dbb6a32704c7e1d58 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>

1 0

Change in ovirt-engine[master]: remove collectd-virt from CheckUpdate
by Code Review 25 Jul '17

25 Jul '17

>From Martin Peřina <mperina(a)redhat.com>: Martin Peřina has submitted this change and it was merged. ( https://gerrit.ovirt.org/79543 ) Change subject: remove collectd-virt from CheckUpdate ...................................................................... remove collectd-virt from CheckUpdate collectd-virt is not required anymore, removing it from the upgrade check. Change-Id: I5832b8279d4ef1444e15edb40fb5096cc0134b2a Bug-Url: https://bugzilla.redhat.com/1473171 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Martin Peřina: Looks good to me, approved Shirly Radco: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/79543 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5832b8279d4ef1444e15edb40fb5096cc0134b2a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[ovirt-log-collector-4.1]: inventory: Add MAC Pools section
by Code Review 24 Jul '17

24 Jul '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. ( https://gerrit.ovirt.org/79771 ) Change subject: inventory: Add MAC Pools section ...................................................................... inventory: Add MAC Pools section Display MAC Pool data Change-Id: If0d5bbcf176d785681a13f74709134f751d1643e Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/Makefile.am M src/inventory_report/produceReport/produceReport.sh A src/inventory_report/produceReport/sqls/mac_pools_query_show_data_based_on_datacenter_and_cluster.sql 3 files changed, 64 insertions(+), 0 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/79771 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If0d5bbcf176d785681a13f74709134f751d1643e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-4.1 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[master]: inventory: Add MAC Pools section
by Code Review 24 Jul '17

24 Jul '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. ( https://gerrit.ovirt.org/79655 ) Change subject: inventory: Add MAC Pools section ...................................................................... inventory: Add MAC Pools section Display MAC Pool data Change-Id: If0d5bbcf176d785681a13f74709134f751d1643e Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/Makefile.am M src/inventory_report/produceReport/produceReport.sh A src/inventory_report/produceReport/sqls/mac_pools_query_show_data_based_on_datacenter_and_cluster.sql 3 files changed, 64 insertions(+), 0 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Martin Mucha: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/79655 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If0d5bbcf176d785681a13f74709134f751d1643e Gerrit-PatchSet: 6 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: frontend: Repair of spacing between text and checkbox
by Code Review 24 Jul '17

24 Jul '17

>From Alona Kaplan <alkaplan(a)redhat.com>: Alona Kaplan has submitted this change and it was merged. ( https://gerrit.ovirt.org/79331 ) Change subject: frontend: Repair of spacing between text and checkbox ...................................................................... frontend: Repair of spacing between text and checkbox Checkbox in data centers -> logical networks -> new page should not overlap the text anymore. Change-Id: Iede388363379d8c82214f896dc58717307863ad0 Signed-off-by: Ales Musil <amusil(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1433923 --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Ales Musil: Verified Dominik Holler: Looks good to me, but someone else must approve Alexander Wels: Looks good to me, approved Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests Vojtech Szocs: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/79331 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iede388363379d8c82214f896dc58717307863ad0 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ales Musil <amusil(a)redhat.com> Gerrit-Reviewer: Ales Musil <amusil(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Improve email message from change queue
by Code Review 24 Jul '17

24 Jul '17

>From Barak Korren <bkorren(a)redhat.com>: Barak Korren has submitted this change and it was merged. ( https://gerrit.ovirt.org/78491 ) Change subject: Improve email message from change queue ...................................................................... Improve email message from change queue There are two cases where changes can fail CQ testing but not be the root cause for failure: 1. Either a change explicitly depends on another change that failed 2. Or a change is based on a failing change and therefore includes the failing code or artifacts The system as it built currently, cannot easily tell these two cases apart. Therefore, the same email message is sent for both. So far the message was written in such a way that assumes case #1. With the current system, however, case #2 is far more likely. This patch attempts to change the language in the failing email to better indicate this. This patch also: * Adds the queue name to the subject of the email messages * Make email subject lines start with '[CQ]:' * Include the queue name in the email subject lines Change-Id: I11a511c8b4cdb5b2838e64cd592e0296b8cae862 Jira-Ticket: https://ovirt-jira.atlassian.net/browse/OVIRT-1077 Signed-off-by: Barak Korren <bkorren(a)redhat.com> --- M scripts/change_queue/changes/templates/added-email.txt.j2 M scripts/change_queue/changes/templates/failed-email.txt.j2 M scripts/change_queue/changes/templates/rejected-email.txt.j2 M scripts/change_queue/changes/templates/successful-email.txt.j2 4 files changed, 16 insertions(+), 11 deletions(-) Approvals: Barak Korren: Verified; Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78491 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I11a511c8b4cdb5b2838e64cd592e0296b8cae862 Gerrit-PatchSet: 9 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>

1 0

Change in jenkins[master]: Make the standard-enqueue job not use silent mode
by Code Review 24 Jul '17

24 Jul '17

>From Barak Korren <bkorren(a)redhat.com>: Barak Korren has submitted this change and it was merged. ( https://gerrit.ovirt.org/79300 ) Change subject: Make the standard-enqueue job not use silent mode ...................................................................... Make the standard-enqueue job not use silent mode It seems that making jobs use the 'silent' mode of the Gerrit trigger plugin can cause issues with the reporting of results of non-silent jobs (See example issue in the Jira ticket). This patch makes the 'standard-enqueue' job stop using the silent mode, and instead send meaningful results to Gerrit. Change-Id: I95f8dc76b967aed7a581465fdba041706429cce7 Signed-off-by: Barak Korren <bkorren(a)redhat.com> Jira-Ticket: https://ovirt-jira.atlassian.net/browse/OVIRT-1502 --- M jobs/confs/yaml/templates/standard-enqueue.yaml 1 file changed, 27 insertions(+), 1 deletion(-) Approvals: Barak Korren: Verified; Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/79300 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I95f8dc76b967aed7a581465fdba041706429cce7 Gerrit-PatchSet: 5 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>

1 0

Change in jenkins[master]: Added upgrade suits to CQ testing
by Code Review 24 Jul '17

24 Jul '17

>From Barak Korren <bkorren(a)redhat.com>: Barak Korren has submitted this change and it was merged. ( https://gerrit.ovirt.org/78278 ) Change subject: Added upgrade suits to CQ testing ...................................................................... Added upgrade suits to CQ testing Change-Id: I5ac3d16f099db315f07e5032e9cc06f1666d0717 Jira-Ticket: https://ovirt-jira.atlassian.net/browse/OVIRT-1449 Signed-off-by: Barak Korren <bkorren(a)redhat.com> --- M pipelines/ovirt_change-queue-tester.groovy 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Barak Korren: Verified; Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78278 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5ac3d16f099db315f07e5032e9cc06f1666d0717 Gerrit-PatchSet: 9 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>

1 0