August 2017 - Engine-commits - oVirt List Archives

Change in jenkins[master]: Separate jenkins diffs folders
by Code Review 27 Aug '17

27 Aug '17

>From Barak Korren <bkorren(a)redhat.com>: Barak Korren has submitted this change and it was merged. ( https://gerrit.ovirt.org/80161 ) Change subject: Separate jenkins diffs folders ...................................................................... Separate jenkins diffs folders This patch fixes two main issues: 1) We do not want to have git changes in the original workspace. For that we will create a temporary folder for running the JJB in order to create the old_xmls 2) Jenkins check-patch diffed the current patch with the current master which was wrong. We actually want to diff the current patch with the master it was on. Some additional changes: 1) Removed execution of check_publishers_not_deleted.py from check-patch.sh and added it to jenkins_check_yaml.sh 2) Changed the code of jenkins_check_yaml.sh to be a bit more modular. Without global parameters and with functions Change-Id: Idb16bb01e07f952a00ed88ea2ea6bdc4b835f73d Signed-off-by: Gil Shinar <gshinar(a)redhat.com> --- M automation/check-patch.sh M automation/check_publishers_not_deleted.py M automation/jenkins_check_yaml.sh 3 files changed, 89 insertions(+), 68 deletions(-) Approvals: Barak Korren: Looks good to me, approved; Ready for merge Gil Shinar: Verified; Ready for review Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/80161 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idb16bb01e07f952a00ed88ea2ea6bdc4b835f73d Gerrit-PatchSet: 9 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Dafna Ron <dron(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: Staging Jenkins Server

1 0

Change in jenkins[master]: Make STD-CI pipeline waste less nodes
by Code Review 27 Aug '17

27 Aug '17

>From Barak Korren <bkorren(a)redhat.com>: Barak Korren has submitted this change and it was merged. ( https://gerrit.ovirt.org/80940 ) Change subject: Make STD-CI pipeline waste less nodes ...................................................................... Make STD-CI pipeline waste less nodes STD-CI pipeline needs a node to initially clone sources to, get pipeline code from and do STD-CI YAML parsing on. So far the pipelien kept that node while it was running the actual STD-CI tasks on other nods. This path changes things so the node is released when it is not needed. Change-Id: I0a6da849c075c805489fe5591c37af02e180c4d0 Signed-off-by: Barak Korren <bkorren(a)redhat.com> Jira-Ticket: https://ovirt-jira.atlassian.net/browse/OVIRT-1522 --- M pipelines/standard-stage.groovy 1 file changed, 60 insertions(+), 45 deletions(-) Approvals: Barak Korren: Verified; Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/80940 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0a6da849c075c805489fe5591c37af02e180c4d0 Gerrit-PatchSet: 4 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>

1 0

Change in jenkins[master]: Apply timestamps and colors to all pipeline output
by Code Review 27 Aug '17

27 Aug '17

>From Barak Korren <bkorren(a)redhat.com>: Barak Korren has submitted this change and it was merged. ( https://gerrit.ovirt.org/80981 ) Change subject: Apply timestamps and colors to all pipeline output ...................................................................... Apply timestamps and colors to all pipeline output Change the pipeline-loader.groovy to make it apply timestamps and ANSI colors to output from all parts of the pipeline. Previously it only applied these setting to parts running on the node the loader allocates for lading pipeline code and doing initialization or single-node work because of the way older versions of these plugins worked. Change-Id: I9142df4a393a8e78fbb69408a157e461dec3d579 Signed-off-by: Barak Korren <bkorren(a)redhat.com> Jira-Ticket: https://ovirt-jira.atlassian.net/browse/OVIRT-1404 --- M jobs/confs/groovy-scripts/pipeline-loader.groovy 1 file changed, 24 insertions(+), 22 deletions(-) Approvals: Barak Korren: Verified; Looks good to me, approved; Ready for merge Gil Shinar: Looks good to me Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/80981 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9142df4a393a8e78fbb69408a157e461dec3d579 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Dafna Ron <dron(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>

1 0

Change in jenkins[master]: Implement STD-CI pre-merge with a pipeline
by Code Review 27 Aug '17

27 Aug '17

>From Barak Korren <bkorren(a)redhat.com>: Barak Korren has submitted this change and it was merged. ( https://gerrit.ovirt.org/80227 ) Change subject: Implement STD-CI pre-merge with a pipeline ...................................................................... Implement STD-CI pre-merge with a pipeline Put implementation of STD-CI in one pipline. This has a few benefits: 1. You need to define just one job per-project in YAML as opposed to a job for every OS and arch. 2. Since its a single job, this will eliminate the issue of having the GitHub PR trigger spam PRs with whitelist messages 3. Groovy is far more flexible the YAML, so it will be easier to add features in the future The biggest shortcoming of this is that it will be harder to know which job does what by looking at the running jobs. Will try to make this easier by manipulating job build names. Adding just a manual job for now, will add more jobs to trigger on other things in later patches Change-Id: I4fa233a31ce04b6fcd95784fc98c1d85f529a18a Signed-off-by: Barak Korren <bkorren(a)redhat.com> Jira-Ticket: https://ovirt-jira.atlassian.net/browse/OVIRT-1522 --- M jobs/confs/groovy-scripts/pipeline-loader.groovy A jobs/confs/staging-projects/standard-pipelines.yaml A jobs/confs/yaml/templates/standard-pipeline.yaml A pipelines/standard-stage.groovy 4 files changed, 401 insertions(+), 3 deletions(-) Approvals: Barak Korren: Verified; Looks good to me, approved; Ready for merge Gil Shinar: Looks good to me Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/80227 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4fa233a31ce04b6fcd95784fc98c1d85f529a18a Gerrit-PatchSet: 31 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: Staging Jenkins Server

1 0

Change in ovirt-engine[master]: webadmin: SubTabNetworkHostView improved type inference
by Code Review 27 Aug '17

27 Aug '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/81069 ) Change subject: webadmin: SubTabNetworkHostView improved type inference ...................................................................... webadmin: SubTabNetworkHostView improved type inference This patch improves the type inference of SubTabNetworkHostView to make it a tad less robust and easier to read. Note that in "pure" Java specifying the type of p would not be required, but GWT's compiler isn't as powerful, and requires this specification. Change-Id: I123dc2ac18f2c09585647b43be60faaaa9c7fcef Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkHostView.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/81069 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I123dc2ac18f2c09585647b43be60faaaa9c7fcef Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: ClusterManageNetworkPopupView type inference
by Code Review 27 Aug '17

27 Aug '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/81071 ) Change subject: webadmin: ClusterManageNetworkPopupView type inference ...................................................................... webadmin: ClusterManageNetworkPopupView type inference Change-Id: I260ce77a6154da83203187c947c28ff3bd54461d Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterManageNetworkPopupView.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/81071 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I260ce77a6154da83203187c947c28ff3bd54461d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: ClusterManageNetworkPopupView diamond opetator
by Code Review 27 Aug '17

27 Aug '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/81072 ) Change subject: webadmin: ClusterManageNetworkPopupView diamond opetator ...................................................................... webadmin: ClusterManageNetworkPopupView diamond opetator Change-Id: Ied603f8c08490f6fa234e828091c0d78fee27007 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterManageNetworkPopupView.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/81072 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ied603f8c08490f6fa234e828091c0d78fee27007 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Add support for env var requests in mock_runner
by Code Review 27 Aug '17

27 Aug '17

>From Barak Korren <bkorren(a)redhat.com>: Barak Korren has submitted this change and it was merged. ( https://gerrit.ovirt.org/80350 ) Change subject: Add support for env var requests in mock_runner ...................................................................... Add support for env var requests in mock_runner This patch adds support to specify "${stage}.environment.yaml" file, which includes requests for environmental vars (YAML) to be available inside mock's env. The vars are processed by 'secrets_client' so the request may contain a request for secret, or a request for a specified value. Example for such file: - name: VAR_NAME valueFrom: secretKeyRef: name: 'required secret name' key: 'required key from the secret specified above' - name: ANOTHER_VAR value: 'some custom value' Jira: https://ovirt-jira.atlassian.net/browse/OVIRT-894 Change-Id: I89518d337a6c58a3f1952b82953b264e491a2634 Signed-off-by: Daniel Belenky <dbelenky(a)redhat.com> --- M mock_configs/mock_runner.sh 1 file changed, 43 insertions(+), 1 deletion(-) Approvals: Barak Korren: Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests Daniel Belenky: Verified -- To view, visit https://gerrit.ovirt.org/80350 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I89518d337a6c58a3f1952b82953b264e491a2634 Gerrit-PatchSet: 12 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Dafna Ron <dron(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: Staging Jenkins Server

1 0

Change in jenkins[master]: Migrate manual OST to a proper template
by Code Review 27 Aug '17

27 Aug '17

>From Barak Korren <bkorren(a)redhat.com>: Barak Korren has submitted this change and it was merged. ( https://gerrit.ovirt.org/80863 ) Change subject: Migrate manual OST to a proper template ...................................................................... Migrate manual OST to a proper template In order to use the manual job in D/S, we need to separate the job to a proper pair of template and project. Jira: https://ovirt-jira.atlassian.net/browse/OVIRT-1604 Change-Id: I113216f948ebb434c60a13556cd3b33a1f5aef98 Signed-off-by: Daniel Belenky <dbelenky(a)redhat.com> --- M jobs/confs/projects/ovirt/system-tests.yaml A jobs/confs/yaml/parmeters/ost-input-customizations.yaml A jobs/confs/yaml/parmeters/ost-suite-selector-ovirt.yaml R jobs/confs/yaml/parmeters/ost-version-selector-ovirt.yaml M jobs/confs/yaml/templates/system_tests_templates.yaml 5 files changed, 99 insertions(+), 74 deletions(-) Approvals: Barak Korren: Looks good to me, approved; Ready for merge Daniel Belenky: Verified; Ready for review Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/80863 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I113216f948ebb434c60a13556cd3b33a1f5aef98 Gerrit-PatchSet: 17 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>

1 0

Change in jenkins[master]: Fix docker login to match all versions of docker
by Code Review 27 Aug '17

27 Aug '17

>From Barak Korren <bkorren(a)redhat.com>: Barak Korren has submitted this change and it was merged. ( https://gerrit.ovirt.org/80966 ) Change subject: Fix docker login to match all versions of docker ...................................................................... Fix docker login to match all versions of docker Change-Id: Ib86c4218eb7e3ebe3cef112ab31cd50b8a61ba09 --- M jobs/confs/shell-scripts/collect_artifacts.sh 1 file changed, 16 insertions(+), 3 deletions(-) Approvals: Barak Korren: Looks good to me, approved; Ready for merge Gil Shinar: Looks good to me Daniel Belenky: Verified; Ready for review Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/80966 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib86c4218eb7e3ebe3cef112ab31cd50b8a61ba09 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: Yuval Turgeman <yturgema(a)redhat.com>

1 0