August 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Improve StorageDomainStaticDaoTest assertions
by Code Review 08 Aug '17

08 Aug '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/80255 ) Change subject: core: Improve StorageDomainStaticDaoTest assertions ...................................................................... core: Improve StorageDomainStaticDaoTest assertions Assert the equality of the StorageDomainStatic objects instead of just their IDs. Change-Id: I55f3cff086b4567159510131cc37bd06213a47c7 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageDomainStaticDaoTest.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/80255 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I55f3cff086b4567159510131cc37bd06213a47c7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Reuse FixturesTool.CLUSTER in DAO tests
by Code Review 08 Aug '17

08 Aug '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/80257 ) Change subject: core: Reuse FixturesTool.CLUSTER in DAO tests ...................................................................... core: Reuse FixturesTool.CLUSTER in DAO tests Change-Id: I2351d98d3f8a87c0798223c637a01926a6cf308a Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/EntityDaoImplTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/PermissionDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StoragePoolDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmNumaNodeDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmPoolDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmStaticDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmTemplateDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/InterfaceDaoImplTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/NetworkClusterDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/NetworkDaoTest.java 12 files changed, 28 insertions(+), 34 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/80257 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2351d98d3f8a87c0798223c637a01926a6cf308a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove other DAOs from DiskImageDynamicDaoTest
by Code Review 08 Aug '17

08 Aug '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/80244 ) Change subject: core: Remove other DAOs from DiskImageDynamicDaoTest ...................................................................... core: Remove other DAOs from DiskImageDynamicDaoTest DiskImageDynamicDaoTest is supposed to test DiskImageDynamicDao, not other DAOs. This patch removes the test of other DAOs from this class, and leaves them to be tests in their own classes. Change-Id: I9807684bd998620bc45b95829f15e271811d9a3c Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskImageDynamicDaoTest.java 1 file changed, 4 insertions(+), 28 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/80244 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9807684bd998620bc45b95829f15e271811d9a3c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Reuse constants in RoleDaoTest
by Code Review 08 Aug '17

08 Aug '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/80246 ) Change subject: core: Reuse constants in RoleDaoTest ...................................................................... core: Reuse constants in RoleDaoTest Change-Id: I50ba692d168f779181f9e44a663f0024b49330ea Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/RoleDaoTest.java 1 file changed, 2 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/80246 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I50ba692d168f779181f9e44a663f0024b49330ea Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: DiskImageDynamicDaoTest constants
by Code Review 08 Aug '17

08 Aug '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/80243 ) Change subject: core: DiskImageDynamicDaoTest constants ...................................................................... core: DiskImageDynamicDaoTest constants Reuse constants from FixturesTool. Change-Id: I0b92f0d69c6ea1ce99011d7d2052c5128c7a8d2e Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskImageDynamicDaoTest.java 1 file changed, 2 insertions(+), 6 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/80243 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0b92f0d69c6ea1ce99011d7d2052c5128c7a8d2e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: QuotaDaoImpl#getAllQuotaIncludingConsumption nulls
by Code Review 08 Aug '17

08 Aug '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/79758 ) Change subject: core: QuotaDaoImpl#getAllQuotaIncludingConsumption nulls ...................................................................... core: QuotaDaoImpl#getAllQuotaIncludingConsumption nulls executeReadList never returns null - in the case of a query that has no data, it returns an empty list. This patch removes the redundant (read: wrong) null checks from this method's implementation in order to solve a Coverity warning. Change-Id: I458377d1f3fb082397ac5abbb56e27b8055cead9 Coverity-CID: 1062067 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/QuotaDaoImpl.java 1 file changed, 19 insertions(+), 23 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Martin Sivák: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/79758 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I458377d1f3fb082397ac5abbb56e27b8055cead9 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Standardize DiskImageDynamicDaoTest
by Code Review 08 Aug '17

08 Aug '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/80245 ) Change subject: core: Standardize DiskImageDynamicDaoTest ...................................................................... core: Standardize DiskImageDynamicDaoTest Standardize DiskImageDynamicDaoTest to extend BaseGenericDaoTestCase, and stop re-implementing its logic. Change-Id: I4f34bec55df5d85cfab97affaf1cf08c872b3304 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskImageDynamicDaoTest.java 1 file changed, 39 insertions(+), 104 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/80245 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4f34bec55df5d85cfab97affaf1cf08c872b3304 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Hard code session IDs in tests
by Code Review 08 Aug '17

08 Aug '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/79757 ) Change subject: core: Hard code session IDs in tests ...................................................................... core: Hard code session IDs in tests This patch adds engine session IDs to the fixtures file so that the DAO tests can use them. This removes the dependency that QuotaDaoTest and PermissionDaoTest currently have on EngineSessionDao, which in theory is unrelated to them and can cause false positives in case there's a problem with it. In other words, this patch improves the isolation of the DAO tests. Another improvement gained here is the removal of two DAO calls from each of these tests' setup() methods, which should improve their speed. Change-Id: Ie85830335420f68e4b60ad936359af0213dc4c6f Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/PermissionDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/QuotaDaoTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml 4 files changed, 27 insertions(+), 46 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/79757 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie85830335420f68e4b60ad936359af0213dc4c6f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: branding update to new blue theme
by Code Review 08 Aug '17

08 Aug '17

>From Greg Sheremeta <gshereme(a)redhat.com>: Greg Sheremeta has submitted this change and it was merged. ( https://gerrit.ovirt.org/79973 ) Change subject: webadmin: branding update to new blue theme ...................................................................... webadmin: branding update to new blue theme Update webadmin to new blue theme. Also cleaned up some images and css. Change-Id: Ib59478039892103d2608b073f845b49ab5ef71a4 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M backend/manager/modules/docs/src/main/webapp/WEB-INF/no_lang.jsp M backend/manager/modules/enginesso/src/main/webapp/WEB-INF/credentialsChange.jsp M backend/manager/modules/enginesso/src/main/webapp/WEB-INF/login.jsp M backend/manager/modules/welcome/src/main/webapp/WEB-INF/404.jsp M backend/manager/modules/welcome/src/main/webapp/WEB-INF/405.jsp M backend/manager/modules/welcome/src/main/webapp/WEB-INF/ovirt-engine.jsp M frontend/webadmin/modules/frontend/src/main/resources/META-INF/resources/GwtHostPage.jsp M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/BaseDynamicMessages.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/DynamicMessages.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/AboutPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/AboutPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/HeaderView.ui.xml M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationConstants.properties M packaging/branding/ovirt.brand/branding.properties M packaging/branding/ovirt.brand/common.css D packaging/branding/ovirt.brand/gwt_common.css A packaging/branding/ovirt.brand/images/favicon-16x16.png A packaging/branding/ovirt.brand/images/favicon-32x32.png M packaging/branding/ovirt.brand/images/favicon.ico A packaging/branding/ovirt.brand/images/oVirt_About_BG_Flat_Image.png A packaging/branding/ovirt.brand/images/oVirt_About_BG_Overlay.png A packaging/branding/ovirt.brand/images/oVirt_Banner_image_transparent.png A packaging/branding/ovirt.brand/images/oVirt_Banner_solid.png A packaging/branding/ovirt.brand/images/oVirt_Landing_Bottom_Left_Corner.png A packaging/branding/ovirt.brand/images/oVirt_Landing_Top_Right_Corner.png A packaging/branding/ovirt.brand/images/oVirt_Login_Bottom_Left_Corner.png A packaging/branding/ovirt.brand/images/oVirt_Login_Top_Right_Corner.png A packaging/branding/ovirt.brand/images/oVirt_Logo.png D packaging/branding/ovirt.brand/images/ovirt_bg.png A packaging/branding/ovirt.brand/images/ovirt_header_logo.png M packaging/branding/ovirt.brand/images/ovirt_login_middle_logo.png D packaging/branding/ovirt.brand/images/ovirt_top_right_logo.png M packaging/branding/ovirt.brand/messages.properties M packaging/branding/ovirt.brand/ovirt.css M packaging/branding/ovirt.brand/patternfly-ovirt.css M packaging/branding/ovirt.brand/web_admin.css M packaging/branding/ovirt.brand/welcome_style.css 37 files changed, 379 insertions(+), 390 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Greg Sheremeta: Verified -- To view, visit https://gerrit.ovirt.org/79973 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib59478039892103d2608b073f845b49ab5ef71a4 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[ovirt-log-collector-4.1]: inventory: check for vms pinned
by Code Review 08 Aug '17

08 Aug '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. ( https://gerrit.ovirt.org/80415 ) Change subject: inventory: check for vms pinned ...................................................................... inventory: check for vms pinned Warn users in case there are virtual machines pinned to run in specific hypervisor. Change-Id: I9a0dc40f24d32a446bc32e4f2c767ec712b44605 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/Makefile.am M src/inventory_report/produceReport/pre-upgrade-checks M src/inventory_report/produceReport/produceReport.sh A src/inventory_report/produceReport/sqls/vms_query_pinned_virtual_machines.sql 4 files changed, 23 insertions(+), 0 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/80415 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9a0dc40f24d32a446bc32e4f2c767ec712b44605 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-4.1 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0