August 2017 - Engine-commits - oVirt List Archives

Change in ovirt-log-collector[master]: inventory: merge storage domain and disks section
by Code Review 04 Aug '17

04 Aug '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. ( https://gerrit.ovirt.org/80203 ) Change subject: inventory: merge storage domain and disks section ...................................................................... inventory: merge storage domain and disks section Change-Id: I2fb829ed86fdf2b36ef1c8e073c4125f90c5df14 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/Makefile.am M src/inventory_report/produceReport/produceReport.sh M src/inventory_report/produceReport/sqls/storage_domains_query_data.sql D src/inventory_report/produceReport/sqls/storage_domains_query_number_of_disks.sql 4 files changed, 3 insertions(+), 15 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Martin Mucha: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/80203 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2fb829ed86fdf2b36ef1c8e073c4125f90c5df14 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[master]: inventory: Add external providers
by Code Review 04 Aug '17

04 Aug '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. ( https://gerrit.ovirt.org/80199 ) Change subject: inventory: Add external providers ...................................................................... inventory: Add external providers Change-Id: Ib2afe7a87549dae4f7f6e369bf1811bc82252931 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/Makefile.am M src/inventory_report/produceReport/produceReport.sh A src/inventory_report/produceReport/sqls/providers_query_show_data.sql 3 files changed, 48 insertions(+), 0 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Martin Mucha: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/80199 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib2afe7a87549dae4f7f6e369bf1811bc82252931 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Set action/type messages in TransferDiskImageCommand
by Code Review 03 Aug '17

03 Aug '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/80168 ) Change subject: core: Set action/type messages in TransferDiskImageCommand ...................................................................... core: Set action/type messages in TransferDiskImageCommand Change-Id: I192aff2dd9bb43e5acc7ee9b85554cd748ded0c5 Bug-Url: https://bugzilla.redhat.com/1477922 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/TransferDiskImageCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 3 files changed, 9 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/80168 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I192aff2dd9bb43e5acc7ee9b85554cd748ded0c5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: novnc import of css and js fixed
by Code Review 03 Aug '17

03 Aug '17

>From Tomas Jelinek <tjelinek(a)redhat.com>: Tomas Jelinek has submitted this change and it was merged. ( https://gerrit.ovirt.org/80059 ) Change subject: core: novnc import of css and js fixed ...................................................................... core: novnc import of css and js fixed novnc-main.jsp contained hardcoded dependencies to patternfly css and js, that stopped working since patch https://gerrit.ovirt.org/#/c/61716. <link> and <script> including tags replaced by jsp tags from "obrand" library. Change-Id: I05ee87fdf18ec6a4239927ea84db785021225557 Bug-Url: https://bugzilla.redhat.com/1475845 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/services/src/main/webapp/novnc-main.jsp 1 file changed, 3 insertions(+), 5 deletions(-) Approvals: Jakub Niedermertl: Verified Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/80059 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I05ee87fdf18ec6a4239927ea84db785021225557 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: webadmin: Correct alignment in edit storage quota popup
by Code Review 03 Aug '17

03 Aug '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. ( https://gerrit.ovirt.org/80150 ) Change subject: webadmin: Correct alignment in edit storage quota popup ...................................................................... webadmin: Correct alignment in edit storage quota popup This patch corrects the alignment of the storage quota textbox in the edit storage quota popup. It also uppercases the first letter of the radio button label for consistency. Change-Id: Id358537cb38c96e67f064c680a2a839d58bc8fcc Bug-Url: https://bugzilla.redhat.com/1418156 Signed-off-by: Phillip Bailey <phbailey(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/quota/EditQuotaStoragePopupView.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationConstants.properties 2 files changed, 2 insertions(+), 1 deletion(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Phillip Bailey: Verified -- To view, visit https://gerrit.ovirt.org/80150 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id358537cb38c96e67f064c680a2a839d58bc8fcc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Make force refresh of domain files defined by param
by Code Review 03 Aug '17

03 Aug '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. ( https://gerrit.ovirt.org/80051 ) Change subject: restapi: Make force refresh of domain files defined by param ...................................................................... restapi: Make force refresh of domain files defined by param Before this patch a request to get a domain's file list via /api/storagedomains/%domain_id%/files was always done with a force refresh now it is possible to choose whether to force refresh or not by setting the 'refresh' parameter. For backwards compatibility reasons if the parameter is not supplied then force refreshing the files list will be determined by the configuration value ForceRefreshDomainFilesListByDefault Bug-Url: https://bugzilla.redhat.com/1414207 Change-Id: I6e331b62528f17db9870e7221f5faad48bc25909 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/IsoDomainListSynchronizer.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetImagesListParametersBase.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendFilesResource.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql M packaging/etc/engine-config/engine-config.properties 6 files changed, 31 insertions(+), 10 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/80051 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6e331b62528f17db9870e7221f5faad48bc25909 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Benny Zlotnik <bzlotnik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Shani Leviim <sleviim(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: ui: change height of pin VM to host
by Code Review 03 Aug '17

03 Aug '17

>From Alexander Wels <awels(a)redhat.com>: Alexander Wels has submitted this change and it was merged. ( https://gerrit.ovirt.org/80152 ) Change subject: ui: change height of pin VM to host ...................................................................... ui: change height of pin VM to host Change-Id: I44d1c4b76e5d38c455ca247031102719ea16b7e0 Bug-Url: https://bugzilla.redhat.com/1439682 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/VmRepinHostPopupView.ui.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Oved Ourfali: Verified -- To view, visit https://gerrit.ovirt.org/80152 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I44d1c4b76e5d38c455ca247031102719ea16b7e0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-live[ovirt-live-4.1]: build: ovirt-live 4.1.5 rc2
by Code Review 03 Aug '17

03 Aug '17

>From Lev Veyde <lveyde(a)redhat.com>: Lev Veyde has submitted this change and it was merged. ( https://gerrit.ovirt.org/80159 ) Change subject: build: ovirt-live 4.1.5 rc2 ...................................................................... build: ovirt-live 4.1.5 rc2 Change-Id: Iab89f9220e247d7a804d0c5b0b9887aa541619b2 Signed-off-by: Lev Veyde <lveyde(a)redhat.com> --- M centos-7/Makefile 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Lev Veyde: Verified; Looks good to me, approved; Passed CI tests Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/80159 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iab89f9220e247d7a804d0c5b0b9887aa541619b2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-4.1 Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: error fix in defaultRoute canEdit
by Code Review 03 Aug '17

03 Aug '17

>From Tomas Jelinek <tjelinek(a)redhat.com>: Tomas Jelinek has submitted this change and it was merged. ( https://gerrit.ovirt.org/80103 ) Change subject: webadmin: error fix in defaultRoute canEdit ...................................................................... webadmin: error fix in defaultRoute canEdit Before test in canEdit was done only comparing management network. That blocked mgmt network from losing default route role, but it also prevented it from acquiring it, which is not ok. Change-Id: I95ae7fa9131c47f3e4f60786d97369d82205cc13 Bug-Url: https://bugzilla.redhat.com/1443412 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterManageNetworkPopupView.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Alexander Wels: Looks good to me, approved Martin Mucha: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/80103 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I95ae7fa9131c47f3e4f60786d97369d82205cc13 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: Revert "packaging: setup: Add to unremovable only files we w...
by Code Review 03 Aug '17

03 Aug '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. ( https://gerrit.ovirt.org/79902 ) Change subject: Revert "packaging: setup: Add to unremovable only files we wrote" ...................................................................... Revert "packaging: setup: Add to unremovable only files we wrote" This reverts commit c1ee0753624939dcc14ba1741b5390f48eb0c093. That commit broke cleanup code under certain conditions, yet to be fully diagnosed. Change-Id: I83b420cab2142b5d474e10a6fa0ede273afe96ee Bug-Url: https://bugzilla.redhat.com/1475788 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-common/base/core/uninstall.py 1 file changed, 14 insertions(+), 18 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/79902 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I83b420cab2142b5d474e10a6fa0ede273afe96ee Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0