August 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: properly hide data table refresh when appropriate
by Code Review 01 Aug '17

01 Aug '17

>From Greg Sheremeta <gshereme(a)redhat.com>: Greg Sheremeta has submitted this change and it was merged. ( https://gerrit.ovirt.org/79944 ) Change subject: webadmin: properly hide data table refresh when appropriate ...................................................................... webadmin: properly hide data table refresh when appropriate When a data table's data provider does not have a refresh timer setup, hide the entire refresh panel. Change-Id: I48145cabc6124741c5aa0761432c207d92f431fb Signed-off-by: Scott J Dickerson <sdickers(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/refresh/RefreshPanel.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/SimpleActionTable.java 2 files changed, 7 insertions(+), 10 deletions(-) Approvals: Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved Scott Dickerson: Verified -- To view, visit https://gerrit.ovirt.org/79944 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I48145cabc6124741c5aa0761432c207d92f431fb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Scott Dickerson <sdickers(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Make CQ update 'tested' instead of 'experimental'
by Code Review 01 Aug '17

01 Aug '17

>From Barak Korren <bkorren(a)redhat.com>: Barak Korren has submitted this change and it was merged. ( https://gerrit.ovirt.org/79309 ) Change subject: Make CQ update 'tested' instead of 'experimental' ...................................................................... Make CQ update 'tested' instead of 'experimental' Switch change-queue into full production by making it update the 'tested' repo instead of having the 'experimental' flow do it. Change-Id: I0836e59ca4ae7f7b75db10cb651b3e42a25e73b3 Signed-off-by: Barak Korren <bkorren(a)redhat.com> Jira-Ticket: https://ovirt-jira.atlassian.net/browse/OVIRT-1446 --- M jobs/confs/groovy-scripts/test-ovirt-repo.groovy M pipelines/ovirt_change-queue-tester.groovy 2 files changed, 14 insertions(+), 16 deletions(-) Approvals: Barak Korren: Verified; Looks good to me, approved; Ready for merge Gil Shinar: Looks good to me Daniel Belenky: Looks good to me Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/79309 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0836e59ca4ae7f7b75db10cb651b3e42a25e73b3 Gerrit-PatchSet: 5 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>

1 0

Change in jenkins[master]: Change ID of STD-CI push credentials
by Code Review 01 Aug '17

01 Aug '17

>From Barak Korren <bkorren(a)redhat.com>: Barak Korren has submitted this change and it was merged. ( https://gerrit.ovirt.org/79880 ) Change subject: Change ID of STD-CI push credentials ...................................................................... Change ID of STD-CI push credentials Change the ID of the SSH key used by STD-CI for pushing changes from a random string to a descriptive names in order to make the code more easily portable between Jenkins instances. Change-Id: I854e679cdb3dad844b36e84943996881a14b3a69 Signed-off-by: Barak Korren <bkorren(a)redhat.com> Jira-Ticket: https://ovirt-jira.atlassian.net/browse/OVIRT-1378 --- M jobs/confs/yaml/wrappers/inject_git_push_credentials.yaml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Barak Korren: Verified; Looks good to me, approved; Ready for merge Gil Shinar: Looks good to me Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/79880 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I854e679cdb3dad844b36e84943996881a14b3a69 Gerrit-PatchSet: 3 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>

1 0

Change in jenkins[master]: re-factor: Reorder entries in std triggers file
by Code Review 01 Aug '17

01 Aug '17

>From Barak Korren <bkorren(a)redhat.com>: Barak Korren has submitted this change and it was merged. ( https://gerrit.ovirt.org/79724 ) Change subject: re-factor: Reorder entries in std triggers file ...................................................................... re-factor: Reorder entries in std triggers file Reorder entries in 'triggers/standard.yaml' alphabetically by macro name to make it easier to find related things Change-Id: I552898afd04db960e9e18ac483df46748463da66 Signed-off-by: Barak Korren <bkorren(a)redhat.com> Jira-Ticket: https://ovirt-jira.atlassian.net/browse/OVIRT-1157 --- M jobs/confs/yaml/triggers/standard.yaml 1 file changed, 21 insertions(+), 21 deletions(-) Approvals: Barak Korren: Verified; Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/79724 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I552898afd04db960e9e18ac483df46748463da66 Gerrit-PatchSet: 4 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>

1 0

Change in jenkins[master]: re-factor: Reduce duplication in triggers YAML
by Code Review 01 Aug '17

01 Aug '17

>From Barak Korren <bkorren(a)redhat.com>: Barak Korren has submitted this change and it was merged. ( https://gerrit.ovirt.org/79723 ) Change subject: re-factor: Reduce duplication in triggers YAML ...................................................................... re-factor: Reduce duplication in triggers YAML Use YAML entity inheritance to reduce code duplication in the 'triggers/standard.yam' and triggers/github.yaml files. Also removed some triggers that were not used so far and should probably not be used in the future. This patch should probably not cause any changes to actual jobs. Change-Id: I446d1ec34af8c0c40afb1c7b01acdeb901800458 Signed-off-by: Barak Korren <bkorren(a)redhat.com> Jira-Ticket: https://ovirt-jira.atlassian.net/browse/OVIRT-1157 --- M jobs/confs/yaml/triggers/github.yaml M jobs/confs/yaml/triggers/standard.yaml 2 files changed, 28 insertions(+), 80 deletions(-) Approvals: Barak Korren: Verified; Looks good to me, approved; Ready for merge Gil Shinar: Looks good to me Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/79723 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I446d1ec34af8c0c40afb1c7b01acdeb901800458 Gerrit-PatchSet: 4 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: VmModelBehaviorBase diamond operator
by Code Review 01 Aug '17

01 Aug '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/79709 ) Change subject: webadmin: VmModelBehaviorBase diamond operator ...................................................................... webadmin: VmModelBehaviorBase diamond operator Change-Id: I269209372e8321b476180ec6a0f623c2f543c5df Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/79709 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I269209372e8321b476180ec6a0f623c2f543c5df Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: VmModelBehaviorBase method reference
by Code Review 01 Aug '17

01 Aug '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/79711 ) Change subject: webadmin: VmModelBehaviorBase method reference ...................................................................... webadmin: VmModelBehaviorBase method reference Use method references instead of lambdas to make the code cleaner. Change-Id: Iecd769d3fc602eac4af4ed25c60629f132d98bf7 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/79711 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iecd769d3fc602eac4af4ed25c60629f132d98bf7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Remove VmModelBehaviorBase unused methods
by Code Review 01 Aug '17

01 Aug '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/79710 ) Change subject: webadmin: Remove VmModelBehaviorBase unused methods ...................................................................... webadmin: Remove VmModelBehaviorBase unused methods Change-Id: I87ed14f1ca44d762bb2a7c8a1e601255c75b24a8 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java 1 file changed, 0 insertions(+), 12 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/79710 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I87ed14f1ca44d762bb2a7c8a1e601255c75b24a8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: VmMoelBehaviorBase collections
by Code Review 01 Aug '17

01 Aug '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/79712 ) Change subject: webadmin: VmMoelBehaviorBase collections ...................................................................... webadmin: VmMoelBehaviorBase collections Use the optimized Collections#singletonList instead of the general purpose Arrays#asList for single-element lists. Change-Id: Id013b8b18bcb8a1af70567a2ae3c4ce028094fbc Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java 1 file changed, 5 insertions(+), 4 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/79712 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id013b8b18bcb8a1af70567a2ae3c4ce028094fbc Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: VmModelBehaviorBase list sorting
by Code Review 01 Aug '17

01 Aug '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/79713 ) Change subject: webadmin: VmModelBehaviorBase list sorting ...................................................................... webadmin: VmModelBehaviorBase list sorting Use Java 8's more elegant List#sort(Comparator) method instead of the awkward Collections#sort(List, Comparator). Change-Id: I9a432857166c1627ad5bf3d5f979a5c56dc0ae28 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/79713 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9a432857166c1627ad5bf3d5f979a5c56dc0ae28 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0