Change in ovirt-engine[master]: webadmin, userportal: DiskModel - DataCenters list
by derez@redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin,userportal: DiskModel - DataCenters list
......................................................................
webadmin,userportal: DiskModel - DataCenters list
Replaced 'GetDataCenterList' query with
'GetDataCentersWithPermittedActionOnClusters'
(for the userportal).
Change-Id: Ie3d77c7382eff6fd2090985fb94276d63a89e2a2
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/DiskModel.java
1 file changed, 3 insertions(+), 2 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4942
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie3d77c7382eff6fd2090985fb94276d63a89e2a2
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
12 years, 6 months
Change in ovirt-engine[master]: webadmin: Disable disk HotPlug for IDE interface
by derez@redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: Disable disk HotPlug for IDE interface
......................................................................
webadmin: Disable disk HotPlug for IDE interface
Active/Deactivate a disk attached to an IDE interface
should be blocked only when VM isn't down.
Change-Id: I719b3c125fe562b9848d016048ab3e42894bf6ef
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4949
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I719b3c125fe562b9848d016048ab3e42894bf6ef
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: userportal: Fix trailing whitespace
by gchaplik@redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: userportal: Fix trailing whitespace
......................................................................
userportal: Fix trailing whitespace
Removed trailing whitespace in FrontendEventsHandlerImpl.
Change-Id: I95d6b0702dad571d772a8f06110b918fecf0ed03
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
---
M frontend/webadmin/modules/userportal/src/main/java/org/ovirt/engine/ui/userportal/client/uicommonext/FrontendEventsHandlerImpl.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4952
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I95d6b0702dad571d772a8f06110b918fecf0ed03
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: restapi: Import Template more than once
by gchaplik@redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: restapi: Import Template more than once
......................................................................
restapi: Import Template more than once
feature page:
http://www.ovirt.org/wiki/Features/ImportMoreThanOnce
added template parameter to action, in order to set the template's name
clone parameter is already there (import VM patch)
Change-Id: I0b678ccece805feef318e5b750d112cc35d510cb
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainTemplateResource.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainTemplateResourceTest.java
4 files changed, 27 insertions(+), 7 deletions(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4941
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0b678ccece805feef318e5b750d112cc35d510cb
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: restapi: Import VM more than once
by gchaplik@redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: restapi: Import VM more than once
......................................................................
restapi: Import VM more than once
feature page:
http://www.ovirt.org/wiki/Features/ImportMoreThanOnce
Change-Id: Idf4d95c0408af532faa4db022fc9c8a5912a3f09
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainVmResource.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainVmResourceTest.java
4 files changed, 29 insertions(+), 8 deletions(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4940
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idf4d95c0408af532faa4db022fc9c8a5912a3f09
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: webadmin: RunMultipleAction - error handling fix
by vszocs@redhat.com
Vojtech Szocs has submitted this change and it was merged.
Change subject: webadmin: RunMultipleAction - error handling fix
......................................................................
webadmin: RunMultipleAction - error handling fix
For command execution is failed error handling,
getIsSyncronious() also needs to be checked while checking getIsSucceeded().
Change-Id: I48856cd07516a0f61a64bdd96fa2420afd44aa48
Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com>
---
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Vojtech Szocs: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4950
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I48856cd07516a0f61a64bdd96fa2420afd44aa48
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: packaging: Deploy only PostgreSQL module in dev mode
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: packaging: Deploy only PostgreSQL module in dev mode
......................................................................
packaging: Deploy only PostgreSQL module in dev mode
When setting up development environments the only module that has
to be deployed to the modules directory of the application server
is the PostgreSQL driver.
Change-Id: I2707845471813f46070bc210e93b612b99471a24
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M ear/pom.xml
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4947
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2707845471813f46070bc210e93b612b99471a24
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: restapi: add collapse snapshots support
by gchaplik@redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: restapi: add collapse snapshots support
......................................................................
restapi: add collapse snapshots support
adding the property collapse_snapshots under snapshots.
similar to clone property under Disks, we indicate whether the entire collection
(snapshots) is collapsed.
currently used in import vm action.
Change-Id: I1862158048da22d899f0a1993c270b6f1ea5f9c2
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainVmResource.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainVmResourceTest.java
4 files changed, 38 insertions(+), 12 deletions(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4525
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1862158048da22d899f0a1993c270b6f1ea5f9c2
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: webadmin: RunMultipleAction - error handling added
by gchaplik@redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: RunMultipleAction - error handling added
......................................................................
webadmin: RunMultipleAction - error handling added
Error handling code of RunMultipleAction is modified to
display more than one error message.
Both CanDoAction messages and Execution failed(Fault)
messages are combined and shown in the error popup dialog.
Change-Id: I8d9ab1c30b7352af029cc283ca98b6370388bb0e
Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com>
---
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/IFrontendEventsHandler.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/ErrorMessageFormatter.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/FrontendEventsHandlerImpl.java
M frontend/webadmin/modules/userportal/src/main/java/org/ovirt/engine/ui/userportal/client/uicommonext/FrontendEventsHandlerImpl.java
5 files changed, 91 insertions(+), 63 deletions(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4878
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8d9ab1c30b7352af029cc283ca98b6370388bb0e
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: webadmin, userportal: Enforce dialog close on Escape key
by gchaplik@redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin,userportal: Enforce dialog close on Escape key
......................................................................
webadmin,userportal: Enforce dialog close on Escape key
When a model-bound dialog is open and the user presses Escape key,
besides executing dialog model's "Cancel" command, dialog close is
enforced by the application.
Note that a dialog model's "Cancel" command should close the dialog
by itself. This patch makes sure that no dialog gets stuck on UI
when the corresponding "Cancel" command fails to close it. This can
happen for many reasons, including exceptions thrown during command
execution.
Change-Id: Ia4b3b6df062a5d32f9ac536cc75a8e143558857b
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractModelBoundPopupPresenterWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/DeferredModelCommandInvoker.java
2 files changed, 51 insertions(+), 7 deletions(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4815
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia4b3b6df062a5d32f9ac536cc75a8e143558857b
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
12 years, 7 months