May 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: is_inhertiable->allows_viewing_childern
by rgolan＠redhat.com 23 May '12

23 May '12

Roy Golan has submitted this change and it was merged. Change subject: core: is_inhertiable->allows_viewing_childern ...................................................................... core: is_inhertiable->allows_viewing_childern Renamed the is_inheritable property in the Role and ActionGroup MLA entities to the more accurate allows_viewing_children after some comments by rgolan on http://gerrit.ovirt.org/#change,4607. Change-Id: I3bc62635d0e294a5d91696d8e390ccfc6cb86f09 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/dbscripts/multi_level_administration_sp.sql A backend/manager/dbscripts/upgrade/03_01_1110_rename_inheritable_roles_columns.sql M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ActionGroup.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/roles.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/RolesRowMapper.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/RoleDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/RoleDAOTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml 8 files changed, 22 insertions(+), 20 deletions(-) Approvals: Allon Mureinik: Verified Roy Golan: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4695 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3bc62635d0e294a5d91696d8e390ccfc6cb86f09 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: fix failing vmHandler tests
by ofrenkel＠redhat.com 23 May '12

23 May '12

Omer Frenkel has submitted this change and it was merged. Change subject: core: fix failing vmHandler tests ...................................................................... core: fix failing vmHandler tests usb policy implementation changed to use config. changed test to handle this Change-Id: Ib8dbf237f0b53b5700ac999c0d5c0fb3475a961a Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/VmHandlerTest.java 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Omer Frenkel: Verified -- To view, visit http://gerrit.ovirt.org/4692 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib8dbf237f0b53b5700ac999c0d5c0fb3475a961a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Change error message when trying to remove data ce...
by tnisan＠redhat.com 23 May '12

23 May '12

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Change error message when trying to remove data center ...................................................................... webadmin: Change error message when trying to remove data center Change-Id: I2959056e5028c544da27231449f19087f844e473 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/utils/src/test/resources/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 5 files changed, 8 insertions(+), 8 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4441 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2959056e5028c544da27231449f19087f844e473 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Fix disks->templates sub tab values (#819282)
by tnisan＠redhat.com 23 May '12

23 May '12

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Fix disks->templates sub tab values (#819282) ...................................................................... webadmin: Fix disks->templates sub tab values (#819282) https://bugzilla.redhat.com/819282 The sub tab "Templates" under the disks list contained no values for number of disks or actual size Change-Id: Ief72d91e25bb09498aedde0adb3b8b598fedd0db Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmTemplatesByImageGuidQuery.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetVmTemplatesByImageGuidQueryTest.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/disk/SubTabDiskTemplateView.java 3 files changed, 30 insertions(+), 6 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4444 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ief72d91e25bb09498aedde0adb3b8b598fedd0db Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Gluster Volume resource implementation
by mpastern＠redhat.com 23 May '12

23 May '12

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: Gluster Volume resource implementation ...................................................................... restapi: Gluster Volume resource implementation Implementation of BackendGlusterVolumeResource - get - start - stop - rebalance - setOption - resetOption - resetAllOptions Change-Id: Ia8206f91ebc003332bc3d1ae8535a23dab568a30 Signed-off-by: Shireesh Anjal <sanjal(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterVolumeResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterVolumesResource.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterVolumeResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterVolumesResourceTest.java 6 files changed, 306 insertions(+), 24 deletions(-) Approvals: Michael Pasternak: Looks good to me, approved Shireesh Anjal: Verified -- To view, visit http://gerrit.ovirt.org/4677 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia8206f91ebc003332bc3d1ae8535a23dab568a30 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Removed unnecessary constructor argument
by ofrenkel＠redhat.com 23 May '12

23 May '12

Omer Frenkel has submitted this change and it was merged. Change subject: engine: Removed unnecessary constructor argument ...................................................................... engine: Removed unnecessary constructor argument in GlusterVolumeRebalanceParameters, and it's references in - StartRebalanceGlusterVolumeCommandTest - VolumeListModel Change-Id: Ib71b8b62c2d2e37dd49bc8aa3290f0e2d279de45 Signed-off-by: Shireesh Anjal <sanjal(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/StartRebalanceGlusterVolumeCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/gluster/GlusterVolumeRebalanceParameters.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java 3 files changed, 3 insertions(+), 5 deletions(-) Approvals: Shireesh Anjal: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4676 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib71b8b62c2d2e37dd49bc8aa3290f0e2d279de45 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Removed curly braces from type definitions
by ofrenkel＠redhat.com 23 May '12

23 May '12

Omer Frenkel has submitted this change and it was merged. Change subject: engine: Removed curly braces from type definitions ...................................................................... engine: Removed curly braces from type definitions ${type} -> $type as it was resulting in type not getting substituted in the audit log messages. Change-Id: I794ad7d000c2ca7c398d5bd0a45f45143423241c Signed-off-by: Shireesh Anjal <sanjal(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Shireesh Anjal: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4675 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I794ad7d000c2ca7c398d5bd0a45f45143423241c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Fixed findbugs issue
by ofrenkel＠redhat.com 23 May '12

23 May '12

Omer Frenkel has submitted this change and it was merged. Change subject: engine: Fixed findbugs issue ...................................................................... engine: Fixed findbugs issue The previous patch http://gerrit.ovirt.org/4658 fixed the bug, but findbugs still thinks it's a bug. This patch changes the code slightly to make sure that findbugs has no problem with it. Change-Id: I420e7b57578b159ad603fcbeed0c1f8eef862d1f Signed-off-by: Shireesh Anjal <sanjal(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeEntity.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Shireesh Anjal: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4678 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I420e7b57578b159ad603fcbeed0c1f8eef862d1f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: UnPowerMock MultipleServicesMonitoringStrategyTest
by mkolesni＠redhat.com 23 May '12

23 May '12

Mike Kolesnik has submitted this change and it was merged. Change subject: core: UnPowerMock MultipleServicesMonitoringStrategyTest ...................................................................... core: UnPowerMock MultipleServicesMonitoringStrategyTest Removed useless PowerMockRunner annotation. Change-Id: I5f3cd420f09d3b3f4a3aa19d34a3db326d1cd192 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/MultipleServicesMonitoringStrategyTest.java 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/4637 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5f3cd420f09d3b3f4a3aa19d34a3db326d1cd192 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: UnPowerMock SessionDataContainerTest
by mkolesni＠redhat.com 23 May '12

23 May '12

Mike Kolesnik has submitted this change and it was merged. Change subject: core: UnPowerMock SessionDataContainerTest ...................................................................... core: UnPowerMock SessionDataContainerTest Removed PowerMock dependency from SessionDataContainerTest by spying an instance. In order to facilitate this improvement, a getDbUserDAO() method was added to SessionDataContainer. Change-Id: I0d2e594f67a57a08c8ff195ba69aad617fc42e56 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/session/SessionDataContainer.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/session/SessionDataContainerTest.java 2 files changed, 53 insertions(+), 53 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/4636 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0d2e594f67a57a08c8ff195ba69aad617fc42e56 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0