July 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: cleanup:Fix test message
by mlipchuk＠redhat.com 25 Jul '12

25 Jul '12

Maor Lipchuk has submitted this change and it was merged. Change subject: cleanup:Fix test message ...................................................................... cleanup:Fix test message Fix test message to indicate the correct number of disks. Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> Change-Id: I18c8bc92847c7b74fae6598d893f1f947415731b --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskDaoTest.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6352 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I18c8bc92847c7b74fae6598d893f1f947415731b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: add disk - update default format
by derez＠redhat.com 25 Jul '12

25 Jul '12

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: add disk - update default format ...................................................................... webadmin: add disk - update default format Disks main-tab -> Add Disk dialog: update default format when changing a data-center (default format is selected by storage type). Change-Id: Ic919e75d7f9daa901de342f9822e4ae978b0892c Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/DiskModel.java 1 file changed, 1 insertion(+), 5 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6596 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic919e75d7f9daa901de342f9822e4ae978b0892c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Disconnect on reconstruct also for domain V3
by mkublin＠redhat.com 25 Jul '12

25 Jul '12

Michael Kublin has submitted this change and it was merged. Change subject: core: Disconnect on reconstruct also for domain V3 ...................................................................... core: Disconnect on reconstruct also for domain V3 Reconstructing a master while connected to the pool at the moment requires too many untested and unstable changes on the VDSM side. Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com> Change-Id: I60101fcd52049c9a488d1db94b1fc69d121c60d8 --- M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6603 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I60101fcd52049c9a488d1db94b1fc69d121c60d8 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Modify user interface of engine-setup (#832767)
by oschreib＠redhat.com 25 Jul '12

25 Jul '12

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: Modify user interface of engine-setup (#832767) ...................................................................... packaging: Modify user interface of engine-setup (#832767) https://bugzilla.redhat.com/show_bug.cgi?id=832767 * Fixed masseges typos and changed the content. * Use default name for iso domain in UI * Suggest path for iso domain * Suggest org name Change-Id: If3cb27b4b6dbaaafb19a3d61b7a272e4e1ad91b8 Signed-off-by: Kiril Nesenko <knesenko(a)redhat.com> --- M packaging/fedora/setup/basedefs.py M packaging/fedora/setup/engine-setup.py M packaging/fedora/setup/output_messages.py 3 files changed, 47 insertions(+), 15 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6592 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If3cb27b4b6dbaaafb19a3d61b7a272e4e1ad91b8 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: can't edit vlaned mgmt network
by derez＠redhat.com 25 Jul '12

25 Jul '12

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: can't edit vlaned mgmt network ...................................................................... webadmin: can't edit vlaned mgmt network https://bugzilla.redhat.com/828661 There is a exception when opening the edit dialog of a management network over vlan (managenet network not over vlan also doen't work properly). It happens because the editManagement network calls through DataProvider and not AsyncDataProvider. Change-Id: Ib3d5147d2da883a221b2d0af7c6409f54c9cd32b Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/DataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceListModel.java 3 files changed, 267 insertions(+), 227 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6594 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib3d5147d2da883a221b2d0af7c6409f54c9cd32b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: volume tab visibility (#837823)
by gchaplik＠redhat.com 25 Jul '12

25 Jul '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: volume tab visibility (#837823) ...................................................................... webadmin: volume tab visibility (#837823) https://bugzilla.redhat.com/837823 for gluster+virt - volumes as a maintab should only appear when standing on a gluster enabled cluster Change-Id: I827e12948606c5da5e01f8a851419a5b84a9aa7c Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6607 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I827e12948606c5da5e01f8a851419a5b84a9aa7c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: User level API fixes
by oourfali＠redhat.com 25 Jul '12

25 Jul '12

Oved Ourfali has submitted this change and it was merged. Change subject: engine: User level API fixes ...................................................................... engine: User level API fixes This patch does the following fixes in the User level API: 1. Block users from getting Host information via REST API (both host resource, and relevant host data in the VM resource). 2. Add GetManagementInterfaceAddressByVmIdQuery, removing GetManagementInterfaceAddressByVdsIdQuery. 3. Add GetVdsCertificateSubjectByVmIdQuery which uses the existing GetVdsCertificateSubjectByVdsIdQuery. 4. Update VncConsoleModel and SpiceConsoleModel to work with the new queries. Change-Id: I90032cdd70130dbab7b11457684d9130f763d5db Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetManagementInterfaceAddressByVdsIdQuery.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetManagementInterfaceAddressByVmIdQuery.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVdsCertificateSubjectByVmIdQuery.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetManagementInterfaceAddressByVmIdQueryTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendResourceTest.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/DataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceConsoleModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VncConsoleModel.java 13 files changed, 208 insertions(+), 85 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6542 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I90032cdd70130dbab7b11457684d9130f763d5db Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-reports[master]: report: fixed dashboard display.
by ydary＠redhat.com 25 Jul '12

25 Jul '12

Yaniv Dary has submitted this change and it was merged. Change subject: report: fixed dashboard display. ...................................................................... report: fixed dashboard display. The dashboard was displayed for all cluster instead of each one. This fixes this and the cluster context will be passed. Change-Id: I777a8cc8e3c715e1a5561117855e63366469ba2a Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M reports/Reports.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6609 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I777a8cc8e3c715e1a5561117855e63366469ba2a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: hot plug - use blacklist of unsupported list OSs
by rgolan＠redhat.com 25 Jul '12

25 Jul '12

Roy Golan has submitted this change and it was merged. Change subject: core: hot plug - use blacklist of unsupported list OSs ...................................................................... core: hot plug - use blacklist of unsupported list OSs Instead of maintaining list of supported OSs use a blacklist of unsupported. Change-Id: I878c10cd3343e358d62e2506856e13c4d4b0332e Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/HotPlugDiskToVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java 5 files changed, 11 insertions(+), 20 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6548 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I878c10cd3343e358d62e2506856e13c4d4b0332e Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Use standard SystemV status codes (#842641)
by oschreib＠redhat.com 25 Jul '12

25 Jul '12

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: Use standard SystemV status codes (#842641) ...................................................................... packaging: Use standard SystemV status codes (#842641) https://bugzilla.redhat.com/842641 This patch changes the start/stop script so that the "status" action returns the standard SystemV exit codes: 0: program is running or service is OK 1: program is dead and /var/run pid file exists 2: program is dead and /var/lock lock file exists 3: program is not running 4: program or service status is unknown 5-99: reserved for future LSB use 100-149: reserved for distribution use 150-199: reserved for application use 200-254: reserved Note that the script uses only 0, 1, 3 and 4, as the others are not applicable at the moment. Change-Id: I124107a00dc3e0c7d922a7e34840bb2f069028d2 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M packaging/fedora/engine-service.py 1 file changed, 43 insertions(+), 29 deletions(-) Approvals: Juan Hernandez: Verified Ofer Schreiber: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6571 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I124107a00dc3e0c7d922a7e34840bb2f069028d2 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0