July 2012 - Engine-commits - oVirt List Archives

Change in ovirt-dwh[master]: packaging: stopping service from starting at boot prior to s...
by ydary＠redhat.com 25 Jul '12

25 Jul '12

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: stopping service from starting at boot prior to setup ...................................................................... packaging: stopping service from starting at boot prior to setup Service was automaticlly enabled to start at boot time post rpm install. Service will now be turned off unless setup is performed. Change-Id: I7cd39440bcae966f043d92459b8bec0707d0cd09 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M packaging/ovirt-engine-dwh.spec.in 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6608 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7cd39440bcae966f043d92459b8bec0707d0cd09 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Make location of variables configurable
by oschreib＠redhat.com 25 Jul '12

25 Jul '12

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: Make location of variables configurable ...................................................................... packaging: Make location of variables configurable At the moment the engine service gets its configuration variables from the /etc/sysconfig/ovirt-engine file. This change introduces a new optional environment variable ENGINE_VARS that makes that also configurable. Change-Id: Ic88b52e71ad6cdd411b30bf488fed66de3c49997 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/tools/engine-tools-common/src/main/java/org/ovirt/engine/core/tools/common/db/StandaloneDataSource.java M packaging/fedora/engine-service.py 2 files changed, 7 insertions(+), 3 deletions(-) Approvals: Juan Hernandez: Verified Ofer Schreiber: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6336 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic88b52e71ad6cdd411b30bf488fed66de3c49997 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Ignore gateway for non-management net (#842137)
by masayag＠redhat.com 25 Jul '12

25 Jul '12

Moti Asayag has submitted this change and it was merged. Change subject: core: Ignore gateway for non-management net (#842137) ...................................................................... core: Ignore gateway for non-management net (#842137) https://bugzilla.redhat.com/842137 The backend will not save the gateway value if it was reported for non-management network, therefore the clients will receive null value for it. In addition, the "0.0.0.0" value for gateway is no longer permitted for non-management network. Change-Id: Ica928d0c774220339004e93110ecda742d6967f1 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/NetworkInterfaceValidator.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 2 files changed, 18 insertions(+), 4 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6585 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ica928d0c774220339004e93110ecda742d6967f1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Introducing CTORs that accept commandId
by yzaslavs＠redhat.com 25 Jul '12

25 Jul '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Introducing CTORs that accept commandId ...................................................................... core: Introducing CTORs that accept commandId These CTORs are required for proper compensation (In order not to receive MethodNotFound exception when performing compensation on startup of service) Change-Id: Id469575ad8540ce29bd676be6864c9f8ae0eca13 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsGroupCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsGroupOperationCommandBase.java 3 files changed, 15 insertions(+), 0 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6602 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id469575ad8540ce29bd676be6864c9f8ae0eca13 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fixing comment to proper TODO
by yzaslavs＠redhat.com 25 Jul '12

25 Jul '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Fixing comment to proper TODO ...................................................................... core: Fixing comment to proper TODO This comment is leftover from the compensation introduction patches. It is replaced by a proper TODO comment Change-Id: Ice9c9bf0da6ae9350f742bec431a8a48380dbbae Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6601 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ice9c9bf0da6ae9350f742bec431a8a48380dbbae Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Random can-do-action message (#827014)
by masayag＠redhat.com 25 Jul '12

25 Jul '12

Moti Asayag has submitted this change and it was merged. Change subject: core: Random can-do-action message (#827014) ...................................................................... core: Random can-do-action message (#827014) https://bugzilla.redhat.com/827014 A custom validator should disable the use of the default message, if the validator intends to provide its own message, else if no default message is defined, an empty string will be added to the can-do-action list, ended up as blank message to the user. Change-Id: I8c56651784e59d258753d1d25ac4546cc02ae915 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/NetworkInterfaceValidator.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/VdsGroupValidator.java 2 files changed, 3 insertions(+), 0 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6584 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8c56651784e59d258753d1d25ac4546cc02ae915 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Preserve 404 error code in error page (#842653)
by vszocs＠redhat.com 24 Jul '12

24 Jul '12

Vojtech Szocs has submitted this change and it was merged. Change subject: core: Preserve 404 error code in error page (#842653) ...................................................................... core: Preserve 404 error code in error page (#842653) https://bugzilla.redhat.com/842653 We used to redirect to the error page in order to avoid problems with relative URLs, but this is causing problems with clients (GWT for example) that follow the redirect and this don't recieve the error code. This patch replaces the redirect with forward and fixes the error page (the index page in fact) so that it doesn't use relative URLs. Change-Id: I84001b195c06ae8be38e500ba687353080d04830 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- D backend/manager/modules/root/src/main/java/org/ovirt/engine/core/ErrorServlet.java M backend/manager/modules/root/src/main/webapp/WEB-INF/web.xml M backend/manager/modules/root/src/main/webapp/index.html 3 files changed, 6 insertions(+), 35 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6573 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I84001b195c06ae8be38e500ba687353080d04830 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Replacing StringHelper with StringUtils in VirtMonit...
by masayag＠redhat.com 24 Jul '12

24 Jul '12

Moti Asayag has submitted this change and it was merged. Change subject: engine: Replacing StringHelper with StringUtils in VirtMonitoringStrategy. ...................................................................... engine: Replacing StringHelper with StringUtils in VirtMonitoringStrategy. StringHelper is deprecated. Change-Id: I3e5e04d6990e87f80edc1fc02d7935c8405ac620 Signed-off-by: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VirtMonitoringStrategy.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Sharad Mishra: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5858 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3e5e04d6990e87f80edc1fc02d7935c8405ac620 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ryan Harper <ryanh(a)us.ibm.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: user portal: use getAllVms query in basic view to get all vm...
by ecohen＠redhat.com 24 Jul '12

24 Jul '12

Einav Cohen has submitted this change and it was merged. Change subject: user portal: use getAllVms query in basic view to get all vms ...................................................................... user portal: use getAllVms query in basic view to get all vms using same query as in extended view to have the same behavior Change-Id: I40f15e1ccadc32d183370fd08896f970d4387436 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalBasicListModel.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Einav Cohen: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6590 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I40f15e1ccadc32d183370fd08896f970d4387436 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Added VDS to StorageHandlingCommandBase jobProperties
by derez＠redhat.com 24 Jul '12

24 Jul '12

Daniel Erez has submitted this change and it was merged. Change subject: core: Added VDS to StorageHandlingCommandBase jobProperties ...................................................................... core: Added VDS to StorageHandlingCommandBase jobProperties Added 'VdcObjectType.VDS' to 'jobProperties' map in StorageHandlingCommandBase (for a proper translation when executing 'ConnectStorageToVds' command: "Connecting Host ${VDS} to Storage server"). Change-Id: Ia00d3c44d605a3a65084a9edfb10069441288146 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6527 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia00d3c44d605a3a65084a9edfb10069441288146 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0