July 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: BaseImagesCommand: Cleanup RemoveSnapshot
by mlipchuk＠redhat.com 23 Jul '12

23 Jul '12

Maor Lipchuk has submitted this change and it was merged. Change subject: core: BaseImagesCommand: Cleanup RemoveSnapshot ...................................................................... core: BaseImagesCommand: Cleanup RemoveSnapshot The RemoveSnapshot method was made up from the RemoveSnapshotFromDB and AdditionalImageRemoveTreatment methods. AdditionalImageRemoveTreatment was only called from RestoreFromSnapshotCommand, so the additional logic was moved to the overriding method there. Change-Id: I36c6ffe9b17e8ff65e99c8b715cd9a30224e10ab Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreFromSnapshotCommand.java 2 files changed, 12 insertions(+), 21 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6400 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I36c6ffe9b17e8ff65e99c8b715cd9a30224e10ab Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>

1 0

Change in ovirt-engine[master]: core: BaseImagesCommand: remove commented out line
by mlipchuk＠redhat.com 23 Jul '12

23 Jul '12

Maor Lipchuk has submitted this change and it was merged. Change subject: core: BaseImagesCommand: remove commented out line ...................................................................... core: BaseImagesCommand: remove commented out line Some more cleanup work on BaseImagesCommand - the subject is self evident. Change-Id: I5375fa52e680b8bf3a049782e07d020a8776cfff Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6399 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5375fa52e680b8bf3a049782e07d020a8776cfff Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Allow detach from NIC for unmanaged net
by mkolesni＠redhat.com 23 Jul '12

23 Jul '12

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Allow detach from NIC for unmanaged net ...................................................................... engine: Allow detach from NIC for unmanaged net The code should not assume that the network is attached to cluster when trying to detach network from NIC. If it's not attached to cluster, no need to check status. Change-Id: I532e6df9d8f482879b139b7e2c361e7eafebc348 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachNetworkFromVdsInterfaceCommand.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Mike Kolesnik: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6553 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I532e6df9d8f482879b139b7e2c361e7eafebc348 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: update vm quota when action happens outside
by gchaplik＠redhat.com 23 Jul '12

23 Jul '12

Gilad Chaplik has submitted this change and it was merged. Change subject: core: update vm quota when action happens outside ...................................................................... core: update vm quota when action happens outside Currently there is no way to monitor vm's quota when it's getting stopped outside rhev, i.e. destroy vm in vdsClient or shutdown within the vm. so to solve that, when vm status changes stops, we update the quota. Change-Id: I610ee7caa57295b8418af2f29fcccaa463839a8d Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVmCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManager.java 3 files changed, 21 insertions(+), 37 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6520 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I610ee7caa57295b8418af2f29fcccaa463839a8d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: remove old USB controllers when changing the policy to...
by oourfali＠redhat.com 23 Jul '12

23 Jul '12

Oved Ourfali has submitted this change and it was merged. Change subject: core: remove old USB controllers when changing the policy to native ...................................................................... core: remove old USB controllers when changing the policy to native This patch removes old USB controllers, when changing the USB policy from disabled/legacy to native. Change-Id: Ia67806a3b9cffe3396504ec798637558d42751a8 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6549 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia67806a3b9cffe3396504ec798637558d42751a8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Improving logging exceptions
by yzaslavs＠redhat.com 23 Jul '12

23 Jul '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Improving logging exceptions ...................................................................... core: Improving logging exceptions This patch fixes authentication logging at manage-domains in case of SaslException within Authentication exception. Providing detailed information on SASL exceptions can give more information on Kerberos error. Change-Id: I14ecce124ab1dacd8c273ea64f215815c953effe Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/JndiAction.java 1 file changed, 7 insertions(+), 2 deletions(-) Approvals: Yair Zaslavsky: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6551 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I14ecce124ab1dacd8c273ea64f215815c953effe Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Use /var/tmp instead of /var/cache
by oschreib＠redhat.com 23 Jul '12

23 Jul '12

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: Use /var/tmp instead of /var/cache ...................................................................... packaging: Use /var/tmp instead of /var/cache This patch changes the directory used for temporary files from /var/cache to /var/tmp and changes the service script so that it completely removes all temporary files before starting and after stopping. Change-Id: I369f1d4175674b9b784cb33e1f4e4f58ff4820bf Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M packaging/fedora/engine-service.py M packaging/fedora/spec/ovirt-engine.spec.in 2 files changed, 15 insertions(+), 8 deletions(-) Approvals: Juan Hernandez: Verified Ofer Schreiber: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6453 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I369f1d4175674b9b784cb33e1f4e4f58ff4820bf Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Run with OpenJDK 7 regardless of what is installe...
by oschreib＠redhat.com 23 Jul '12

23 Jul '12

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: Run with OpenJDK 7 regardless of what is installed ...................................................................... packaging: Run with OpenJDK 7 regardless of what is installed This changes the start/stop script so that it will use OpenJDK 7 regardless of what other versions of the Java virtual machine are installed. If the Java virtual machine happens to be installed in a different place that the one used by default by the script it can be specified in the /etc/sysconfig/ovirt-engine with the JAVA_HOME variable. Change-Id: I44b5b4e20a134d1624acf1258c59b73d8d2382c6 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M packaging/fedora/engine-service.py 1 file changed, 21 insertions(+), 7 deletions(-) Approvals: Juan Hernandez: Verified Ofer Schreiber: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6223 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I44b5b4e20a134d1624acf1258c59b73d8d2382c6 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Deprecate & delete some classes in compat
by mkolesni＠redhat.com 23 Jul '12

23 Jul '12

Mike Kolesnik has submitted this change and it was merged. Change subject: core: Deprecate & delete some classes in compat ...................................................................... core: Deprecate & delete some classes in compat Some classes weren't being used anywhere, so they were deleted. Other classes have better java/apache-commons alternatives, so marked as deprecated to ward off using them further in the code. Further work needs to be done in order to rid the existing code of using these classes. Change-Id: I2ad81967bec1ba9bc5ff3de1abbf39093db67e51 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/CompatException.java D backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/ConsoleColor.java M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/DateFormatCompat.java M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/DictionaryEntry.java M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/DoubleCompat.java M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/IntegerCompat.java D backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/InvalidOperationException.java M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/LongCompat.java M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Match.java M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/MatchCollection.java M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/MatchGroups.java M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/NotImplementedException.java M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/NumberStyles.java M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Regex.java M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/RegexOptions.java D backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/RunspaceState.java D backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/RunspaceStateInfo.java D backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/SearchOption.java M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Serializable.java D backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/StoreName.java M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/StringBuilderCompat.java M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/StringFormat.java M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/StringHelper.java M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/StringTokenizerCompat.java M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/TimeZoneInfo.java D backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/TimeZoneNotFoundException.java 26 files changed, 58 insertions(+), 48 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5471 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2ad81967bec1ba9bc5ff3de1abbf39093db67e51 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Support multiple applications
by oschreib＠redhat.com 23 Jul '12

23 Jul '12

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: Support multiple applications ...................................................................... packaging: Support multiple applications Add support for multiple deployment units. At the moment we assume that there is only one deployment unit: engine.ear. This patch adds support for several deployment units. If more are needed they can be installed to the /usr/share/ovirt-engine directory and then their names added to the ENGINE_APPS variable in the /etc/sysconfig/ovirt-engine file, for example: ENGINE_APPS="engine.ear whatever.war" Change-Id: I1818927c5f2be8adbc30d3b99c0e3d015d3428ae Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M packaging/fedora/engine-service.py M packaging/fedora/engine-service.sysconfig 2 files changed, 40 insertions(+), 26 deletions(-) Approvals: Juan Hernandez: Verified Ofer Schreiber: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5900 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1818927c5f2be8adbc30d3b99c0e3d015d3428ae Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0