July 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Fix default network status on attach
by mkolesni＠redhat.com 23 Jul '12

23 Jul '12

Mike Kolesnik has submitted this change and it was merged. Change subject: core: Fix default network status on attach ...................................................................... core: Fix default network status on attach Network status is being saved to DB & later on updated, so need to save some default value and NonOperational is a reasonable choice. Change-Id: I17ea1594fe54203ce5d98fedd77dade64537f57c Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AttachNetworkToVdsGroupParameter.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Mike Kolesnik: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6543 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I17ea1594fe54203ce5d98fedd77dade64537f57c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove delegation to network_cluster
by mkolesni＠redhat.com 23 Jul '12

23 Jul '12

Mike Kolesnik has submitted this change and it was merged. Change subject: core: Remove delegation to network_cluster ...................................................................... core: Remove delegation to network_cluster Removed the delegating methods from the Network entity. Change-Id: I3cf53a3b0d54dd9175e8dbe7b087a5d9db18b05c Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachNetworkToVdsGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachNetworkFromVdsInterfaceCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Network.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/NetworkDAODbFacadeImpl.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CollectVdsNetworkDataVDSCommand.java 6 files changed, 11 insertions(+), 38 deletions(-) Approvals: Mike Kolesnik: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6531 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3cf53a3b0d54dd9175e8dbe7b087a5d9db18b05c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Don't rely on network_cluster existing
by mkolesni＠redhat.com 23 Jul '12

23 Jul '12

Mike Kolesnik has submitted this change and it was merged. Change subject: webadmin: Don't rely on network_cluster existing ...................................................................... webadmin: Don't rely on network_cluster existing Network contains network_cluster. Setting of cluster related properties (status, required and display) on Network should be done through network_cluster. Change-Id: I891a85d259a9a52550515cd49208f8dbf313d16a Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Network.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Cloner.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterNetworkListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterNetworkManageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterNetworkListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/LogicalNetworkModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateInterfaceListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGuideModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/ItemInfoPopup.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkPanel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/UnassignedNetworksPanel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterNetworkView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/NetworkStatusColumn.java 16 files changed, 121 insertions(+), 78 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6525 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I891a85d259a9a52550515cd49208f8dbf313d16a Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>

1 0

Change in ovirt-dwh[master]: etl: reordered etl default properties file (#838532)
by ydary＠redhat.com 23 Jul '12

23 Jul '12

Yaniv Dary has submitted this change and it was merged. Change subject: etl: reordered etl default properties file (#838532) ...................................................................... etl: reordered etl default properties file (#838532) Arranged parameters in logical order and separated them with headlines. https://bugzilla.redhat.com/838532 Change-Id: I6bef8c5d2ae0d43f3a71811efe39dc0f3261789e Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M data-warehouse/history_etl/context_files/ovirt_engine_dwh/historyetl_3_1/contexts/Default.properties 1 file changed, 40 insertions(+), 18 deletions(-) Approvals: Eli Mesika: Looks good to me, but someone else must approve Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6541 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6bef8c5d2ae0d43f3a71811efe39dc0f3261789e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: configure local storage - set default CPU
by derez＠redhat.com 23 Jul '12

23 Jul '12

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: configure local storage - set default CPU ...................................................................... webadmin: configure local storage - set default CPU https://bugzilla.redhat.com/838572 Set default CPU name to the one exposed by host. Change-Id: Ic44a952129e9be872e1f7a08f43e42ec76b764cb Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/ConfigureLocalStorageModel.java 1 file changed, 7 insertions(+), 3 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6526 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic44a952129e9be872e1f7a08f43e42ec76b764cb Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal | webadmin: locking mechanism dissapears slowly
by derez＠redhat.com 23 Jul '12

23 Jul '12

Daniel Erez has submitted this change and it was merged. Change subject: userportal | webadmin: locking mechanism dissapears slowly ...................................................................... userportal | webadmin: locking mechanism dissapears slowly The following problem was founded during creation vm from template, the problem is that if engine performs some operation on spm a dilog was stuck, because of call for creation of vm was sned in sinchronious way. The solution perfrom a call at asynchronious way Change-Id: Iae42b1066b679f9e9e5f83c39aa2432191aba8f6 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java 2 files changed, 43 insertions(+), 44 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6372 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iae42b1066b679f9e9e5f83c39aa2432191aba8f6 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: RegisterVdsQuery - use of concrete AuditLogType enum v...
by mlipchuk＠redhat.com 23 Jul '12

23 Jul '12

Maor Lipchuk has submitted this change and it was merged. Change subject: core: RegisterVdsQuery - use of concrete AuditLogType enum value ...................................................................... core: RegisterVdsQuery - use of concrete AuditLogType enum value replaced the use of AuditLogValue.getValue with concrete enum value Change-Id: I608ab773204e387fa164d0898b410a7b667dcfc9 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterVdsQuery.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6042 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I608ab773204e387fa164d0898b410a7b667dcfc9 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: RegisterVdsQuery -removed unnecessary null value check
by mlipchuk＠redhat.com 23 Jul '12

23 Jul '12

Maor Lipchuk has submitted this change and it was merged. Change subject: core: RegisterVdsQuery -removed unnecessary null value check ...................................................................... core: RegisterVdsQuery -removed unnecessary null value check the private method isValidOtp() checks also for a null otp, so there is no reason to check if it's null before invocation of the method Change-Id: I53542e8a06d12b9b9fc586f1331538400d357bca Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterVdsQuery.java 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6067 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I53542e8a06d12b9b9fc586f1331538400d357bca Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Move usbfilter.txt to /etc/ovirt-engine
by oschreib＠redhat.com 23 Jul '12

23 Jul '12

Ofer Schreiber has submitted this change and it was merged. Change subject: webadmin: Move usbfilter.txt to /etc/ovirt-engine ...................................................................... webadmin: Move usbfilter.txt to /etc/ovirt-engine This is a configuration file, so it should go into the /etc directory. I am still not 100% sure about the location in the source tree, but certainly not deep into the Java packages directories. Change-Id: I01ec508dc6254351cc05f067880dd6d62e31c843 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M Makefile M backend/manager/modules/root/src/main/webapp/WEB-INF/web.xml R frontend/usbfilter.txt M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/UserPortalConfigurator.java M packaging/fedora/spec/ovirt-engine.spec.in 5 files changed, 23 insertions(+), 3 deletions(-) Approvals: Juan Hernandez: Verified Ofer Schreiber: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6344 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I01ec508dc6254351cc05f067880dd6d62e31c843 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: backend: Fix MonitoringStrategyFactoryTest
by oourfali＠redhat.com 23 Jul '12

23 Jul '12

Oved Ourfali has submitted this change and it was merged. Change subject: backend: Fix MonitoringStrategyFactoryTest ...................................................................... backend: Fix MonitoringStrategyFactoryTest This commit fixes the MonitoringStrategyFactoryTest, to make it unsensitive to the order of the testers. Change-Id: Iac04727735eb7e077da587239ad7d49b976fb9fc Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/MonitoringStrategyFactoryTest.java 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Looks good to me, but someone else must approve Yair Zaslavsky: Looks good to me, approved Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6539 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iac04727735eb7e077da587239ad7d49b976fb9fc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0