July 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine-cli[master]: cli: do not sort command options in /help/ commands
by mpastern＠redhat.com 04 Jul '12

04 Jul '12

Michael Pasternak has submitted this change and it was merged. Change subject: cli: do not sort command options in /help/ commands ...................................................................... cli: do not sort command options in /help/ commands sorting options breaks collections-based option sub-elements representation Change-Id: Icab489cbf27994b855ef7234c8edcf28fc714a70 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/cli/command/command.py M src/cli/command/help.py M src/ovirtcli/command/help.py 3 files changed, 5 insertions(+), 5 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Ori Liel: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/5917 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icab489cbf27994b855ef7234c8edcf28fc714a70 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: VmInfoBuilder - null specParams fix
by mkublin＠redhat.com 04 Jul '12

04 Jul '12

Michael Kublin has submitted this change and it was merged. Change subject: core: VmInfoBuilder - null specParams fix ...................................................................... core: VmInfoBuilder - null specParams fix A treatment for null specParams was introduced in I07c38327. Following a converstaion with mkublin, this patch introduces a different fix, which better suits the intended flow. Change-Id: Id9d14137f97945893343f90487a2305639e4ddee Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5927 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id9d14137f97945893343f90487a2305639e4ddee Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: UnPowerMock AddVmCommandTest
by mkublin＠redhat.com 04 Jul '12

04 Jul '12

Michael Kublin has submitted this change and it was merged. Change subject: core: UnPowerMock AddVmCommandTest ...................................................................... core: UnPowerMock AddVmCommandTest Removed PowerMock dependency from AddVmCommandTest and replaced it with spying the command directly. This improvement required some subtle refactoing in the add command classes themselves and the static handlers they use. Change-Id: Ib791c30f5453eddbecb8a780e54001201aec713b Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmTemplateCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java 6 files changed, 177 insertions(+), 179 deletions(-) Approvals: Michael Kublin: Looks good to me, approved Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/5922 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib791c30f5453eddbecb8a780e54001201aec713b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Removing unused parameters from methods in QuotaMana...
by mkublin＠redhat.com 04 Jul '12

04 Jul '12

Michael Kublin has submitted this change and it was merged. Change subject: engine: Removing unused parameters from methods in QuotaManager. ...................................................................... engine: Removing unused parameters from methods in QuotaManager. addCommandForExistingQuota() does not use 'quotaLimitId' and validateStorageForEnforcedStoragePool() does not use 'commandId'. Change-Id: I37428574eb89ef483b918ba8ef5e912eb48eb92b Signed-off-by: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QuotaManager.java 1 file changed, 2 insertions(+), 6 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5909 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I37428574eb89ef483b918ba8ef5e912eb48eb92b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Ryan Harper <ryanh(a)us.ibm.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: history: update etl minimal version to 3.1
by emesika＠redhat.com 04 Jul '12

04 Jul '12

Eli Mesika has submitted this change and it was merged. Change subject: history: update etl minimal version to 3.1 ...................................................................... history: update etl minimal version to 3.1 Change-Id: Ia84da10b075348b260e3c40d867c8482d30b48f1 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M backend/manager/dbscripts/upgrade/pre_upgrade/config.sql 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Eli Mesika: Verified; Looks good to me, approved Yaniv Dary: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/5901 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia84da10b075348b260e3c40d867c8482d30b48f1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: engine-cleanup - Replace hardcoded Jboss string
by oschreib＠redhat.com 04 Jul '12

04 Jul '12

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: engine-cleanup - Replace hardcoded Jboss string ...................................................................... packaging: engine-cleanup - Replace hardcoded Jboss string https://bugzilla.redhat.com/831263 Replace hardcoded Jboss string with service name variable Change-Id: I51172286883dfdf8e03498b838f3bdf6b2f20024 Signed-off-by: Kiril Nesenko <knesenko(a)redhat.com> --- M packaging/fedora/setup/engine-cleanup.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Ofer Schreiber: Looks good to me, approved Kiril Nesenko: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/5887 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I51172286883dfdf8e03498b838f3bdf6b2f20024 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: remove unused parameter from createRunVmContext()
by mkublin＠redhat.com 04 Jul '12

04 Jul '12

Michael Kublin has submitted this change and it was merged. Change subject: engine: remove unused parameter from createRunVmContext() ...................................................................... engine: remove unused parameter from createRunVmContext() A VM is passed to this method which is never used in the method. This patch removes the parameter and also all calling methods. Change-Id: I169cda709e1a1238cbf060706f075211e01f751d Signed-off-by: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachUserToVmFromPoolAndRunCommand.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5907 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I169cda709e1a1238cbf060706f075211e01f751d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Ryan Harper <ryanh(a)us.ibm.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: boolean parameter pollingEnabled is not used in meth...
by mkublin＠redhat.com 03 Jul '12

03 Jul '12

Michael Kublin has submitted this change and it was merged. Change subject: engine: boolean parameter pollingEnabled is not used in method. ...................................................................... engine: boolean parameter pollingEnabled is not used in method. This patch removes unused parameter pollingEnabled from method CreateTask in class AsyncTaskManager. This patch also updated all calls made to this method from other classes. Change-Id: Ifb2af9f06ba8c46c0c98eaf54d631b46c47b2c64 Signed-off-by: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddImageFromScratchCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AsyncTaskManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateCloneOfTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateImageTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyImageGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveTemplateSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreFromSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java 12 files changed, 12 insertions(+), 13 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5905 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifb2af9f06ba8c46c0c98eaf54d631b46c47b2c64 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Ryan Harper <ryanh(a)us.ibm.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Remove unused ArrayList in vmIsRunningStateless()
by mkublin＠redhat.com 03 Jul '12

03 Jul '12

Michael Kublin has submitted this change and it was merged. Change subject: engine: Remove unused ArrayList in vmIsRunningStateless() ...................................................................... engine: Remove unused ArrayList in vmIsRunningStateless() This method is passing a String ArrayList which is not used. Change-Id: I0cbfbadb13ebbd22b34a732e4b0551646edefc86 Signed-off-by: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolCommandBase.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5911 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0cbfbadb13ebbd22b34a732e4b0551646edefc86 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Ryan Harper <ryanh(a)us.ibm.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Replacing StringHelper with Apache StringUtils.
by lhornyak＠redhat.com 03 Jul '12

03 Jul '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: engine: Replacing StringHelper with Apache StringUtils. ...................................................................... engine: Replacing StringHelper with Apache StringUtils. StringHelper is deprecated. Change-Id: I1649ce003d5df36d0ce1b52064de00e320d33f02 Signed-off-by: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ErrorTranslatorImpl.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5850 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1649ce003d5df36d0ce1b52064de00e320d33f02 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Ryan Harper <ryanh(a)us.ibm.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0