July 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Cleanup in VmOldInfoBuilder
by lhornyak＠redhat.com 03 Jul '12

03 Jul '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: Cleanup in VmOldInfoBuilder ...................................................................... core: Cleanup in VmOldInfoBuilder Removed dependency on deprecarted StringHelper class. Change-Id: Idbc9b5be2a134881ac20a709569e97a599c7d9da Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmOldInfoBuilder.java 1 file changed, 6 insertions(+), 5 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5873 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idbc9b5be2a134881ac20a709569e97a599c7d9da Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Cleanup in VmInfoBuilderBase
by mkublin＠redhat.com 03 Jul '12

03 Jul '12

Michael Kublin has submitted this change and it was merged. Change subject: core: Cleanup in VmInfoBuilderBase ...................................................................... core: Cleanup in VmInfoBuilderBase Removed dependency on the deprecated StringHelper class. Change-Id: I4c49d5bafd2da642206f18aa16700f36198598b7 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java 1 file changed, 6 insertions(+), 7 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5872 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4c49d5bafd2da642206f18aa16700f36198598b7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Cleanup in CreateVmFromSysPrepVDSCommand
by lhornyak＠redhat.com 03 Jul '12

03 Jul '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: Cleanup in CreateVmFromSysPrepVDSCommand ...................................................................... core: Cleanup in CreateVmFromSysPrepVDSCommand Removed dependency on deprecated StringHelper class. Change-Id: I262c37c3b0433085457ce9b9db39b810ffda7ede Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CreateVmFromSysPrepVDSCommand.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved Michael Kublin: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5871 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I262c37c3b0433085457ce9b9db39b810ffda7ede Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Cleanup in SetupNetworksVDSCommand
by lhornyak＠redhat.com 03 Jul '12

03 Jul '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: Cleanup in SetupNetworksVDSCommand ...................................................................... core: Cleanup in SetupNetworksVDSCommand Some java cleanup: * Removed dependency on the deprecated StringHelper class. * Made private helper methods static where possible Change-Id: I5a8d51912251bfc35e99f8080aff79dc668d50c9 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommand.java 1 file changed, 4 insertions(+), 5 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5870 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5a8d51912251bfc35e99f8080aff79dc668d50c9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Cleanup in GetStorageDomainStatsVDSCommand
by lhornyak＠redhat.com 03 Jul '12

03 Jul '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: Cleanup in GetStorageDomainStatsVDSCommand ...................................................................... core: Cleanup in GetStorageDomainStatsVDSCommand Some java cleanup: * Removed dependency on the deprecated StringHelper class. * Removed commented out block. * Made log final. Change-Id: I024464baa978ef9922d04696217a327bf1b8bd88 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetStorageDomainStatsVDSCommand.java 1 file changed, 3 insertions(+), 4 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5869 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I024464baa978ef9922d04696217a327bf1b8bd88 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Cleanup in BrokerCommandBase
by lhornyak＠redhat.com 03 Jul '12

03 Jul '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: Cleanup in BrokerCommandBase ...................................................................... core: Cleanup in BrokerCommandBase Some java cleanup: * Removed dependency on the deprecated StringHelper class. * Removed FQCNs. * Removed commented out block. * Made log final. Change-Id: I5c298c01920be8dd27ce23cdaf1e3c4b8235716f Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/BrokerCommandBase.java 1 file changed, 7 insertions(+), 9 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5868 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5c298c01920be8dd27ce23cdaf1e3c4b8235716f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Clenaup in GetDeviceListVDSCommand
by lhornyak＠redhat.com 03 Jul '12

03 Jul '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: Clenaup in GetDeviceListVDSCommand ...................................................................... core: Clenaup in GetDeviceListVDSCommand Removed dependency on deprecated StringHelper. Change-Id: I3659159a7ea631e7fc1fbe9f7c7cb64322ff8729 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetDeviceListVDSCommand.java 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5867 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3659159a7ea631e7fc1fbe9f7c7cb64322ff8729 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Clenaup in SysprepHandler
by lhornyak＠redhat.com 03 Jul '12

03 Jul '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: Clenaup in SysprepHandler ...................................................................... core: Clenaup in SysprepHandler Some general java cleanup: * Removed dependency on deprecated StringHelper * Replaced FQCNs with imports * Added final to immutable static members Change-Id: Ic965f251458f07484f7de7de350f1d9ba8b6dcd9 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SysprepHandler.java 1 file changed, 10 insertions(+), 11 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5866 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic965f251458f07484f7de7de350f1d9ba8b6dcd9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Cleanup in VdsBrokerObjectsBuilder
by lhornyak＠redhat.com 03 Jul '12

03 Jul '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: Cleanup in VdsBrokerObjectsBuilder ...................................................................... core: Cleanup in VdsBrokerObjectsBuilder Some general java cleanup: * Removed usages of deprecated StringHelper * Replaced FQCNs with imports * Added @SupressWarnings to Eclipse IDE's false warnings * Reomved commented out blocks Change-Id: I6c279f49f3868f4193a08a7cafa57f159fc8a8fe Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 1 file changed, 82 insertions(+), 119 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5865 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6c279f49f3868f4193a08a7cafa57f159fc8a8fe Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Cleanup in DbUserDAODbFacadeImpl
by lhornyak＠redhat.com 03 Jul '12

03 Jul '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: Cleanup in DbUserDAODbFacadeImpl ...................................................................... core: Cleanup in DbUserDAODbFacadeImpl Did some general java cleanups: * Removed dependency on the deprecated StringHelper * Added a static instace to the row mapper as per http://www.ovirt.org/wiki/Backend_Coding_Standards * Removed unneeded @SuppressWarnings annotations Change-Id: Ibfe42305f27bbd3bfe4a3216569f40c37a8af0fb Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DbUserDAODbFacadeImpl.java 1 file changed, 16 insertions(+), 23 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5864 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibfe42305f27bbd3bfe4a3216569f40c37a8af0fb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0