September 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: userportal, webadmin: Invalid Time Zone Shown for Windows Gue...
by tjelinek＠redhat.com 25 Sep '12

25 Sep '12

Tomas Jelinek has submitted this change and it was merged. Change subject: userportal,webadmin: Invalid Time Zone Shown for Windows Guests ...................................................................... userportal,webadmin: Invalid Time Zone Shown for Windows Guests VM -> General: Time zone Removed until VDSM and Guest agent will support returning of the time zone from within a guest. It is not really deleted, just commente, so it will be more simple to find it once it has to be moved back. Change-Id: I5684eb26ab53ed52d1b47b3ece24811b1f1425da Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmGeneralModelForm.java 1 file changed, 10 insertions(+), 6 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7976 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5684eb26ab53ed52d1b47b3ece24811b1f1425da Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal, webadmin: Run once: unable to attach floppy disks...
by tjelinek＠redhat.com 25 Sep '12

25 Sep '12

Tomas Jelinek has submitted this change and it was merged. Change subject: userportal,webadmin: Run once: unable to attach floppy disks (#855579) ...................................................................... userportal,webadmin: Run once: unable to attach floppy disks (#855579) https://bugzilla.redhat.com/855579 The problem was, that the IsoDomainListSyncronizer. getUserRequestForStoragePoolAndDomainRepoFileList ignored the fileTypeExtension. Fixed by enriching the IsoDomainListSyncronizer.getCachedIsoListByStoragePoolAndDomainId by fileTypeExtension the same way as getCachedIsoListByDomainId is done. Change-Id: I11d2f7caf8f75efd83e3b557c9e305baebcef2ec Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsoDomainListSyncronizer.java 1 file changed, 5 insertions(+), 4 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7965 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I11d2f7caf8f75efd83e3b557c9e305baebcef2ec Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Removing TransactiveAttribute and appropriate logic
by mkublin＠redhat.com 25 Sep '12

25 Sep '12

Michael Kublin has submitted this change and it was merged. Change subject: core: Removing TransactiveAttribute and appropriate logic ...................................................................... core: Removing TransactiveAttribute and appropriate logic The following attribute was used in order to perform a rollback at case of failure inside Vds commands. The following approach was used only at one command AddNetworkVDSCommand correctly and was used incorrect at IrsCreateCommand and ConnectStorageServerVDSCommand. Also, we should not perform a rollback inside of vds command , a rollback should be done from BL commands or any other BL manager. Also, the Vds commands should be run outside scope of transaction, it is mean that the transactional rollback is not relevant for them. Change-Id: I12638ee4c27d8548fc5e1a3212ec4541507fd023 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- D backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/TransactiveAttribute.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcCommandBase.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsCreateCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/AddNetworkVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ConnectStorageServerVDSCommand.java 5 files changed, 7 insertions(+), 68 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8189 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I12638ee4c27d8548fc5e1a3212ec4541507fd023 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: add locks to VmTemplate commands (#761515)
by mkublin＠redhat.com 25 Sep '12

25 Sep '12

Michael Kublin has submitted this change and it was merged. Change subject: core: add locks to VmTemplate commands (#761515) ...................................................................... core: add locks to VmTemplate commands (#761515) https://bugzilla.redhat.com/761515 Currently the different VmTemplate commands make use of DB lock only, which causes to different race conditions (as the lock is check and only then acquired - non atomic operation). This patch adds to the different VmTemplate commands the use of in-memory lock and canDoAction() checks in order to prevent those race conditions and possible corruption. NOTE: this patch doesn't add the use of locks to the different export domain VmTemplate related commands, the reason for this is that the exported template is not present on the engine DB so a lock on that export object cannot be done. Change-Id: I2d5b6518bbf19077ae5822b9359a6147c87d0f46 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmTemplateHandler.java 5 files changed, 61 insertions(+), 46 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8013 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2d5b6518bbf19077ae5822b9359a6147c87d0f46 Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: Use the parent parameters in RemoveAllVmImagesCommand
by mkublin＠redhat.com 25 Sep '12

25 Sep '12

Michael Kublin has submitted this change and it was merged. Change subject: Use the parent parameters in RemoveAllVmImagesCommand ...................................................................... Use the parent parameters in RemoveAllVmImagesCommand When performing the RemoveAllVmImagesCommand we shouldn't replace the parent parameters with the RemoveAllVmImagesParameters. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=840525 Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com> Change-Id: If4466e2e29bcaf67c44f51c93dc6b98ca916bae9 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAllVmImagesCommand.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8119 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If4466e2e29bcaf67c44f51c93dc6b98ca916bae9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: fixed exception during creation of VM from template
by derez＠redhat.com 25 Sep '12

25 Sep '12

Daniel Erez has submitted this change and it was merged. Change subject: core: fixed exception during creation of VM from template ...................................................................... core: fixed exception during creation of VM from template During executing AddVmFromTemplateCommand, the parent parameters weren't set on CloneVmFromVmTemplateCommand paramaters which is being executed within. CommandBase throws an exception when the parent parameters aren't set which cause the template to remain in image locked status. Change-Id: I47633b3cb6b2f5b078bdc8d8955f17eed1edd71e Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommand.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8194 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I47633b3cb6b2f5b078bdc8d8955f17eed1edd71e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: CI - ban artifacts in common project to avoid compilat...
by rgolan＠redhat.com 25 Sep '12

25 Sep '12

Roy Golan has submitted this change and it was merged. Change subject: core: CI - ban artifacts in common project to avoid compilation problem of GWT ...................................................................... core: CI - ban artifacts in common project to avoid compilation problem of GWT Use enforcer plugin to ban artifacts that will fail the frontend GWT compilation. Tested: added commons-lang dependency to the project, no uses still in java classes. mvn clean install failed fast early in compilation. build time remaind the same. Change-Id: I55c1c380d76f779203017cb17a240fa854fc6308 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/common/pom.xml 1 file changed, 29 insertions(+), 1 deletion(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6785 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I55c1c380d76f779203017cb17a240fa854fc6308 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: show LUN id in audit log when SD partially inaccessibl...
by derez＠redhat.com 25 Sep '12

25 Sep '12

Daniel Erez has submitted this change and it was merged. Change subject: core: show LUN id in audit log when SD partially inaccessible (#854214) ...................................................................... core: show LUN id in audit log when SD partially inaccessible (#854214) https://bugzilla.redhat.com/854214 When an SD is not accessible (e.g. VDSM reports iSCSI error), the audit log message now reports the affected lun instead of just the connection. Change-Id: I6ba766c552a56940c4559b4cd73702627ff13eed Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperBase.java 2 files changed, 9 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8028 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6ba766c552a56940c4559b4cd73702627ff13eed Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: error message when deactivating SD with active VMs (#8...
by derez＠redhat.com 25 Sep '12

25 Sep '12

Daniel Erez has submitted this change and it was merged. Change subject: core: error message when deactivating SD with active VMs (#843407) ...................................................................... core: error message when deactivating SD with active VMs (#843407) https://bugzilla.redhat.com/843407 canDoAction() of DeactivateStorageDomainCommand runs a stored procedure to find VMs whose status should prevent deactivation. This patch renames the SP and associated DAO methods to reflect what it is really searching for (non-"Down" VMs), as well as changes the error message to accurately reflect the cause of the failure. Change-Id: I3ce9ce378ffeed980af508e6556f9d844a3e07bd Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M backend/manager/dbscripts/vms_sp.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDAOTest.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 10 files changed, 17 insertions(+), 17 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7997 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3ce9ce378ffeed980af508e6556f9d844a3e07bd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: throttle running of VMs (#843058)
by rgolan＠redhat.com 25 Sep '12

25 Sep '12

Roy Golan has submitted this change and it was merged. Change subject: core: throttle running of VMs (#843058) ...................................................................... core: throttle running of VMs (#843058) https://bugzilla.redhat.com/show_bug.cgi?id=843058 Bulk running of VMs regulary falls short in running all VMs. The reason is the VdsSelector counts and reserves memory using: a) host commited memory: # of VMs * each VM static mem b) pending VM count memory : # of VMs to run * their memory count ; a shared state variable pending VM count is increased by the end of RunVm and decreased by VdsUpdateRunTimeInfo i.e two independent processes, one as a command thread and the other is a scheduled quartz job thread. As long as the VdsUpdateRunTimeInfo doesn't run, theres an overflow in the calculation of the free memory to run VM which causes a host to be falsely not selected to run the VM. The throttler here is using the shared-state between the VdsUpdateRunTimeInfo and the RunVmCommands, the pending VM count and is using a wait/notify semantics to let the VdsUpdateRunTimeInfo interleave, if we don't have enough memory run the VM. - Tests - setup: 1 Host with 128Gb mem with 120 VMs and cluster 200% over commit 1 Host with 8Gb mem, 3.0 pool and cluster, 10 VMs 2 Host with 4Gb mem, 3.1 pool and cluster, 5 VMs on the 128Gb host I activated 100 VMs with 3G and 82 of them got online. without the fix I hit 51 limit. with no over commit I was able to run also 67 and without the fix also 50 multiple run 10 VMs - prior to the fix the 9th and 10th can't locate a host to run on. after the fix all 10 VMs complete the run. In the 9th VM run the selector waits for the update to decrease memory and continue after less than a second. migrate VMs back and forth of 5 VMs with no issues. VmPool - same scheduling effects. Change-Id: I076ede6cba919bc61f7546d7b29ef436eb6d3375 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/NonWaitingDelayer.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmDelayer.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsFreeMemoryChecker.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsSelector.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolCommandBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RunVmCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/IVdsAsyncCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsMonitor.java 15 files changed, 242 insertions(+), 33 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7204 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I076ede6cba919bc61f7546d7b29ef436eb6d3375 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0