Change in ovirt-dwh[master]: packaging: setup: validating read-only user before creation
by ydary＠redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: packaging: setup: validating read-only user before creation
......................................................................
packaging: setup: validating read-only user before creation
The new implementation validates provided username before
it creates a readonly user. The user provided cannot be one
of the reserved users (postgres, engine, engine_history and
engine_reports), it cannot be empty and it should not exist
in the DB.
Change-Id: Ic404e565a765c82d42f92a211a59d06c8a59d807
Bug-Url: https://bugzilla.redhat.com/1006948
Signed-off-by: Alex Lourie <alourie(a)redhat.com>
---
M packaging/common_utils.py
M packaging/ovirt-engine-dwh-setup.py
2 files changed, 41 insertions(+), 5 deletions(-)
Approvals:
Alex Lourie: Verified
Yaniv Dary: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19944
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic404e565a765c82d42f92a211a59d06c8a59d807
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-dwh
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
11 years, 1 month
Change in ovirt-engine[master]: core: clear snapshot_id from floating disks script
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: core: clear snapshot_id from floating disks script
......................................................................
core: clear snapshot_id from floating disks script
Clearing snapshot_id from floating disks upgrade script.
Change-Id: Ifa0863a7338e22d7fbb96766937edfe28881ad57
Bug-Url: https://bugzilla.redhat.com/1015170
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
A packaging/dbscripts/upgrade/03_03_0980_clear_snapshot_id_of_floating_disks.sql
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19976
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifa0863a7338e22d7fbb96766937edfe28881ad57
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
11 years, 1 month
Change in ovirt-engine[master]: core: Add no-arg constructor to Parameters classes
by vszocs＠redhat.com
Vojtech Szocs has submitted this change and it was merged.
Change subject: core: Add no-arg constructor to Parameters classes
......................................................................
core: Add no-arg constructor to Parameters classes
This is required in order to avoid potential serialization
issues with GWT RPC.
Change-Id: I54a256a7a9c36485630740d82bc0393561f9516a
Bug-Url: https://bugzilla.redhat.com/1015683
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ActivateDeactivateVmNicParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddExternalEventParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddExternalJobParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddExternalStepParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AttachDettachVmDiskParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/EndExternalJobParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/EndExternalStepParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/GetDiskAlignmentParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/HostStoragePoolParametersBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RegisterDiskParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveExternalEventParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/AdGroupsSearchParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/AdUsersSearchParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetAuditLogByIdParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetHostsForStorageOperationParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetImageByIdParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetStepsByJobIdQueryParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetUnregisteredDiskQueryParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetUnregisteredDisksQueryParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmByVmNameForDataCenterParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmFromConfigurationQueryParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/HasAdElementReconnectPermissionParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/SignStringParameters.java
23 files changed, 70 insertions(+), 2 deletions(-)
Approvals:
Vojtech Szocs: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/18908
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I54a256a7a9c36485630740d82bc0393561f9516a
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 1 month
Change in ovirt-image-uploader[ovirt-image-uploader-3.2]: log: default logging to timestamped files
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: log: default logging to timestamped files
......................................................................
log: default logging to timestamped files
Log messages to timestamped files as default,
avoiding to overwrite existing ones.
The default location of the logs was changed,
to improve /var/log/ovirt-engine sanity.
/var/log/ovirt-engine -> /var/log/ovirt-engine/ovirt-image-uploader
A log rotation was introduced in order to compress old logs.
Bug-Url: https://bugzilla.redhat.com/1016651
Change-Id: I01957d865f437636c0f1bf794075ee6a3895b94e
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M .gitignore
M configure.ac
M ovirt-image-uploader.spec.in
M src/Makefile.am
M src/__main__.py
A src/config.py.in
A src/logrotate.d/Makefile.am
A src/logrotate.d/ovirt-image-uploader.in
8 files changed, 104 insertions(+), 6 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Alex Lourie: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/19990
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I01957d865f437636c0f1bf794075ee6a3895b94e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-image-uploader
Gerrit-Branch: ovirt-image-uploader-3.2
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
11 years, 1 month
Change in ovirt-engine[master]: restapi: Start VM not as RunOnce
by mpastern＠redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: restapi: Start VM not as RunOnce
......................................................................
restapi: Start VM not as RunOnce
The BackendVmResource.start issued RunVmOnce command even if none
additional parameters were provided.
Now we check if a Vm is passed in the Action and if not, we issue
regular RunVmCommand.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1005562
Change-Id: I40be200c8742d8b31b7881926c59deaf345992ec
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmResourceTest.java
2 files changed, 28 insertions(+), 8 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19267
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I40be200c8742d8b31b7881926c59deaf345992ec
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 1 month
Change in ovirt-engine[ovirt-engine-3.3]: core: Adds scheduled job DwhHeartBeat
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: core: Adds scheduled job DwhHeartBeat
......................................................................
core: Adds scheduled job DwhHeartBeat
Adds DwhHeartBeatInterval option to ConfigValues.
Adds scheduled job DwhHeartBeat that periodically updates dwhHeart
variable in dwh_history_timekeeping table.
DwhHeartBeatInterval is editable in engine-config.
Change-Id: Ib0db94681e678f10af40e2ffd3399231e0b8e421
Bug-Url: https://bugzilla.redhat.com/962177
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/dwh/DwhHeartBeat.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
M packaging/etc/engine-config/engine-config.properties
5 files changed, 75 insertions(+), 0 deletions(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19828
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib0db94681e678f10af40e2ffd3399231e0b8e421
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 1 month
Change in ovirt-engine[ovirt-engine-3.3]: core: Adds entity DwhHistoryTimekeeping and variable heartBeat
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: core: Adds entity DwhHistoryTimekeeping and variable heartBeat
......................................................................
core: Adds entity DwhHistoryTimekeeping and variable heartBeat
Adds store procedures to access dwh_history_timekeeping table.
Adds business entity DwhShistoryTimekeeping and its DAO.
Adds new variable 'heartBeat' to dwh_history_timekeeping table
Change-Id: Ib4f41ed69d77f006ce406f09d20b259ed3335ff9
Bug-Url: https://bugzilla.redhat.com/962177
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DwhHistoryTimekeeping.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DwhHistoryTimekeepingVariable.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java
A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/dwh/DwhHistoryTimekeepingDao.java
A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/dwh/DwhHistoryTimekeepingDaoDbFacadeImpl.java
M backend/manager/modules/dal/src/main/jdbc-resources/engine-daos.properties
A backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/dwh/DwhHistoryTimekeepingDaoTest.java
A packaging/dbscripts/dwh_history_timekeeping_sp.sql
A packaging/dbscripts/upgrade/03_03_0930_add_dwh_heartbeat.sql
9 files changed, 296 insertions(+), 0 deletions(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19827
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib4f41ed69d77f006ce406f09d20b259ed3335ff9
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 1 month
Change in ovirt-engine[ovirt-engine-3.3]: webadmin: update search string on bookmark selection
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: webadmin: update search string on bookmark selection
......................................................................
webadmin: update search string on bookmark selection
After editing a bookmark name, that bookmark wasn't being properly cleared
of its selection. The UI component was no longer selected, but the model
thought it was still selected. So re-clicking that bookmark had no effect.
Fixed by properly clearing the bookmark selection on bookmark save.
Change-Id: Ic9763ab32eb3fcef7375553e7b9e264899583a1d
Bug-Url: https://bugzilla.redhat.com/996611
Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/bookmarks/BookmarkListModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uicommon/model/BookmarkModelProvider.java
2 files changed, 28 insertions(+), 0 deletions(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19812
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic9763ab32eb3fcef7375553e7b9e264899583a1d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 1 month
Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Disable external networks in Setup Networks
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: webadmin: Disable external networks in Setup Networks
......................................................................
webadmin: Disable external networks in Setup Networks
Changed the appearance of external networks in Setup Host Networks to
look disabled and not be draggable, as they truly shouldn't be
statically assigned to the host's interfaces.
Did this by extending the hierarchy of related
classes. InternalNetworkPanel should behave like a native network,
while ExternalNetworkPanel is a disabled variation of it. Common code
is housed in the common ancestor NetworkPanel. Also refactored some
code around UnassignedNetworksPanel for reuse.
Change-Id: I556ec7a330236dbdb204b82b2ff67f86ed4dbea8
Bug-Url: https://bugzilla.redhat.com/990612
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkOperationFactory.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostSetupNetworksPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostSetupNetworksPopupView.ui.xml
A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/ExternalNetworkPanel.java
A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/ExternalNetworksPanel.java
A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/InternalNetworkPanel.java
A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/InternalNetworksPanel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkGroup.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkPanel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkPanelsStyle.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/UnassignedNetworksPanel.java
12 files changed, 236 insertions(+), 88 deletions(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19822
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I556ec7a330236dbdb204b82b2ff67f86ed4dbea8
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 1 month
Change in ovirt-engine[ovirt-engine-3.3]: webadmin: help icon overflow
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: webadmin: help icon overflow
......................................................................
webadmin: help icon overflow
- Fixed issue where if a popup header was too long it would cause
the help icon to overflow to the next line and look out of place.
Re-arranged the header layout a little bit so the title text is in
its own div that is moved on top of the title background to allow
for flowing onto any background.
Signed-off-by: Alexander Wels <awels(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1001554
Change-Id: I10abcbd977df4367584cc22529b47334c4c00d99
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/SimpleDialogPanel.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/SimpleDialogPanel.ui.xml
M packaging/branding/ovirt.brand/common.css
3 files changed, 32 insertions(+), 42 deletions(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19850
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I10abcbd977df4367584cc22529b47334c4c00d99
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 1 month